2011-11-15 06:34:04

by Dan Carpenter

Subject: [patch] mac80211: use kfree_skb() instead of kfree()

sk_buff structs should be freed using kfree_skb().

This was introduced recently in 029458212 "mac80211: Save probe
response data for bss".

Signed-off-by: Dan Carpenter <[email protected]>

diff --git a/net/mac80211/iface.c b/net/mac80211/iface.c
index 12a6d4b..b34ca0c 100644
--- a/net/mac80211/iface.c
+++ b/net/mac80211/iface.c
@@ -474,7 +474,7 @@ static void ieee80211_do_stop(struct ieee80211_sub_if_data *sdata,
RCU_INIT_POINTER(sdata->u.ap.probe_resp, NULL);
synchronize_rcu();
kfree(old_beacon);
- kfree(old_probe_resp);
+ kfree_skb(old_probe_resp);

/* down all dependent devices, that is VLANs */
list_for_each_entry_safe(vlan, tmpsdata, &sdata->u.ap.vlans,

2011-11-15 06:38:43

by Arik Nemtsov

Subject: Re: [patch] mac80211: use kfree_skb() instead of kfree()

On Tue, Nov 15, 2011 at 08:33, Dan Carpenter <[email protected]> wrote:
> sk_buff structs should be freed using kfree_skb().
>
> This was introduced recently in 029458212 "mac80211: Save probe
> response data for bss".
>

Thanks for this one. I'm getting careless lately.. :)

Arik