2011-12-16 20:25:48

by Dan Carpenter

Subject: [patch 1/2] NFC: double unlock in nfc_llcp_recv_connect()

We unlock inside the if block on the other side of this if else
statement. It could result in calling mutex_unlock() twice.

Signed-off-by: Dan Carpenter <[email protected]>

diff --git a/net/nfc/llcp/llcp.c b/net/nfc/llcp/llcp.c
index 67756b2..f99d6b4 100644
--- a/net/nfc/llcp/llcp.c
+++ b/net/nfc/llcp/llcp.c
@@ -554,11 +554,9 @@ static void nfc_llcp_recv_connect(struct nfc_llcp_local *local,
goto enqueue;
}
}
-
+ mutex_unlock(&local->socket_lock);
}

- mutex_unlock(&local->socket_lock);
-
reason = LLCP_DM_NOBOUND;
goto fail;

2011-12-18 20:37:41

by Samuel Ortiz

Subject: Re: [patch 1/2] NFC: double unlock in nfc_llcp_recv_connect()

Hi Dan,

On Fri, Dec 16, 2011 at 11:25:29PM +0300, Dan Carpenter wrote:
> We unlock inside the if block on the other side of this if else
> statement. It could result in calling mutex_unlock() twice.
>
> Signed-off-by: Dan Carpenter <[email protected]>
Acked-by: Samuel Ortiz <[email protected]>

Thanks,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/