2011-12-16 20:26:22

by Dan Carpenter

Subject: [patch 2/2] NFC: use kfree_skb() for sk_buffs

This is a struct sk_buff pointer and it should be freed with kfree_skb()
instead of kfree().

Signed-off-by: Dan Carpenter <[email protected]>

diff --git a/net/nfc/llcp/llcp.c b/net/nfc/llcp/llcp.c
index f99d6b4..1d32680 100644
--- a/net/nfc/llcp/llcp.c
+++ b/net/nfc/llcp/llcp.c
@@ -954,7 +954,7 @@ void nfc_llcp_unregister_device(struct nfc_dev *dev)
skb_queue_purge(&local->tx_queue);
destroy_workqueue(local->tx_wq);
destroy_workqueue(local->rx_wq);
- kfree(local->rx_pending);
+ kfree_skb(local->rx_pending);
kfree(local);
}

2011-12-18 20:39:06

by Samuel Ortiz

Subject: Re: [patch 2/2] NFC: use kfree_skb() for sk_buffs

Hi Dan,

On Fri, Dec 16, 2011 at 11:26:00PM +0300, Dan Carpenter wrote:
> This is a struct sk_buff pointer and it should be freed with kfree_skb()
> instead of kfree().
>
> Signed-off-by: Dan Carpenter <[email protected]>
Acked-by: Samuel Ortiz <[email protected]>

Thanks.

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/