2011-12-29 17:21:36

by Ignacy Gawedzki

Subject: [PATCH] net/mac80211/sta_info.c: Fix crash in ieee80211_sta_expire.

Add missing brackets after applying ec2b774e7c91094d8c00de579646f1162b87b01e.
---
net/mac80211/sta_info.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/net/mac80211/sta_info.c b/net/mac80211/sta_info.c
index f0d3b48..1b085f7 100644
--- a/net/mac80211/sta_info.c
+++ b/net/mac80211/sta_info.c
@@ -945,7 +945,7 @@ void ieee80211_sta_expire(struct ieee80211_sub_if_data *sdata,
struct sta_info *sta, *tmp;

mutex_lock(&local->sta_mtx);
- list_for_each_entry_safe(sta, tmp, &local->sta_list, list)
+ list_for_each_entry_safe(sta, tmp, &local->sta_list, list) {
if (sdata != sta->sdata)
continue;

@@ -956,6 +956,7 @@ void ieee80211_sta_expire(struct ieee80211_sub_if_data *sdata,
#endif
WARN_ON(__sta_info_destroy(sta));
}
+ }
mutex_unlock(&local->sta_mtx);
}

--
1.7.5.4

2011-12-30 08:41:57

by Ignacy Gawedzki

Subject: Re: [PATCH] net/mac80211/sta_info.c: Fix crash in ieee80211_sta_expire.

On Fri, Dec 30, 2011 at 11:20:40AM +0530, thus spake Mohammed Shafi:
> Hi,
>
> On Thu, Dec 29, 2011 at 10:28 PM, Ignacy Gawedzki <[email protected]> wrote:
> > Add missing brackets after applying ec2b774e7c91094d8c00de579646f1162b87b01e.
>
>
> its already addressed by the patch
> http://comments.gmane.org/gmane.linux.kernel.wireless.general/83198

Ah, very well then. Sorry for the noise. =)

--
The groove will take you through times without money
much better than money will take you through times without groove.

2011-12-30 05:50:42

by Mohammed Shafi

Subject: Re: [PATCH] net/mac80211/sta_info.c: Fix crash in ieee80211_sta_expire.

Hi,

On Thu, Dec 29, 2011 at 10:28 PM, Ignacy Gawedzki <[email protected]> wrote:
> Add missing brackets after applying ec2b774e7c91094d8c00de579646f1162b87b01e.


its already addressed by the patch
http://comments.gmane.org/gmane.linux.kernel.wireless.general/83198

> ---
> ?net/mac80211/sta_info.c | ? ?3 ++-
> ?1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/net/mac80211/sta_info.c b/net/mac80211/sta_info.c
> index f0d3b48..1b085f7 100644
> --- a/net/mac80211/sta_info.c
> +++ b/net/mac80211/sta_info.c
> @@ -945,7 +945,7 @@ void ieee80211_sta_expire(struct ieee80211_sub_if_data *sdata,
> ? ? ? ?struct sta_info *sta, *tmp;
>
> ? ? ? ?mutex_lock(&local->sta_mtx);
> - ? ? ? list_for_each_entry_safe(sta, tmp, &local->sta_list, list)
> + ? ? ? list_for_each_entry_safe(sta, tmp, &local->sta_list, list) {
> ? ? ? ? ? ? ? ?if (sdata != sta->sdata)
> ? ? ? ? ? ? ? ? ? ? ? ?continue;
>
> @@ -956,6 +956,7 @@ void ieee80211_sta_expire(struct ieee80211_sub_if_data *sdata,
> ?#endif
> ? ? ? ? ? ? ? ? ? ? ? ?WARN_ON(__sta_info_destroy(sta));
> ? ? ? ? ? ? ? ?}
> + ? ? ? }
> ? ? ? ?mutex_unlock(&local->sta_mtx);
> ?}
>
> --
> 1.7.5.4
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to [email protected]
> More majordomo info at ?http://vger.kernel.org/majordomo-info.html



--
shafi