2012-01-26 06:14:09

by Dan Carpenter

Subject: [patch] nfc: NULL vs zero in nci_activate_target()

This is a pointer so it should be NULL instead of zero. Sparse
complains about this stuff:
net/nfc/nci/core.c:447:37: warning: Using plain integer as NULL pointer

Signed-off-by: Dan Carpenter <[email protected]>

diff --git a/net/nfc/nci/core.c b/net/nfc/nci/core.c
index 12d1d4d..a47e90c 100644
--- a/net/nfc/nci/core.c
+++ b/net/nfc/nci/core.c
@@ -444,7 +444,7 @@ static int nci_activate_target(struct nfc_dev *nfc_dev, __u32 target_idx,
{
struct nci_dev *ndev = nfc_get_drvdata(nfc_dev);
struct nci_rf_discover_select_param param;
- struct nfc_target *target = 0;
+ struct nfc_target *target = NULL;
int i;
int rc = 0;

2012-01-26 20:17:41

by Samuel Ortiz

Subject: Re: [patch] nfc: NULL vs zero in nci_activate_target()

Hi Dan,

On Thu, Jan 26, 2012 at 09:13:31AM +0300, Dan Carpenter wrote:
> This is a pointer so it should be NULL instead of zero. Sparse
> complains about this stuff:
> net/nfc/nci/core.c:447:37: warning: Using plain integer as NULL pointer
>
> Signed-off-by: Dan Carpenter <[email protected]>
Acked-by: Samuel Ortiz <[email protected]>

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/