2012-04-25 13:01:04

by Rajkumar Manoharan

Subject: [RFC] mac80211: fix rate control update on 2040 bss change

The rate control updatation never be called on 2040 BSS change.
The station should update its rate control on receiving beacon
with different HT mode in the HT operation IE. Not doing so,
leads to sending frames with higher(ht40) rates whereas AP is
running in lower mode (ht20).

Signed-off-by: Rajkumar Manoharan <[email protected]>
---
net/mac80211/mlme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
index c8836fa..56128d3 100644
--- a/net/mac80211/mlme.c
+++ b/net/mac80211/mlme.c
@@ -210,7 +210,7 @@ static u32 ieee80211_config_ht_tx(struct ieee80211_sub_if_data *sdata,
disable_40 = true;

if (sta && (!reconfig ||
- (disable_40 != !!(sta->sta.ht_cap.cap &
+ (disable_40 == !!(sta->sta.ht_cap.cap &
IEEE80211_HT_CAP_SUP_WIDTH_20_40)))) {

if (disable_40)
--
1.7.10

2012-04-25 14:43:14

by Rajkumar Manoharan

Subject: Re: [RFC] mac80211: fix rate control update on 2040 bss change

On Wed, Apr 25, 2012 at 04:08:17PM +0200, Arend van Spriel wrote:
> On 04/25/2012 03:01 PM, Rajkumar Manoharan wrote:
> >The rate control updatation never be called on 2040 BSS change.
>
> 'updatation' == typo?
>
yep. thanks
> >The station should update its rate control on receiving beacon
> >with different HT mode in the HT operation IE. Not doing so,
> >leads to sending frames with higher(ht40) rates whereas AP is
> >running in lower mode (ht20).
> >
> >Signed-off-by: Rajkumar Manoharan<[email protected]>
> >---
> > net/mac80211/mlme.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
> >index c8836fa..56128d3 100644
> >--- a/net/mac80211/mlme.c
> >+++ b/net/mac80211/mlme.c
> >@@ -210,7 +210,7 @@ static u32 ieee80211_config_ht_tx(struct ieee80211_sub_if_data *sdata,
> > disable_40 = true;
> >
> > if (sta&& (!reconfig ||
> >- (disable_40 != !!(sta->sta.ht_cap.cap&
> >+ (disable_40 == !!(sta->sta.ht_cap.cap&
> > IEEE80211_HT_CAP_SUP_WIDTH_20_40)))) {
> >
Jouni,

To make it more readable, will change as follows

+ (disable_40 != !(sta->sta.ht_cap.cap&

-Rajkumar

2012-04-25 14:08:34

by Arend van Spriel

Subject: Re: [RFC] mac80211: fix rate control update on 2040 bss change

On 04/25/2012 03:01 PM, Rajkumar Manoharan wrote:
> The rate control updatation never be called on 2040 BSS change.

'updatation' == typo?

> The station should update its rate control on receiving beacon
> with different HT mode in the HT operation IE. Not doing so,
> leads to sending frames with higher(ht40) rates whereas AP is
> running in lower mode (ht20).
>
> Signed-off-by: Rajkumar Manoharan<[email protected]>
> ---
> net/mac80211/mlme.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
> index c8836fa..56128d3 100644
> --- a/net/mac80211/mlme.c
> +++ b/net/mac80211/mlme.c
> @@ -210,7 +210,7 @@ static u32 ieee80211_config_ht_tx(struct ieee80211_sub_if_data *sdata,
> disable_40 = true;
>
> if (sta&& (!reconfig ||
> - (disable_40 != !!(sta->sta.ht_cap.cap&
> + (disable_40 == !!(sta->sta.ht_cap.cap&
> IEEE80211_HT_CAP_SUP_WIDTH_20_40)))) {
>
> if (disable_40)