2012-04-30 07:43:27

by joseph daniel

Subject: [PATCH] net/nfc: Fix the compilation warning

the nfc_llcp_general_bytes is defined in nfc/core.c as
static inline u8 *nfc_llcp_general_bytes(struct nfc_dev *dev, size_t *gb_len).

as in nfc/nfc.h:
static inline u8 *nfc_llcp_general_bytes(struct nfc_dev *dev, u8 *gb_len), as
CONFIG_NFC_LLCP is not defined.

so we got some warnings,
net/nfc/core.c:207:2: warning: passing argument 2 of ‘nfc_llcp_general_bytes’ from incompatible pointer type [enabled by default]
net/nfc/nfc.h:87:19: note: expected ‘u8 *’ but argument is of type ‘size_t *’

Signed-off-by: joseph daniel <[email protected]>
---
net/nfc/nfc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/nfc/nfc.h b/net/nfc/nfc.h
index ec8794c..549382c 100644
--- a/net/nfc/nfc.h
+++ b/net/nfc/nfc.h
@@ -84,7 +84,7 @@ static inline int nfc_llcp_set_remote_gb(struct nfc_dev *dev,
return 0;
}

-static inline u8 *nfc_llcp_general_bytes(struct nfc_dev *dev, u8 *gb_len)
+static inline u8 *nfc_llcp_general_bytes(struct nfc_dev *dev, size_t *gb_len)
{
*gb_len = 0;
return NULL;
--
1.7.9.5

2012-04-30 09:15:39

by Samuel Ortiz

Subject: Re: [PATCH] net/nfc: Fix the compilation warning

Hi Joseph,

On Mon, Apr 30, 2012 at 01:43:15PM +0600, joseph daniel wrote:
> the nfc_llcp_general_bytes is defined in nfc/core.c as
> static inline u8 *nfc_llcp_general_bytes(struct nfc_dev *dev, size_t *gb_len).
>
> as in nfc/nfc.h:
> static inline u8 *nfc_llcp_general_bytes(struct nfc_dev *dev, u8 *gb_len), as
> CONFIG_NFC_LLCP is not defined.
>
> so we got some warnings,
> net/nfc/core.c:207:2: warning: passing argument 2 of ‘nfc_llcp_general_bytes’ from incompatible pointer type [enabled by default]
> net/nfc/nfc.h:87:19: note: expected ‘u8 *’ but argument is of type ‘size_t *’
>
> Signed-off-by: joseph daniel <[email protected]>
Thanks, patch applied to my nfc-next branch.

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/