2012-04-22 18:28:37

by Antonio Quartulli

[permalink] [raw]
Subject: iwlwifi warn_slowpath with 3.*

Hello,

since linux-3.0 (I don't remember if it was the case even before), I'm getting
this output in dmesg:

[ 53.662990] ------------[ cut here ]------------
[ 53.663016] WARNING: at drivers/iommu/intel-iommu.c:2911
intel_unmap_page+0x14b/0x180()
[ 53.663047] Hardware name: Latitude E5420
[ 53.663066] Driver unmaps unmatched page at PFN ffd1a000
[ 53.663091] Modules linked in: usb_storage hid_cherry usbhid uvcvideo
videobuf2_core videodev v4l2_compat_ioctl32 videobuf2_vmalloc videobuf2_memops
iwlwifi mac80211 cfg80211 snd_hda_codec_hdmi snd_hda_codec_idt psmouse
snd_hda_intel snd_hda_codec snd_hwdep snd_pcm snd_timer snd soundcore
snd_page_alloc ehci_hcd usbcore usb_common
[ 53.663106] Pid: 1852, comm: ifconfig Tainted: G W 3.3.2-pf #1
[ 53.663107] Call Trace:
[ 53.663109] [<ffffffff8137dc00>] ? intel_unmap_page+0x70/0x180
[ 53.663113] [<ffffffff8103102b>] ? warn_slowpath_common+0x7b/0xc0
[ 53.663116] [<ffffffff81031125>] ? warn_slowpath_fmt+0x45/0x50
[ 53.663119] [<ffffffff814874e3>] ? _raw_spin_unlock_irqrestore+0x13/0x40
[ 53.663121] [<ffffffff8137dcdb>] ? intel_unmap_page+0x14b/0x180
[ 53.663127] [<ffffffffa015f32c>] ? iwl_trans_rxq_free_rx_bufs+0x4c/0xf0
[iwlwifi]
[ 53.663131] [<ffffffffa016079c>] ? iwl_trans_pcie_start_device+0x17c/0xdf0
[iwlwifi]
[ 53.663135] [<ffffffffa014dc3d>] ? iwl_load_ucode_wait_alive+0x2d/0x3a0
[iwlwifi]
[ 53.663138] [<ffffffff810579e9>] ? get_parent_ip+0x9/0x20
[ 53.663140] [<ffffffff810579e9>] ? get_parent_ip+0x9/0x20
[ 53.663142] [<ffffffff81057a87>] ? sub_preempt_count+0x87/0xb0
[ 53.663144] [<ffffffff814874e3>] ? _raw_spin_unlock_irqrestore+0x13/0x40
[ 53.663147] [<ffffffffa014c7ee>] ? iwlagn_mac_start+0x12e/0x1f0 [iwlwifi]
[ 53.663154] [<ffffffffa010fa66>] ? ieee80211_do_open+0x276/0x6a0 [mac80211]
[ 53.663158] [<ffffffffa010dd12>] ?
ieee80211_check_concurrent_iface+0x22/0x1a0 [mac80211]
[ 53.663162] [<ffffffff8139c3c6>] ? __dev_open+0x86/0xd0
[ 53.663164] [<ffffffff8139c63a>] ? __dev_change_flags+0x9a/0x180
[ 53.663166] [<ffffffff8139c7d0>] ? dev_change_flags+0x20/0x70
[ 53.663169] [<ffffffff813f7a8f>] ? devinet_ioctl+0x5bf/0x750
[ 53.663172] [<ffffffff81383289>] ? sock_do_ioctl+0x29/0x60
[ 53.663174] [<ffffffff81383323>] ? sock_ioctl+0x63/0x2b0
[ 53.663177] [<ffffffff8110773e>] ? do_vfs_ioctl+0x8e/0x4f0
[ 53.663179] [<ffffffff81107c38>] ? sys_ioctl+0x98/0xa0
[ 53.663181] [<ffffffff81488022>] ? system_call_fastpath+0x16/0x1b
[ 53.663183] ---[ end trace e93713a9d40cd06e ]---


I tried to dig a bit but I didn't really understand how this slowpath warning
should be interpreted. However the card seems to work fine. I'm experiencing
some kernel panic from time to time, but I cannot understand if it is really
realted to this issue or not.

I hope this output makes sense for someone.

Best regards,


--
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara


Attachments:
(No filename) (2.89 kB)
(No filename) (490.00 B)
Download all attachments

2012-04-30 17:17:48

by John W. Linville

[permalink] [raw]
Subject: Re: iwlwifi warn_slowpath with 3.*

On Mon, Apr 30, 2012 at 04:58:04PM +0200, Antonio Quartulli wrote:
> On Sun, Apr 22, 2012 at 08:29:29PM +0200, Antonio Quartulli wrote:
> > Hello,
> >
> > since linux-3.0 (I don't remember if it was the case even before), I'm getting
> > this output in dmesg:
> >
> > [ 53.662990] ------------[ cut here ]------------
> > [ 53.663016] WARNING: at drivers/iommu/intel-iommu.c:2911
> > intel_unmap_page+0x14b/0x180()
> > [ 53.663047] Hardware name: Latitude E5420
> > [ 53.663066] Driver unmaps unmatched page at PFN ffd1a000
>
>
> I see that I always get the same addr passed to the unmap function:
>
> [ 23.950535] Driver unmaps unmatched page at PFN ffd1a000
>
> is it a coincidence?
> I'm running linux-3.3.3 right now. I can try wireless-testing if it would help.

Just for the record, we are seeing a similar problem on RHEL 6.3
(which has an iwlwifi driver derived from linux-3.2).

https://bugzilla.redhat.com/show_bug.cgi?id=815998

John
--
John W. Linville Someday the world will need a hero, and you
[email protected] might be all we have. Be ready.

2012-04-30 20:12:11

by Emmanuel Grumbach

[permalink] [raw]
Subject: Re: iwlwifi warn_slowpath with 3.*

On Mon, Apr 30, 2012 at 20:03, John W. Linville <[email protected]> wrote:
> On Mon, Apr 30, 2012 at 04:58:04PM +0200, Antonio Quartulli wrote:
>> On Sun, Apr 22, 2012 at 08:29:29PM +0200, Antonio Quartulli wrote:
>> > Hello,
>> >
>> > since linux-3.0 (I don't remember if it was the case even before), I'm getting
>> > this output in dmesg:
>> >
>> > [ ? 53.662990] ------------[ cut here ]------------
>> > [ ? 53.663016] WARNING: at drivers/iommu/intel-iommu.c:2911
>> > intel_unmap_page+0x14b/0x180()
>> > [ ? 53.663047] Hardware name: Latitude E5420
>> > [ ? 53.663066] Driver unmaps unmatched page at PFN ffd1a000
>>
>>
>> I see that I always get the same addr passed to the unmap function:
>>
>> [ ? 23.950535] Driver unmaps unmatched page at PFN ffd1a000
>>
>> is it a coincidence?
>> I'm running linux-3.3.3 right now. I can try wireless-testing if it would help.
>
> Just for the record, we are seeing a similar problem on RHEL 6.3
> (which has an iwlwifi driver derived from linux-3.2).
>
> ? ? ? ?https://bugzilla.redhat.com/show_bug.cgi?id=815998
>

John I want to hope that this bugzilla would be solved by Johannes
rework of the locks:

08ae86ac3f9d9c9a60d2883c82cd72a5c66b94db in wireless-next.
There are a few patches that completely rewrite the locking model of the driver.

2012-04-30 20:13:19

by Emmanuel Grumbach

[permalink] [raw]
Subject: Re: iwlwifi warn_slowpath with 3.*

>>> > Hello,
>>> >
>>> > since linux-3.0 (I don't remember if it was the case even before), I'm getting
>>> > this output in dmesg:
>>> >
>>> > [ ? 53.662990] ------------[ cut here ]------------
>>> > [ ? 53.663016] WARNING: at drivers/iommu/intel-iommu.c:2911
>>> > intel_unmap_page+0x14b/0x180()
>>> > [ ? 53.663047] Hardware name: Latitude E5420
>>> > [ ? 53.663066] Driver unmaps unmatched page at PFN ffd1a000
>>>
>>>
>>> I see that I always get the same addr passed to the unmap function:
>>>
>>> [ ? 23.950535] Driver unmaps unmatched page at PFN ffd1a000
>>>
>>> is it a coincidence?
>>> I'm running linux-3.3.3 right now. I can try wireless-testing if it would help.
>>
>> Just for the record, we are seeing a similar problem on RHEL 6.3
>> (which has an iwlwifi driver derived from linux-3.2).
>>
>> ? ? ? ?https://bugzilla.redhat.com/show_bug.cgi?id=815998
>>
>
> John I want to hope that this bugzilla would be solved by Johannes
> rework of the locks:
>
> 08ae86ac3f9d9c9a60d2883c82cd72a5c66b94db in wireless-next.
> There are a few patches that completely rewrite the locking model of the driver.

Especially this one:

7b11488fbbbe06ada39a396dec16532db8c933e6

2012-04-30 14:57:02

by Antonio Quartulli

[permalink] [raw]
Subject: Re: iwlwifi warn_slowpath with 3.*

On Sun, Apr 22, 2012 at 08:29:29PM +0200, Antonio Quartulli wrote:
> Hello,
>
> since linux-3.0 (I don't remember if it was the case even before), I'm getting
> this output in dmesg:
>
> [ 53.662990] ------------[ cut here ]------------
> [ 53.663016] WARNING: at drivers/iommu/intel-iommu.c:2911
> intel_unmap_page+0x14b/0x180()
> [ 53.663047] Hardware name: Latitude E5420
> [ 53.663066] Driver unmaps unmatched page at PFN ffd1a000


I see that I always get the same addr passed to the unmap function:

[ 23.950535] Driver unmaps unmatched page at PFN ffd1a000

is it a coincidence?
I'm running linux-3.3.3 right now. I can try wireless-testing if it would help.

Cheers,


--
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara


Attachments:
(No filename) (772.00 B)
(No filename) (490.00 B)
Download all attachments

2012-05-04 05:11:55

by Emmanuel Grumbach

[permalink] [raw]
Subject: Re: iwlwifi warn_slowpath with 3.*

nothing attaced

Emmanuel Grumbach
[email protected]


On Fri, May 4, 2012 at 3:21 AM, Antonio Quartulli <[email protected]> wrote:
> mhmmm I attached dmesg again. Do you really need messages?
>
> Cheers,
>
>
> On Thu, May 03, 2012 at 11:17:14 +0300, Emmanuel Grumbach wrote:
>> ooops
>>
>>
>> here it is
>>
>>
>>
>> Emmanuel Grumbach
>> [email protected]
>>
>>
>> On Thu, May 3, 2012 at 11:09 PM, Antonio Quartulli <[email protected]> wrote:
>> > On Thu, May 03, 2012 at 10:55:12PM +0300, Emmanuel Grumbach wrote:
>> >> Hi
>> >>
>> >> can you please apply the patch attached against wireless-testing ?
>> >
>> > which patch? If you refer to the patch attached to the bugreport, it doesn't
>> > apply on wireless-testing.
>> >
>> >
>> > Cheers,
>> >
>> >>
>> >> You will have quite a lot of prints, so you will probably need to send
>> >> /var/log/syslog or messages
>> >>
>> >>
>> >> Thanks
>> >>
>> >> Emmanuel Grumbach
>> >> [email protected]
>> >>
>> >>
>> >> On Thu, May 3, 2012 at 10:04 PM, Emmanuel Grumbach <[email protected]> wrote:
>> >> > Please enable CONFIG_FRAME_POINTERS
>> >> > Emmanuel Grumbach
>> >> > [email protected]
>> >> >
>> >> >
>> >> > On Thu, May 3, 2012 at 9:53 AM, Antonio Quartulli <[email protected]> wrote:
>> >> >> On Wed, May 02, 2012 at 06:21:02PM +0200, Antonio Quartulli wrote:
>> >> >>> On Wed, May 02, 2012 at 11:39:14AM -0400, John W. Linville wrote:
>> >> >>> > On Wed, May 02, 2012 at 10:08:46AM +0300, Emmanuel Grumbach wrote:
>> >> >>> > > On Wed, May 2, 2012 at 12:19 AM, Venkataraman, Meenakshi
>> >> >>> > > <[email protected]> wrote:
>> >> >>> > > > Hi Antonio,
>> >> >>> > > >
>> >> >>> > > >>> it seems so. It happens at least once at boot time.
>> >> >>> > > >>> I will try wireless-testing and see what happens. Then I will apply your patch.
>> >> >>> > > >>
>> >> >>> > > >>The problem is there either with wireless-testing and with
>> >> >>> > > >>wireless-testing+your_patch.
>> >> >>> > > >>
>> >> >>> > > >>If it can somehow help, I also got several stack trace regarding intel_iova
>> >> >>> > > >>functions. But then the I got kernel panic and I was not able to copy the
>> >> >>> > > >>messages.
>> >> >>> > > >
>> >> >>> > > > [MV] Depending on how you set it up, perhaps the stack trace was saved in one of the syslog files in /var/log/...
>> >> >>> > > >
>> >> >>> > > > Thanks!
>> >> >>> > > > Meenakshi
>> >> >>> > > >
>> >> >>> > >
>> >> >>> > > Can you please re-run with debug=1 and send the whole log ?
>> >> >>> > > This will give a better indication on when the issue occurs.
>> >> >>> >
>> >> >>> > Does this help?
>> >> >>> >
>> >> >>> > ? ? https://bugzilla.redhat.com/show_bug.cgi?id=815998#c18
>> >> >>>
>> >> >>> I applied patch in comment 17 on linux-3.3.4. IT didn't help but this time I got
>> >> >>> the WARNING even with debug=1. Log is attached.
>> >> >>>
>> >> >>
>> >> >>
>> >> >> Is there any particular kernel debugging option I could enable to make the log
>> >> >> more verbose?
>> >> >>
>> >> >>
>> >> >> Cheers,
>> >> >>
>> >> >>
>> >> >>
>> >> >> --
>> >> >> Antonio Quartulli
>> >> >>
>> >> >> ..each of us alone is worth nothing..
>> >> >> Ernesto "Che" Guevara
>> >
>> > --
>> > Antonio Quartulli
>> >
>> > ..each of us alone is worth nothing..
>> > Ernesto "Che" Guevara
>
>
>
> --
> Antonio Quartulli
>
> ..each of us alone is worth nothing..
> Ernesto "Che" Guevara

2012-05-06 09:23:20

by Emmanuel Grumbach

[permalink] [raw]
Subject: Re: iwlwifi warn_slowpath with 3.*

On Sun, May 6, 2012 at 11:59 AM, Antonio Quartulli <[email protected]> wrote:
> On Sun, May 06, 2012 at 11:26:32 +0300, Emmanuel Grumbach wrote:
>> All right,
>>
>> Can you please test the patch I sent to you (which was good but not enough)
>> And add this one too ?
>
> What branch are these patches based on?
> I'm applying them onto wireless-testing, but I always messages like:
>
> patching file drivers/net/wireless/iwlwifi/iwl-debugfs.c
> Hunk #1 succeeded at 2211 (offset 1 line).
>

This is fine

> The patches apply anyway, but just to be sure I'm testing the correct branch
>
>
> Cheers,
>
>>
>> Thanks
>>
>> Emmanuel Grumbach
>> [email protected]
>>
>>
>> On Sun, May 6, 2012 at 10:54 AM, Antonio Quartulli <[email protected]> wrote:
>> > On Sun, May 06, 2012 at 08:49:52 +0300, Emmanuel Grumbach wrote:
>> >> wait - I just noticed that this one introduced another issue...
>> >
>> > ok, I'll drop this patch
>> >
>> >>
>> >> Emmanuel Grumbach
>> >> [email protected]
>> >>
>> >>
>> >> On Sat, May 5, 2012 at 9:49 PM, Emmanuel Grumbach <[email protected]> wrote:
>> >> > Well,
>> >> >
>> >> > this is not the same warning as before.
>> >> > Can you try the patch attached ?
>> >> > I have submitted it internally.
>> >> >
>> >> > thanks
>> >> >
>> >> > Emmanuel Grumbach
>> >> > [email protected]
>> >> >
>> >> >
>> >> > On Fri, May 4, 2012 at 5:20 PM, Antonio Quartulli <[email protected]> wrote:
>> >> >> On Fri, May 04, 2012 at 09:58:30 +0300, Emmanuel Grumbach wrote:
>> >> >>> This can't be with my patch, is it ?
>> >> >>
>> >> >> here is the log. Some pieces are missing at the beginning, didn't check why.
>> >> >> However the WARNING comes up later, so it should be ok. Tell me if I can do
>> >> >> something else!
>> >> >>
>> >> >> Cheers,
>> >> >>
>> >> >>
>> >> >> --
>> >> >> Antonio Quartulli
>> >> >>
>> >> >> ..each of us alone is worth nothing..
>> >> >> Ernesto "Che" Guevara
>> >
>> > --
>> > Antonio Quartulli
>> >
>> > ..each of us alone is worth nothing..
>> > Ernesto "Che" Guevara
>
>
>
> --
> Antonio Quartulli
>
> ..each of us alone is worth nothing..
> Ernesto "Che" Guevara

2012-05-04 00:20:54

by Antonio Quartulli

[permalink] [raw]
Subject: Re: iwlwifi warn_slowpath with 3.*

mhmmm I attached dmesg again. Do you really need messages?

Cheers,


On Thu, May 03, 2012 at 11:17:14 +0300, Emmanuel Grumbach wrote:
> ooops
>
>
> here it is
>
>
>
> Emmanuel Grumbach
> [email protected]
>
>
> On Thu, May 3, 2012 at 11:09 PM, Antonio Quartulli <[email protected]> wrote:
> > On Thu, May 03, 2012 at 10:55:12PM +0300, Emmanuel Grumbach wrote:
> >> Hi
> >>
> >> can you please apply the patch attached against wireless-testing ?
> >
> > which patch? If you refer to the patch attached to the bugreport, it doesn't
> > apply on wireless-testing.
> >
> >
> > Cheers,
> >
> >>
> >> You will have quite a lot of prints, so you will probably need to send
> >> /var/log/syslog or messages
> >>
> >>
> >> Thanks
> >>
> >> Emmanuel Grumbach
> >> [email protected]
> >>
> >>
> >> On Thu, May 3, 2012 at 10:04 PM, Emmanuel Grumbach <[email protected]> wrote:
> >> > Please enable CONFIG_FRAME_POINTERS
> >> > Emmanuel Grumbach
> >> > [email protected]
> >> >
> >> >
> >> > On Thu, May 3, 2012 at 9:53 AM, Antonio Quartulli <[email protected]> wrote:
> >> >> On Wed, May 02, 2012 at 06:21:02PM +0200, Antonio Quartulli wrote:
> >> >>> On Wed, May 02, 2012 at 11:39:14AM -0400, John W. Linville wrote:
> >> >>> > On Wed, May 02, 2012 at 10:08:46AM +0300, Emmanuel Grumbach wrote:
> >> >>> > > On Wed, May 2, 2012 at 12:19 AM, Venkataraman, Meenakshi
> >> >>> > > <[email protected]> wrote:
> >> >>> > > > Hi Antonio,
> >> >>> > > >
> >> >>> > > >>> it seems so. It happens at least once at boot time.
> >> >>> > > >>> I will try wireless-testing and see what happens. Then I will apply your patch.
> >> >>> > > >>
> >> >>> > > >>The problem is there either with wireless-testing and with
> >> >>> > > >>wireless-testing+your_patch.
> >> >>> > > >>
> >> >>> > > >>If it can somehow help, I also got several stack trace regarding intel_iova
> >> >>> > > >>functions. But then the I got kernel panic and I was not able to copy the
> >> >>> > > >>messages.
> >> >>> > > >
> >> >>> > > > [MV] Depending on how you set it up, perhaps the stack trace was saved in one of the syslog files in /var/log/...
> >> >>> > > >
> >> >>> > > > Thanks!
> >> >>> > > > Meenakshi
> >> >>> > > >
> >> >>> > >
> >> >>> > > Can you please re-run with debug=1 and send the whole log ?
> >> >>> > > This will give a better indication on when the issue occurs.
> >> >>> >
> >> >>> > Does this help?
> >> >>> >
> >> >>> >     https://bugzilla.redhat.com/show_bug.cgi?id=815998#c18
> >> >>>
> >> >>> I applied patch in comment 17 on linux-3.3.4. IT didn't help but this time I got
> >> >>> the WARNING even with debug=1. Log is attached.
> >> >>>
> >> >>
> >> >>
> >> >> Is there any particular kernel debugging option I could enable to make the log
> >> >> more verbose?
> >> >>
> >> >>
> >> >> Cheers,
> >> >>
> >> >>
> >> >>
> >> >> --
> >> >> Antonio Quartulli
> >> >>
> >> >> ..each of us alone is worth nothing..
> >> >> Ernesto "Che" Guevara
> >
> > --
> > Antonio Quartulli
> >
> > ..each of us alone is worth nothing..
> > Ernesto "Che" Guevara



--
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara


Attachments:
(No filename) (3.08 kB)
(No filename) (490.00 B)
Download all attachments

2012-05-06 08:56:44

by Antonio Quartulli

[permalink] [raw]
Subject: Re: iwlwifi warn_slowpath with 3.*

On Sun, May 06, 2012 at 11:26:32 +0300, Emmanuel Grumbach wrote:
> All right,
>
> Can you please test the patch I sent to you (which was good but not enough)
> And add this one too ?

Ok, I'll also leave the print.patch.
I'll report the result.

Thank you

>
> Thanks
>
> Emmanuel Grumbach
> [email protected]
>
>
> On Sun, May 6, 2012 at 10:54 AM, Antonio Quartulli <[email protected]> wrote:
> > On Sun, May 06, 2012 at 08:49:52 +0300, Emmanuel Grumbach wrote:
> >> wait - I just noticed that this one introduced another issue...
> >
> > ok, I'll drop this patch
> >
> >>
> >> Emmanuel Grumbach
> >> [email protected]
> >>
> >>
> >> On Sat, May 5, 2012 at 9:49 PM, Emmanuel Grumbach <[email protected]> wrote:
> >> > Well,
> >> >
> >> > this is not the same warning as before.
> >> > Can you try the patch attached ?
> >> > I have submitted it internally.
> >> >
> >> > thanks
> >> >
> >> > Emmanuel Grumbach
> >> > [email protected]
> >> >
> >> >
> >> > On Fri, May 4, 2012 at 5:20 PM, Antonio Quartulli <[email protected]> wrote:
> >> >> On Fri, May 04, 2012 at 09:58:30 +0300, Emmanuel Grumbach wrote:
> >> >>> This can't be with my patch, is it ?
> >> >>
> >> >> here is the log. Some pieces are missing at the beginning, didn't check why.
> >> >> However the WARNING comes up later, so it should be ok. Tell me if I can do
> >> >> something else!
> >> >>
> >> >> Cheers,
> >> >>
> >> >>
> >> >> --
> >> >> Antonio Quartulli
> >> >>
> >> >> ..each of us alone is worth nothing..
> >> >> Ernesto "Che" Guevara
> >
> > --
> > Antonio Quartulli
> >
> > ..each of us alone is worth nothing..
> > Ernesto "Che" Guevara



--
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara


Attachments:
(No filename) (1.68 kB)
(No filename) (490.00 B)
Download all attachments

2012-05-01 20:55:24

by Antonio Quartulli

[permalink] [raw]
Subject: Re: iwlwifi warn_slowpath with 3.*

On Tue, May 01, 2012 at 08:34:15PM +0200, Antonio Quartulli wrote:
> On Tue, May 01, 2012 at 08:13:46PM +0300, Emmanuel Grumbach wrote:
> > Hi,
> >
> > I am not sure the patch will help because the race is _very_ unlikely.
> > But I would be glad to know if you can reproduce on latest
> > compat-wireless.
> > How reproducible is that on 3.3.3 ? Is that 100% ?
>
> it seems so. It happens at least once at boot time.
> I will try wireless-testing and see what happens. Then I will apply your patch.

The problem is there either with wireless-testing and with
wireless-testing+your_patch.

If it can somehow help, I also got several stack trace regarding intel_iova
functions. But then the I got kernel panic and I was not able to copy the
messages.



Thanks

> >
> > I guess my machine doesn't have IOMMU, but honestly, I am not sure I
> > know how to check.
> >
> > On Tue, May 1, 2012 at 19:52, Venkataraman, Meenakshi
> > <[email protected]> wrote:
> > >
> > > Hi John, Antonio,
> > >
> > > Emmanuel found a race condition in rx buffer allocation/deallocation, and
> > > attached is a patch that fixes it.
> > >
> > > >> > since linux-3.0 (I don't remember if it was the case even before),
> > > >> > I'm getting this output in dmesg:
> > > >> >
> > > >> > [   53.662990] ------------[ cut here ]------------
> > > >> > [   53.663016] WARNING: at drivers/iommu/intel-iommu.c:2911
> > > >> > intel_unmap_page+0x14b/0x180()
> > > >> > [   53.663047] Hardware name: Latitude E5420
> > > >> > [   53.663066] Driver unmaps unmatched page at PFN ffd1a000
> > > >>
> > > >>
> > > >> I see that I always get the same addr passed to the unmap function:
> > > >>
> > > >> [   23.950535] Driver unmaps unmatched page at PFN ffd1a000
> > > >>
> > > >> is it a coincidence?
> > > >> I'm running linux-3.3.3 right now. I can try wireless-testing if it
> > > >> would help.
> > >
> > > [MV] Antonio -- can you try out the patch attached and let us know if you
> > > continue to see the problem?
> > >
> > > >Just for the record, we are seeing a similar problem on RHEL 6.3 (which
> > > > has an
> > > >iwlwifi driver derived from linux-3.2).
> > > >
> > > >       https://bugzilla.redhat.com/show_bug.cgi?id=815998
> > >
> > > [MV] John -- I'll update the redhat bugzilla as well.
> > >
> > > Thanks
> > > Meenakshi
>
> --
> Antonio Quartulli
>
> ..each of us alone is worth nothing..
> Ernesto "Che" Guevara



--
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara


Attachments:
(No filename) (2.46 kB)
(No filename) (490.00 B)
Download all attachments

2012-05-06 09:58:18

by Emmanuel Grumbach

[permalink] [raw]
Subject: Re: iwlwifi warn_slowpath with 3.*

>> >>> > Can you please test the patch I sent to you (which was good but not enough)
>> >>> > And add this one too ?
>> >>>
>> >>> Ok, I'll also leave the print.patch.
>> >>> I'll report the result.
>> >>>
>> >>
>> >> The WARNING is gone :)
>> >>
>> >> I attached the dmesg log anyway (debug was off, but there
>> >> are all the prints you introduced).
>> >>
>> >> To be sure, I also removed all the IWL_ERR you added and tried to reboot (in
>> >> order to see whether the printings were affecting synchronization).
>> >>
>> >
>> > Glad to hear.
>> >
>> > You can also remove everything. Reapply the second patch, and here is
>> > a new version of this patch after cleaning.
>>
>> I meant, reapply the first patch (the one that zeroes the TBs).
>
> Do you think thise patches should be backported for stable? Doesn't seem to be
> trivial..
>

Well.... it seems that they need to... I will see what to do. For this
kind of things, I have a maintainer :-)

2012-05-04 07:27:19

by Antonio Quartulli

[permalink] [raw]
Subject: Re: iwlwifi warn_slowpath with 3.*

On Fri, May 04, 2012 at 09:58:30AM +0300, Emmanuel Grumbach wrote:
> This can't be with my patch, is it ?

it should. I will give it another try, maybe yesterday night I messed up
something. Sorry.


Cheers,

>
> Emmanuel Grumbach
> [email protected]
>
>
> On Fri, May 4, 2012 at 9:36 AM, Antonio Quartulli <[email protected]> wrote:
> > ops... my fault
> >
> > On Fri, May 04, 2012 at 08:11:54 +0300, Emmanuel Grumbach wrote:
> >> nothing attaced
> >>
> >> Emmanuel Grumbach
> >> [email protected]
> >>
> >>
> >> On Fri, May 4, 2012 at 3:21 AM, Antonio Quartulli <[email protected]> wrote:
> >> > mhmmm I attached dmesg again. Do you really need messages?
> >> >
> >> > Cheers,
> >> >
> >> >
> >> > On Thu, May 03, 2012 at 11:17:14 +0300, Emmanuel Grumbach wrote:
> >> >> ooops
> >> >>
> >> >>
> >> >> here it is
> >> >>
> >> >>
> >> >>
> >> >> Emmanuel Grumbach
> >> >> [email protected]
> >> >>
> >> >>
> >> >> On Thu, May 3, 2012 at 11:09 PM, Antonio Quartulli <[email protected]> wrote:
> >> >> > On Thu, May 03, 2012 at 10:55:12PM +0300, Emmanuel Grumbach wrote:
> >> >> >> Hi
> >> >> >>
> >> >> >> can you please apply the patch attached against wireless-testing ?
> >> >> >
> >> >> > which patch? If you refer to the patch attached to the bugreport, it doesn't
> >> >> > apply on wireless-testing.
> >> >> >
> >> >> >
> >> >> > Cheers,
> >> >> >
> >> >> >>
> >> >> >> You will have quite a lot of prints, so you will probably need to send
> >> >> >> /var/log/syslog or messages
> >> >> >>
> >> >> >>
> >> >> >> Thanks
> >> >> >>
> >> >> >> Emmanuel Grumbach
> >> >> >> [email protected]
> >> >> >>
> >> >> >>
> >> >> >> On Thu, May 3, 2012 at 10:04 PM, Emmanuel Grumbach <[email protected]> wrote:
> >> >> >> > Please enable CONFIG_FRAME_POINTERS
> >> >> >> > Emmanuel Grumbach
> >> >> >> > [email protected]
> >> >> >> >
> >> >> >> >
> >> >> >> > On Thu, May 3, 2012 at 9:53 AM, Antonio Quartulli <[email protected]> wrote:
> >> >> >> >> On Wed, May 02, 2012 at 06:21:02PM +0200, Antonio Quartulli wrote:
> >> >> >> >>> On Wed, May 02, 2012 at 11:39:14AM -0400, John W. Linville wrote:
> >> >> >> >>> > On Wed, May 02, 2012 at 10:08:46AM +0300, Emmanuel Grumbach wrote:
> >> >> >> >>> > > On Wed, May 2, 2012 at 12:19 AM, Venkataraman, Meenakshi
> >> >> >> >>> > > <[email protected]> wrote:
> >> >> >> >>> > > > Hi Antonio,
> >> >> >> >>> > > >
> >> >> >> >>> > > >>> it seems so. It happens at least once at boot time.
> >> >> >> >>> > > >>> I will try wireless-testing and see what happens. Then I will apply your patch.
> >> >> >> >>> > > >>
> >> >> >> >>> > > >>The problem is there either with wireless-testing and with
> >> >> >> >>> > > >>wireless-testing+your_patch.
> >> >> >> >>> > > >>
> >> >> >> >>> > > >>If it can somehow help, I also got several stack trace regarding intel_iova
> >> >> >> >>> > > >>functions. But then the I got kernel panic and I was not able to copy the
> >> >> >> >>> > > >>messages.
> >> >> >> >>> > > >
> >> >> >> >>> > > > [MV] Depending on how you set it up, perhaps the stack trace was saved in one of the syslog files in /var/log/...
> >> >> >> >>> > > >
> >> >> >> >>> > > > Thanks!
> >> >> >> >>> > > > Meenakshi
> >> >> >> >>> > > >
> >> >> >> >>> > >
> >> >> >> >>> > > Can you please re-run with debug=1 and send the whole log ?
> >> >> >> >>> > > This will give a better indication on when the issue occurs.
> >> >> >> >>> >
> >> >> >> >>> > Does this help?
> >> >> >> >>> >
> >> >> >> >>> >     https://bugzilla.redhat.com/show_bug.cgi?id=815998#c18
> >> >> >> >>>
> >> >> >> >>> I applied patch in comment 17 on linux-3.3.4. IT didn't help but this time I got
> >> >> >> >>> the WARNING even with debug=1. Log is attached.
> >> >> >> >>>
> >> >> >> >>
> >> >> >> >>
> >> >> >> >> Is there any particular kernel debugging option I could enable to make the log
> >> >> >> >> more verbose?
> >> >> >> >>
> >> >> >> >>
> >> >> >> >> Cheers,
> >> >> >> >>
> >> >> >> >>
> >> >> >> >>
> >> >> >> >> --
> >> >> >> >> Antonio Quartulli
> >> >> >> >>
> >> >> >> >> ..each of us alone is worth nothing..
> >> >> >> >> Ernesto "Che" Guevara
> >> >> >
> >> >> > --
> >> >> > Antonio Quartulli
> >> >> >
> >> >> > ..each of us alone is worth nothing..
> >> >> > Ernesto "Che" Guevara
> >> >
> >> >
> >> >
> >> > --
> >> > Antonio Quartulli
> >> >
> >> > ..each of us alone is worth nothing..
> >> > Ernesto "Che" Guevara
> >> --
> >> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> >> the body of a message to [email protected]
> >> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >
> > --
> > Antonio Quartulli
> >
> > ..each of us alone is worth nothing..
> > Ernesto "Che" Guevara

--
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara


Attachments:
(No filename) (4.70 kB)
(No filename) (490.00 B)
Download all attachments

2012-05-06 07:54:27

by Antonio Quartulli

[permalink] [raw]
Subject: Re: iwlwifi warn_slowpath with 3.*

On Sun, May 06, 2012 at 08:49:52 +0300, Emmanuel Grumbach wrote:
> wait - I just noticed that this one introduced another issue...

ok, I'll drop this patch

>
> Emmanuel Grumbach
> [email protected]
>
>
> On Sat, May 5, 2012 at 9:49 PM, Emmanuel Grumbach <[email protected]> wrote:
> > Well,
> >
> > this is not the same warning as before.
> > Can you try the patch attached ?
> > I have submitted it internally.
> >
> > thanks
> >
> > Emmanuel Grumbach
> > [email protected]
> >
> >
> > On Fri, May 4, 2012 at 5:20 PM, Antonio Quartulli <[email protected]> wrote:
> >> On Fri, May 04, 2012 at 09:58:30 +0300, Emmanuel Grumbach wrote:
> >>> This can't be with my patch, is it ?
> >>
> >> here is the log. Some pieces are missing at the beginning, didn't check why.
> >> However the WARNING comes up later, so it should be ok. Tell me if I can do
> >> something else!
> >>
> >> Cheers,
> >>
> >>
> >> --
> >> Antonio Quartulli
> >>
> >> ..each of us alone is worth nothing..
> >> Ernesto "Che" Guevara

--
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara


Attachments:
(No filename) (1.07 kB)
(No filename) (490.00 B)
Download all attachments

2012-05-02 07:08:47

by Emmanuel Grumbach

[permalink] [raw]
Subject: Re: iwlwifi warn_slowpath with 3.*

On Wed, May 2, 2012 at 12:19 AM, Venkataraman, Meenakshi
<[email protected]> wrote:
> Hi Antonio,
>
>>> it seems so. It happens at least once at boot time.
>>> I will try wireless-testing and see what happens. Then I will apply your patch.
>>
>>The problem is there either with wireless-testing and with
>>wireless-testing+your_patch.
>>
>>If it can somehow help, I also got several stack trace regarding intel_iova
>>functions. But then the I got kernel panic and I was not able to copy the
>>messages.
>
> [MV] Depending on how you set it up, perhaps the stack trace was saved in one of the syslog files in /var/log/...
>
> Thanks!
> Meenakshi
>

Can you please re-run with debug=1 and send the whole log ?
This will give a better indication on when the issue occurs.
Thanks

2012-05-04 06:58:32

by Emmanuel Grumbach

[permalink] [raw]
Subject: Re: iwlwifi warn_slowpath with 3.*

This can't be with my patch, is it ?

Emmanuel Grumbach
[email protected]


On Fri, May 4, 2012 at 9:36 AM, Antonio Quartulli <[email protected]> wrote:
> ops... my fault
>
> On Fri, May 04, 2012 at 08:11:54 +0300, Emmanuel Grumbach wrote:
>> nothing attaced
>>
>> Emmanuel Grumbach
>> [email protected]
>>
>>
>> On Fri, May 4, 2012 at 3:21 AM, Antonio Quartulli <[email protected]> wrote:
>> > mhmmm I attached dmesg again. Do you really need messages?
>> >
>> > Cheers,
>> >
>> >
>> > On Thu, May 03, 2012 at 11:17:14 +0300, Emmanuel Grumbach wrote:
>> >> ooops
>> >>
>> >>
>> >> here it is
>> >>
>> >>
>> >>
>> >> Emmanuel Grumbach
>> >> [email protected]
>> >>
>> >>
>> >> On Thu, May 3, 2012 at 11:09 PM, Antonio Quartulli <[email protected]> wrote:
>> >> > On Thu, May 03, 2012 at 10:55:12PM +0300, Emmanuel Grumbach wrote:
>> >> >> Hi
>> >> >>
>> >> >> can you please apply the patch attached against wireless-testing ?
>> >> >
>> >> > which patch? If you refer to the patch attached to the bugreport, it doesn't
>> >> > apply on wireless-testing.
>> >> >
>> >> >
>> >> > Cheers,
>> >> >
>> >> >>
>> >> >> You will have quite a lot of prints, so you will probably need to send
>> >> >> /var/log/syslog or messages
>> >> >>
>> >> >>
>> >> >> Thanks
>> >> >>
>> >> >> Emmanuel Grumbach
>> >> >> [email protected]
>> >> >>
>> >> >>
>> >> >> On Thu, May 3, 2012 at 10:04 PM, Emmanuel Grumbach <[email protected]> wrote:
>> >> >> > Please enable CONFIG_FRAME_POINTERS
>> >> >> > Emmanuel Grumbach
>> >> >> > [email protected]
>> >> >> >
>> >> >> >
>> >> >> > On Thu, May 3, 2012 at 9:53 AM, Antonio Quartulli <[email protected]> wrote:
>> >> >> >> On Wed, May 02, 2012 at 06:21:02PM +0200, Antonio Quartulli wrote:
>> >> >> >>> On Wed, May 02, 2012 at 11:39:14AM -0400, John W. Linville wrote:
>> >> >> >>> > On Wed, May 02, 2012 at 10:08:46AM +0300, Emmanuel Grumbach wrote:
>> >> >> >>> > > On Wed, May 2, 2012 at 12:19 AM, Venkataraman, Meenakshi
>> >> >> >>> > > <[email protected]> wrote:
>> >> >> >>> > > > Hi Antonio,
>> >> >> >>> > > >
>> >> >> >>> > > >>> it seems so. It happens at least once at boot time.
>> >> >> >>> > > >>> I will try wireless-testing and see what happens. Then I will apply your patch.
>> >> >> >>> > > >>
>> >> >> >>> > > >>The problem is there either with wireless-testing and with
>> >> >> >>> > > >>wireless-testing+your_patch.
>> >> >> >>> > > >>
>> >> >> >>> > > >>If it can somehow help, I also got several stack trace regarding intel_iova
>> >> >> >>> > > >>functions. But then the I got kernel panic and I was not able to copy the
>> >> >> >>> > > >>messages.
>> >> >> >>> > > >
>> >> >> >>> > > > [MV] Depending on how you set it up, perhaps the stack trace was saved in one of the syslog files in /var/log/...
>> >> >> >>> > > >
>> >> >> >>> > > > Thanks!
>> >> >> >>> > > > Meenakshi
>> >> >> >>> > > >
>> >> >> >>> > >
>> >> >> >>> > > Can you please re-run with debug=1 and send the whole log ?
>> >> >> >>> > > This will give a better indication on when the issue occurs.
>> >> >> >>> >
>> >> >> >>> > Does this help?
>> >> >> >>> >
>> >> >> >>> > ? ? https://bugzilla.redhat.com/show_bug.cgi?id=815998#c18
>> >> >> >>>
>> >> >> >>> I applied patch in comment 17 on linux-3.3.4. IT didn't help but this time I got
>> >> >> >>> the WARNING even with debug=1. Log is attached.
>> >> >> >>>
>> >> >> >>
>> >> >> >>
>> >> >> >> Is there any particular kernel debugging option I could enable to make the log
>> >> >> >> more verbose?
>> >> >> >>
>> >> >> >>
>> >> >> >> Cheers,
>> >> >> >>
>> >> >> >>
>> >> >> >>
>> >> >> >> --
>> >> >> >> Antonio Quartulli
>> >> >> >>
>> >> >> >> ..each of us alone is worth nothing..
>> >> >> >> Ernesto "Che" Guevara
>> >> >
>> >> > --
>> >> > Antonio Quartulli
>> >> >
>> >> > ..each of us alone is worth nothing..
>> >> > Ernesto "Che" Guevara
>> >
>> >
>> >
>> > --
>> > Antonio Quartulli
>> >
>> > ..each of us alone is worth nothing..
>> > Ernesto "Che" Guevara
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
>> the body of a message to [email protected]
>> More majordomo info at ?http://vger.kernel.org/majordomo-info.html
>
> --
> Antonio Quartulli
>
> ..each of us alone is worth nothing..
> Ernesto "Che" Guevara

2012-05-02 15:30:59

by Antonio Quartulli

[permalink] [raw]
Subject: Re: iwlwifi warn_slowpath with 3.*

On Wed, May 02, 2012 at 10:08:46AM +0300, Emmanuel Grumbach wrote:
> On Wed, May 2, 2012 at 12:19 AM, Venkataraman, Meenakshi
> <[email protected]> wrote:
> > Hi Antonio,
> >
> >>> it seems so. It happens at least once at boot time.
> >>> I will try wireless-testing and see what happens. Then I will apply your patch.
> >>
> >>The problem is there either with wireless-testing and with
> >>wireless-testing+your_patch.
> >>
> >>If it can somehow help, I also got several stack trace regarding intel_iova
> >>functions. But then the I got kernel panic and I was not able to copy the
> >>messages.
> >
> > [MV] Depending on how you set it up, perhaps the stack trace was saved in one of the syslog files in /var/log/...
> >
> > Thanks!
> > Meenakshi
> >
>
> Can you please re-run with debug=1 and send the whole log ?
> This will give a better indication on when the issue occurs.

I tried but I haven't seen the WARNING anymore...it smell like a race condition
(at least this is what is usually "fixed" by printings :-D).

I also retried to insert the module without the debug option but I didn't get
the error anyway. This means that I get the error only at boot.

I will try to make more tests and eventually report what I see/understand.

Thank you for the work done so far!


Cheers,

--
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara


Attachments:
(No filename) (1.36 kB)
(No filename) (490.00 B)
Download all attachments

2012-05-01 17:13:47

by Emmanuel Grumbach

[permalink] [raw]
Subject: Re: iwlwifi warn_slowpath with 3.*

Hi,

I am not sure the patch will help because the race is _very_ unlikely.
But I would be glad to know if you can reproduce on latest
compat-wireless.
How reproducible is that on 3.3.3 ? Is that 100% ?

I guess my machine doesn't have IOMMU, but honestly, I am not sure I
know how to check.

On Tue, May 1, 2012 at 19:52, Venkataraman, Meenakshi
<[email protected]> wrote:
>
> Hi John, Antonio,
>
> Emmanuel found a race condition in rx buffer allocation/deallocation, and
> attached is a patch that fixes it.
>
> >> > since linux-3.0 (I don't remember if it was the case even before),
> >> > I'm getting this output in dmesg:
> >> >
> >> > [ ? 53.662990] ------------[ cut here ]------------
> >> > [ ? 53.663016] WARNING: at drivers/iommu/intel-iommu.c:2911
> >> > intel_unmap_page+0x14b/0x180()
> >> > [ ? 53.663047] Hardware name: Latitude E5420
> >> > [ ? 53.663066] Driver unmaps unmatched page at PFN ffd1a000
> >>
> >>
> >> I see that I always get the same addr passed to the unmap function:
> >>
> >> [ ? 23.950535] Driver unmaps unmatched page at PFN ffd1a000
> >>
> >> is it a coincidence?
> >> I'm running linux-3.3.3 right now. I can try wireless-testing if it
> >> would help.
>
> [MV] Antonio -- can you try out the patch attached and let us know if you
> continue to see the problem?
>
> >Just for the record, we are seeing a similar problem on RHEL 6.3 (which
> > has an
> >iwlwifi driver derived from linux-3.2).
> >
> > ? ? ? https://bugzilla.redhat.com/show_bug.cgi?id=815998
>
> [MV] John -- I'll update the redhat bugzilla as well.
>
> Thanks
> Meenakshi

2012-05-03 20:17:19

by Emmanuel Grumbach

[permalink] [raw]
Subject: Re: iwlwifi warn_slowpath with 3.*

ooops


here it is



Emmanuel Grumbach
[email protected]


On Thu, May 3, 2012 at 11:09 PM, Antonio Quartulli <[email protected]> wrote:
> On Thu, May 03, 2012 at 10:55:12PM +0300, Emmanuel Grumbach wrote:
>> Hi
>>
>> can you please apply the patch attached against wireless-testing ?
>
> which patch? If you refer to the patch attached to the bugreport, it doesn't
> apply on wireless-testing.
>
>
> Cheers,
>
>>
>> You will have quite a lot of prints, so you will probably need to send
>> /var/log/syslog or messages
>>
>>
>> Thanks
>>
>> Emmanuel Grumbach
>> [email protected]
>>
>>
>> On Thu, May 3, 2012 at 10:04 PM, Emmanuel Grumbach <[email protected]> wrote:
>> > Please enable CONFIG_FRAME_POINTERS
>> > Emmanuel Grumbach
>> > [email protected]
>> >
>> >
>> > On Thu, May 3, 2012 at 9:53 AM, Antonio Quartulli <[email protected]> wrote:
>> >> On Wed, May 02, 2012 at 06:21:02PM +0200, Antonio Quartulli wrote:
>> >>> On Wed, May 02, 2012 at 11:39:14AM -0400, John W. Linville wrote:
>> >>> > On Wed, May 02, 2012 at 10:08:46AM +0300, Emmanuel Grumbach wrote:
>> >>> > > On Wed, May 2, 2012 at 12:19 AM, Venkataraman, Meenakshi
>> >>> > > <[email protected]> wrote:
>> >>> > > > Hi Antonio,
>> >>> > > >
>> >>> > > >>> it seems so. It happens at least once at boot time.
>> >>> > > >>> I will try wireless-testing and see what happens. Then I will apply your patch.
>> >>> > > >>
>> >>> > > >>The problem is there either with wireless-testing and with
>> >>> > > >>wireless-testing+your_patch.
>> >>> > > >>
>> >>> > > >>If it can somehow help, I also got several stack trace regarding intel_iova
>> >>> > > >>functions. But then the I got kernel panic and I was not able to copy the
>> >>> > > >>messages.
>> >>> > > >
>> >>> > > > [MV] Depending on how you set it up, perhaps the stack trace was saved in one of the syslog files in /var/log/...
>> >>> > > >
>> >>> > > > Thanks!
>> >>> > > > Meenakshi
>> >>> > > >
>> >>> > >
>> >>> > > Can you please re-run with debug=1 and send the whole log ?
>> >>> > > This will give a better indication on when the issue occurs.
>> >>> >
>> >>> > Does this help?
>> >>> >
>> >>> > ? ? https://bugzilla.redhat.com/show_bug.cgi?id=815998#c18
>> >>>
>> >>> I applied patch in comment 17 on linux-3.3.4. IT didn't help but this time I got
>> >>> the WARNING even with debug=1. Log is attached.
>> >>>
>> >>
>> >>
>> >> Is there any particular kernel debugging option I could enable to make the log
>> >> more verbose?
>> >>
>> >>
>> >> Cheers,
>> >>
>> >>
>> >>
>> >> --
>> >> Antonio Quartulli
>> >>
>> >> ..each of us alone is worth nothing..
>> >> Ernesto "Che" Guevara
>
> --
> Antonio Quartulli
>
> ..each of us alone is worth nothing..
> Ernesto "Che" Guevara


Attachments:
print.patch (1.61 kB)

2012-05-02 16:21:39

by Antonio Quartulli

[permalink] [raw]
Subject: Re: iwlwifi warn_slowpath with 3.*

On Wed, May 02, 2012 at 11:39:14AM -0400, John W. Linville wrote:
> On Wed, May 02, 2012 at 10:08:46AM +0300, Emmanuel Grumbach wrote:
> > On Wed, May 2, 2012 at 12:19 AM, Venkataraman, Meenakshi
> > <[email protected]> wrote:
> > > Hi Antonio,
> > >
> > >>> it seems so. It happens at least once at boot time.
> > >>> I will try wireless-testing and see what happens. Then I will apply your patch.
> > >>
> > >>The problem is there either with wireless-testing and with
> > >>wireless-testing+your_patch.
> > >>
> > >>If it can somehow help, I also got several stack trace regarding intel_iova
> > >>functions. But then the I got kernel panic and I was not able to copy the
> > >>messages.
> > >
> > > [MV] Depending on how you set it up, perhaps the stack trace was saved in one of the syslog files in /var/log/...
> > >
> > > Thanks!
> > > Meenakshi
> > >
> >
> > Can you please re-run with debug=1 and send the whole log ?
> > This will give a better indication on when the issue occurs.
>
> Does this help?
>
> https://bugzilla.redhat.com/show_bug.cgi?id=815998#c18

I applied patch in comment 17 on linux-3.3.4. IT didn't help but this time I got
the WARNING even with debug=1. Log is attached.


Cheers,

--
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara


Attachments:
(No filename) (0.00 B)
(No filename) (490.00 B)
Download all attachments

2012-05-06 09:26:40

by Emmanuel Grumbach

[permalink] [raw]
Subject: Re: iwlwifi warn_slowpath with 3.*

>>> >
>>> > Can you please test the patch I sent to you (which was good but not enough)
>>> > And add this one too ?
>>>
>>> Ok, I'll also leave the print.patch.
>>> I'll report the result.
>>>
>>
>> The WARNING is gone :)
>>
>> I attached the dmesg log anyway (debug was off, but there
>> are all the prints you introduced).
>>
>> To be sure, I also removed all the IWL_ERR you added and tried to reboot (in
>> order to see whether the printings were affecting synchronization).
>>
>
> Glad to hear.
>
> You can also remove everything. Reapply the second patch, and here is
> a new version of this patch after cleaning.

I meant, reapply the first patch (the one that zeroes the TBs).

2012-05-04 14:19:28

by Antonio Quartulli

[permalink] [raw]
Subject: Re: iwlwifi warn_slowpath with 3.*

On Fri, May 04, 2012 at 09:58:30 +0300, Emmanuel Grumbach wrote:
> This can't be with my patch, is it ?

here is the log. Some pieces are missing at the beginning, didn't check why.
However the WARNING comes up later, so it should be ok. Tell me if I can do
something else!

Cheers,


--
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara


Attachments:
(No filename) (0.00 B)
(No filename) (490.00 B)
Download all attachments

2012-05-01 19:01:35

by Antonio Quartulli

[permalink] [raw]
Subject: Re: iwlwifi warn_slowpath with 3.*

On Tue, May 01, 2012 at 08:13:46PM +0300, Emmanuel Grumbach wrote:
> Hi,
>
> I am not sure the patch will help because the race is _very_ unlikely.
> But I would be glad to know if you can reproduce on latest
> compat-wireless.
> How reproducible is that on 3.3.3 ? Is that 100% ?

it seems so. It happens at least once at boot time.
I will try wireless-testing and see what happens. Then I will apply your patch.

Thanks a lot!

>
> I guess my machine doesn't have IOMMU, but honestly, I am not sure I
> know how to check.
>
> On Tue, May 1, 2012 at 19:52, Venkataraman, Meenakshi
> <[email protected]> wrote:
> >
> > Hi John, Antonio,
> >
> > Emmanuel found a race condition in rx buffer allocation/deallocation, and
> > attached is a patch that fixes it.
> >
> > >> > since linux-3.0 (I don't remember if it was the case even before),
> > >> > I'm getting this output in dmesg:
> > >> >
> > >> > [   53.662990] ------------[ cut here ]------------
> > >> > [   53.663016] WARNING: at drivers/iommu/intel-iommu.c:2911
> > >> > intel_unmap_page+0x14b/0x180()
> > >> > [   53.663047] Hardware name: Latitude E5420
> > >> > [   53.663066] Driver unmaps unmatched page at PFN ffd1a000
> > >>
> > >>
> > >> I see that I always get the same addr passed to the unmap function:
> > >>
> > >> [   23.950535] Driver unmaps unmatched page at PFN ffd1a000
> > >>
> > >> is it a coincidence?
> > >> I'm running linux-3.3.3 right now. I can try wireless-testing if it
> > >> would help.
> >
> > [MV] Antonio -- can you try out the patch attached and let us know if you
> > continue to see the problem?
> >
> > >Just for the record, we are seeing a similar problem on RHEL 6.3 (which
> > > has an
> > >iwlwifi driver derived from linux-3.2).
> > >
> > >       https://bugzilla.redhat.com/show_bug.cgi?id=815998
> >
> > [MV] John -- I'll update the redhat bugzilla as well.
> >
> > Thanks
> > Meenakshi

--
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara


Attachments:
(No filename) (1.95 kB)
(No filename) (490.00 B)
Download all attachments

2012-05-02 16:11:38

by Antonio Quartulli

[permalink] [raw]
Subject: Re: iwlwifi warn_slowpath with 3.*

On Wed, May 02, 2012 at 11:39:14AM -0400, John W. Linville wrote:
> On Wed, May 02, 2012 at 10:08:46AM +0300, Emmanuel Grumbach wrote:
> > On Wed, May 2, 2012 at 12:19 AM, Venkataraman, Meenakshi
> > <[email protected]> wrote:
> > > Hi Antonio,
> > >
> > >>> it seems so. It happens at least once at boot time.
> > >>> I will try wireless-testing and see what happens. Then I will apply your patch.
> > >>
> > >>The problem is there either with wireless-testing and with
> > >>wireless-testing+your_patch.
> > >>
> > >>If it can somehow help, I also got several stack trace regarding intel_iova
> > >>functions. But then the I got kernel panic and I was not able to copy the
> > >>messages.
> > >
> > > [MV] Depending on how you set it up, perhaps the stack trace was saved in one of the syslog files in /var/log/...
> > >
> > > Thanks!
> > > Meenakshi
> > >
> >
> > Can you please re-run with debug=1 and send the whole log ?
> > This will give a better indication on when the issue occurs.
>
> Does this help?
>
> https://bugzilla.redhat.com/show_bug.cgi?id=815998#c18

Hello John,

the patch you provided in comment 17 is not applying on top of
wireless-testing..

Applying: iwlwifi: give PCIe its own lock
error: patch failed: drivers/net/wireless/iwlwifi/iwl-trans-pcie-int.h:226
error: drivers/net/wireless/iwlwifi/iwl-trans-pcie-int.h: patch does not apply
error: patch failed: drivers/net/wireless/iwlwifi/iwl-trans-pcie-rx.c:329
error: drivers/net/wireless/iwlwifi/iwl-trans-pcie-rx.c: patch does not apply
error: patch failed: drivers/net/wireless/iwlwifi/iwl-trans-pcie-tx.c:477
error: drivers/net/wireless/iwlwifi/iwl-trans-pcie-tx.c: patch does not apply
error: patch failed: drivers/net/wireless/iwlwifi/iwl-trans-pcie.c:217
error: drivers/net/wireless/iwlwifi/iwl-trans-pcie.c: patch does not apply
Patch failed at 0001 iwlwifi: give PCIe its own lock


Cheers,

>
> John
> --
> John W. Linville Someday the world will need a hero, and you
> [email protected] might be all we have. Be ready.

--
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara


Attachments:
(No filename) (2.07 kB)
(No filename) (490.00 B)
Download all attachments

2012-05-01 16:53:02

by Venkataraman, Meenakshi

[permalink] [raw]
Subject: RE: iwlwifi warn_slowpath with 3.*

Hi John, Antonio,

Emmanuel found a race condition in rx buffer allocation/deallocation, and attached is a patch that fixes it.

>> > since linux-3.0 (I don't remember if it was the case even before),
>> > I'm getting this output in dmesg:
>> >
>> > [ 53.662990] ------------[ cut here ]------------
>> > [ 53.663016] WARNING: at drivers/iommu/intel-iommu.c:2911
>> > intel_unmap_page+0x14b/0x180()
>> > [ 53.663047] Hardware name: Latitude E5420
>> > [ 53.663066] Driver unmaps unmatched page at PFN ffd1a000
>>
>>
>> I see that I always get the same addr passed to the unmap function:
>>
>> [ 23.950535] Driver unmaps unmatched page at PFN ffd1a000
>>
>> is it a coincidence?
>> I'm running linux-3.3.3 right now. I can try wireless-testing if it would help.

[MV] Antonio -- can you try out the patch attached and let us know if you continue to see the problem?

>Just for the record, we are seeing a similar problem on RHEL 6.3 (which has an
>iwlwifi driver derived from linux-3.2).
>
> https://bugzilla.redhat.com/show_bug.cgi?id=815998

[MV] John -- I'll update the redhat bugzilla as well.

Thanks
Meenakshi


Attachments:
0001-iwlwifi-fix-a-potential-race-in-receive-buffer-alloc.patch (1.57 kB)
0001-iwlwifi-fix-a-potential-race-in-receive-buffer-alloc.patch

2012-05-01 19:01:36

by Antonio Quartulli

[permalink] [raw]
Subject: Re: iwlwifi warn_slowpath with 3.*

On Tue, May 01, 2012 at 04:52:23PM +0000, Venkataraman, Meenakshi wrote:
> Hi John, Antonio,
>
> Emmanuel found a race condition in rx buffer allocation/deallocation, and attached is a patch that fixes it.
>
> >> > since linux-3.0 (I don't remember if it was the case even before),
> >> > I'm getting this output in dmesg:
> >> >
> >> > [ 53.662990] ------------[ cut here ]------------
> >> > [ 53.663016] WARNING: at drivers/iommu/intel-iommu.c:2911
> >> > intel_unmap_page+0x14b/0x180()
> >> > [ 53.663047] Hardware name: Latitude E5420
> >> > [ 53.663066] Driver unmaps unmatched page at PFN ffd1a000
> >>
> >>
> >> I see that I always get the same addr passed to the unmap function:
> >>
> >> [ 23.950535] Driver unmaps unmatched page at PFN ffd1a000
> >>
> >> is it a coincidence?
> >> I'm running linux-3.3.3 right now. I can try wireless-testing if it would help.
>
> [MV] Antonio -- can you try out the patch attached and let us know if you continue to see the problem?

Ok, I will first try with a plain wireless-testing kernel and then I will apply
the patch.

Thanks!



--
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara


Attachments:
(No filename) (1.15 kB)
(No filename) (490.00 B)
Download all attachments

2012-05-01 21:20:11

by Venkataraman, Meenakshi

[permalink] [raw]
Subject: RE: iwlwifi warn_slowpath with 3.*

SGkgQW50b25pbywNCg0KPj4gaXQgc2VlbXMgc28uIEl0IGhhcHBlbnMgYXQgbGVhc3Qgb25jZSBh
dCBib290IHRpbWUuDQo+PiBJIHdpbGwgdHJ5IHdpcmVsZXNzLXRlc3RpbmcgYW5kIHNlZSB3aGF0
IGhhcHBlbnMuIFRoZW4gSSB3aWxsIGFwcGx5IHlvdXIgcGF0Y2guDQo+DQo+VGhlIHByb2JsZW0g
aXMgdGhlcmUgZWl0aGVyIHdpdGggd2lyZWxlc3MtdGVzdGluZyBhbmQgd2l0aA0KPndpcmVsZXNz
LXRlc3RpbmcreW91cl9wYXRjaC4NCj4NCj5JZiBpdCBjYW4gc29tZWhvdyBoZWxwLCBJIGFsc28g
Z290IHNldmVyYWwgc3RhY2sgdHJhY2UgcmVnYXJkaW5nIGludGVsX2lvdmENCj5mdW5jdGlvbnMu
IEJ1dCB0aGVuIHRoZSBJIGdvdCBrZXJuZWwgcGFuaWMgYW5kIEkgd2FzIG5vdCBhYmxlIHRvIGNv
cHkgdGhlDQo+bWVzc2FnZXMuDQoNCltNVl0gRGVwZW5kaW5nIG9uIGhvdyB5b3Ugc2V0IGl0IHVw
LCBwZXJoYXBzIHRoZSBzdGFjayB0cmFjZSB3YXMgc2F2ZWQgaW4gb25lIG9mIHRoZSBzeXNsb2cg
ZmlsZXMgaW4gL3Zhci9sb2cvLi4uDQoNClRoYW5rcyENCk1lZW5ha3NoaQ0KDQo=

2012-05-06 09:57:11

by Antonio Quartulli

[permalink] [raw]
Subject: Re: iwlwifi warn_slowpath with 3.*

On Sun, May 06, 2012 at 12:26:38PM +0300, Emmanuel Grumbach wrote:
> >>> >
> >>> > Can you please test the patch I sent to you (which was good but not enough)
> >>> > And add this one too ?
> >>>
> >>> Ok, I'll also leave the print.patch.
> >>> I'll report the result.
> >>>
> >>
> >> The WARNING is gone :)
> >>
> >> I attached the dmesg log anyway (debug was off, but there
> >> are all the prints you introduced).
> >>
> >> To be sure, I also removed all the IWL_ERR you added and tried to reboot (in
> >> order to see whether the printings were affecting synchronization).
> >>
> >
> > Glad to hear.
> >
> > You can also remove everything. Reapply the second patch, and here is
> > a new version of this patch after cleaning.
>
> I meant, reapply the first patch (the one that zeroes the TBs).

Do you think thise patches should be backported for stable? Doesn't seem to be
trivial..

> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html

--
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara


Attachments:
(No filename) (1.15 kB)
(No filename) (490.00 B)
Download all attachments

2012-05-06 09:25:52

by Emmanuel Grumbach

[permalink] [raw]
Subject: Re: iwlwifi warn_slowpath with 3.*

On Sun, May 6, 2012 at 12:15 PM, Antonio Quartulli <[email protected]> wrote:
> On Sun, May 06, 2012 at 10:56:38AM +0200, Antonio Quartulli wrote:
>> On Sun, May 06, 2012 at 11:26:32 +0300, Emmanuel Grumbach wrote:
>> > All right,
>> >
>> > Can you please test the patch I sent to you (which was good but not enough)
>> > And add this one too ?
>>
>> Ok, I'll also leave the print.patch.
>> I'll report the result.
>>
>
> The WARNING is gone :)
>
> I attached the dmesg log anyway (debug was off, but there
> are all the prints you introduced).
>
> To be sure, I also removed all the IWL_ERR you added and tried to reboot (in
> order to see whether the printings were affecting synchronization).
>

Glad to hear.

You can also remove everything. Reapply the second patch, and here is
a new version of this patch after cleaning.


Attachments:
0001-iwlwifi-fix-the-TFD-rings.patch (4.69 kB)

2012-05-03 19:55:13

by Emmanuel Grumbach

[permalink] [raw]
Subject: Re: iwlwifi warn_slowpath with 3.*

Hi

can you please apply the patch attached against wireless-testing ?

You will have quite a lot of prints, so you will probably need to send
/var/log/syslog or messages


Thanks

Emmanuel Grumbach
[email protected]


On Thu, May 3, 2012 at 10:04 PM, Emmanuel Grumbach <[email protected]> wrote:
> Please enable CONFIG_FRAME_POINTERS
> Emmanuel Grumbach
> [email protected]
>
>
> On Thu, May 3, 2012 at 9:53 AM, Antonio Quartulli <[email protected]> wrote:
>> On Wed, May 02, 2012 at 06:21:02PM +0200, Antonio Quartulli wrote:
>>> On Wed, May 02, 2012 at 11:39:14AM -0400, John W. Linville wrote:
>>> > On Wed, May 02, 2012 at 10:08:46AM +0300, Emmanuel Grumbach wrote:
>>> > > On Wed, May 2, 2012 at 12:19 AM, Venkataraman, Meenakshi
>>> > > <[email protected]> wrote:
>>> > > > Hi Antonio,
>>> > > >
>>> > > >>> it seems so. It happens at least once at boot time.
>>> > > >>> I will try wireless-testing and see what happens. Then I will apply your patch.
>>> > > >>
>>> > > >>The problem is there either with wireless-testing and with
>>> > > >>wireless-testing+your_patch.
>>> > > >>
>>> > > >>If it can somehow help, I also got several stack trace regarding intel_iova
>>> > > >>functions. But then the I got kernel panic and I was not able to copy the
>>> > > >>messages.
>>> > > >
>>> > > > [MV] Depending on how you set it up, perhaps the stack trace was saved in one of the syslog files in /var/log/...
>>> > > >
>>> > > > Thanks!
>>> > > > Meenakshi
>>> > > >
>>> > >
>>> > > Can you please re-run with debug=1 and send the whole log ?
>>> > > This will give a better indication on when the issue occurs.
>>> >
>>> > Does this help?
>>> >
>>> > ? ? https://bugzilla.redhat.com/show_bug.cgi?id=815998#c18
>>>
>>> I applied patch in comment 17 on linux-3.3.4. IT didn't help but this time I got
>>> the WARNING even with debug=1. Log is attached.
>>>
>>
>>
>> Is there any particular kernel debugging option I could enable to make the log
>> more verbose?
>>
>>
>> Cheers,
>>
>>
>>
>> --
>> Antonio Quartulli
>>
>> ..each of us alone is worth nothing..
>> Ernesto "Che" Guevara

2012-05-06 09:40:49

by Antonio Quartulli

[permalink] [raw]
Subject: Re: iwlwifi warn_slowpath with 3.*

On Sun, May 06, 2012 at 12:26:38PM +0300, Emmanuel Grumbach wrote:
> >>> >
> >>> > Can you please test the patch I sent to you (which was good but not enough)
> >>> > And add this one too ?
> >>>
> >>> Ok, I'll also leave the print.patch.
> >>> I'll report the result.
> >>>
> >>
> >> The WARNING is gone :)
> >>
> >> I attached the dmesg log anyway (debug was off, but there
> >> are all the prints you introduced).
> >>
> >> To be sure, I also removed all the IWL_ERR you added and tried to reboot (in
> >> order to see whether the printings were affecting synchronization).
> >>
> >
> > Glad to hear.
> >
> > You can also remove everything. Reapply the second patch, and here is
> > a new version of this patch after cleaning.
>
> I meant, reapply the first patch (the one that zeroes the TBs).

Ok, I will :) Thank you!

> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html

--
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara


Attachments:
(No filename) (1.09 kB)
(No filename) (490.00 B)
Download all attachments

2012-05-06 08:26:34

by Emmanuel Grumbach

[permalink] [raw]
Subject: Re: iwlwifi warn_slowpath with 3.*

All right,

Can you please test the patch I sent to you (which was good but not enough)
And add this one too ?

Thanks

Emmanuel Grumbach
[email protected]


On Sun, May 6, 2012 at 10:54 AM, Antonio Quartulli <[email protected]> wrote:
> On Sun, May 06, 2012 at 08:49:52 +0300, Emmanuel Grumbach wrote:
>> wait - I just noticed that this one introduced another issue...
>
> ok, I'll drop this patch
>
>>
>> Emmanuel Grumbach
>> [email protected]
>>
>>
>> On Sat, May 5, 2012 at 9:49 PM, Emmanuel Grumbach <[email protected]> wrote:
>> > Well,
>> >
>> > this is not the same warning as before.
>> > Can you try the patch attached ?
>> > I have submitted it internally.
>> >
>> > thanks
>> >
>> > Emmanuel Grumbach
>> > [email protected]
>> >
>> >
>> > On Fri, May 4, 2012 at 5:20 PM, Antonio Quartulli <[email protected]> wrote:
>> >> On Fri, May 04, 2012 at 09:58:30 +0300, Emmanuel Grumbach wrote:
>> >>> This can't be with my patch, is it ?
>> >>
>> >> here is the log. Some pieces are missing at the beginning, didn't check why.
>> >> However the WARNING comes up later, so it should be ok. Tell me if I can do
>> >> something else!
>> >>
>> >> Cheers,
>> >>
>> >>
>> >> --
>> >> Antonio Quartulli
>> >>
>> >> ..each of us alone is worth nothing..
>> >> Ernesto "Che" Guevara
>
> --
> Antonio Quartulli
>
> ..each of us alone is worth nothing..
> Ernesto "Che" Guevara


Attachments:
TX_idx.patch (4.13 kB)

2012-05-03 19:04:51

by Emmanuel Grumbach

[permalink] [raw]
Subject: Re: iwlwifi warn_slowpath with 3.*

Please enable CONFIG_FRAME_POINTERS
Emmanuel Grumbach
[email protected]


On Thu, May 3, 2012 at 9:53 AM, Antonio Quartulli <[email protected]> wrote:
> On Wed, May 02, 2012 at 06:21:02PM +0200, Antonio Quartulli wrote:
>> On Wed, May 02, 2012 at 11:39:14AM -0400, John W. Linville wrote:
>> > On Wed, May 02, 2012 at 10:08:46AM +0300, Emmanuel Grumbach wrote:
>> > > On Wed, May 2, 2012 at 12:19 AM, Venkataraman, Meenakshi
>> > > <[email protected]> wrote:
>> > > > Hi Antonio,
>> > > >
>> > > >>> it seems so. It happens at least once at boot time.
>> > > >>> I will try wireless-testing and see what happens. Then I will apply your patch.
>> > > >>
>> > > >>The problem is there either with wireless-testing and with
>> > > >>wireless-testing+your_patch.
>> > > >>
>> > > >>If it can somehow help, I also got several stack trace regarding intel_iova
>> > > >>functions. But then the I got kernel panic and I was not able to copy the
>> > > >>messages.
>> > > >
>> > > > [MV] Depending on how you set it up, perhaps the stack trace was saved in one of the syslog files in /var/log/...
>> > > >
>> > > > Thanks!
>> > > > Meenakshi
>> > > >
>> > >
>> > > Can you please re-run with debug=1 and send the whole log ?
>> > > This will give a better indication on when the issue occurs.
>> >
>> > Does this help?
>> >
>> > ? ? https://bugzilla.redhat.com/show_bug.cgi?id=815998#c18
>>
>> I applied patch in comment 17 on linux-3.3.4. IT didn't help but this time I got
>> the WARNING even with debug=1. Log is attached.
>>
>
>
> Is there any particular kernel debugging option I could enable to make the log
> more verbose?
>
>
> Cheers,
>
>
>
> --
> Antonio Quartulli
>
> ..each of us alone is worth nothing..
> Ernesto "Che" Guevara

2012-05-06 08:59:07

by Antonio Quartulli

[permalink] [raw]
Subject: Re: iwlwifi warn_slowpath with 3.*

On Sun, May 06, 2012 at 11:26:32 +0300, Emmanuel Grumbach wrote:
> All right,
>
> Can you please test the patch I sent to you (which was good but not enough)
> And add this one too ?

What branch are these patches based on?
I'm applying them onto wireless-testing, but I always messages like:

patching file drivers/net/wireless/iwlwifi/iwl-debugfs.c
Hunk #1 succeeded at 2211 (offset 1 line).

The patches apply anyway, but just to be sure I'm testing the correct branch


Cheers,

>
> Thanks
>
> Emmanuel Grumbach
> [email protected]
>
>
> On Sun, May 6, 2012 at 10:54 AM, Antonio Quartulli <[email protected]> wrote:
> > On Sun, May 06, 2012 at 08:49:52 +0300, Emmanuel Grumbach wrote:
> >> wait - I just noticed that this one introduced another issue...
> >
> > ok, I'll drop this patch
> >
> >>
> >> Emmanuel Grumbach
> >> [email protected]
> >>
> >>
> >> On Sat, May 5, 2012 at 9:49 PM, Emmanuel Grumbach <[email protected]> wrote:
> >> > Well,
> >> >
> >> > this is not the same warning as before.
> >> > Can you try the patch attached ?
> >> > I have submitted it internally.
> >> >
> >> > thanks
> >> >
> >> > Emmanuel Grumbach
> >> > [email protected]
> >> >
> >> >
> >> > On Fri, May 4, 2012 at 5:20 PM, Antonio Quartulli <[email protected]> wrote:
> >> >> On Fri, May 04, 2012 at 09:58:30 +0300, Emmanuel Grumbach wrote:
> >> >>> This can't be with my patch, is it ?
> >> >>
> >> >> here is the log. Some pieces are missing at the beginning, didn't check why.
> >> >> However the WARNING comes up later, so it should be ok. Tell me if I can do
> >> >> something else!
> >> >>
> >> >> Cheers,
> >> >>
> >> >>
> >> >> --
> >> >> Antonio Quartulli
> >> >>
> >> >> ..each of us alone is worth nothing..
> >> >> Ernesto "Che" Guevara
> >
> > --
> > Antonio Quartulli
> >
> > ..each of us alone is worth nothing..
> > Ernesto "Che" Guevara



--
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara


Attachments:
(No filename) (1.90 kB)
(No filename) (490.00 B)
Download all attachments

2012-05-03 20:09:00

by Antonio Quartulli

[permalink] [raw]
Subject: Re: iwlwifi warn_slowpath with 3.*

On Thu, May 03, 2012 at 10:55:12PM +0300, Emmanuel Grumbach wrote:
> Hi
>
> can you please apply the patch attached against wireless-testing ?

which patch? If you refer to the patch attached to the bugreport, it doesn't
apply on wireless-testing.


Cheers,

>
> You will have quite a lot of prints, so you will probably need to send
> /var/log/syslog or messages
>
>
> Thanks
>
> Emmanuel Grumbach
> [email protected]
>
>
> On Thu, May 3, 2012 at 10:04 PM, Emmanuel Grumbach <[email protected]> wrote:
> > Please enable CONFIG_FRAME_POINTERS
> > Emmanuel Grumbach
> > [email protected]
> >
> >
> > On Thu, May 3, 2012 at 9:53 AM, Antonio Quartulli <[email protected]> wrote:
> >> On Wed, May 02, 2012 at 06:21:02PM +0200, Antonio Quartulli wrote:
> >>> On Wed, May 02, 2012 at 11:39:14AM -0400, John W. Linville wrote:
> >>> > On Wed, May 02, 2012 at 10:08:46AM +0300, Emmanuel Grumbach wrote:
> >>> > > On Wed, May 2, 2012 at 12:19 AM, Venkataraman, Meenakshi
> >>> > > <[email protected]> wrote:
> >>> > > > Hi Antonio,
> >>> > > >
> >>> > > >>> it seems so. It happens at least once at boot time.
> >>> > > >>> I will try wireless-testing and see what happens. Then I will apply your patch.
> >>> > > >>
> >>> > > >>The problem is there either with wireless-testing and with
> >>> > > >>wireless-testing+your_patch.
> >>> > > >>
> >>> > > >>If it can somehow help, I also got several stack trace regarding intel_iova
> >>> > > >>functions. But then the I got kernel panic and I was not able to copy the
> >>> > > >>messages.
> >>> > > >
> >>> > > > [MV] Depending on how you set it up, perhaps the stack trace was saved in one of the syslog files in /var/log/...
> >>> > > >
> >>> > > > Thanks!
> >>> > > > Meenakshi
> >>> > > >
> >>> > >
> >>> > > Can you please re-run with debug=1 and send the whole log ?
> >>> > > This will give a better indication on when the issue occurs.
> >>> >
> >>> > Does this help?
> >>> >
> >>> >     https://bugzilla.redhat.com/show_bug.cgi?id=815998#c18
> >>>
> >>> I applied patch in comment 17 on linux-3.3.4. IT didn't help but this time I got
> >>> the WARNING even with debug=1. Log is attached.
> >>>
> >>
> >>
> >> Is there any particular kernel debugging option I could enable to make the log
> >> more verbose?
> >>
> >>
> >> Cheers,
> >>
> >>
> >>
> >> --
> >> Antonio Quartulli
> >>
> >> ..each of us alone is worth nothing..
> >> Ernesto "Che" Guevara

--
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara


Attachments:
(No filename) (2.46 kB)
(No filename) (490.00 B)
Download all attachments

2012-05-03 06:53:04

by Antonio Quartulli

[permalink] [raw]
Subject: Re: iwlwifi warn_slowpath with 3.*

On Wed, May 02, 2012 at 06:21:02PM +0200, Antonio Quartulli wrote:
> On Wed, May 02, 2012 at 11:39:14AM -0400, John W. Linville wrote:
> > On Wed, May 02, 2012 at 10:08:46AM +0300, Emmanuel Grumbach wrote:
> > > On Wed, May 2, 2012 at 12:19 AM, Venkataraman, Meenakshi
> > > <[email protected]> wrote:
> > > > Hi Antonio,
> > > >
> > > >>> it seems so. It happens at least once at boot time.
> > > >>> I will try wireless-testing and see what happens. Then I will apply your patch.
> > > >>
> > > >>The problem is there either with wireless-testing and with
> > > >>wireless-testing+your_patch.
> > > >>
> > > >>If it can somehow help, I also got several stack trace regarding intel_iova
> > > >>functions. But then the I got kernel panic and I was not able to copy the
> > > >>messages.
> > > >
> > > > [MV] Depending on how you set it up, perhaps the stack trace was saved in one of the syslog files in /var/log/...
> > > >
> > > > Thanks!
> > > > Meenakshi
> > > >
> > >
> > > Can you please re-run with debug=1 and send the whole log ?
> > > This will give a better indication on when the issue occurs.
> >
> > Does this help?
> >
> > https://bugzilla.redhat.com/show_bug.cgi?id=815998#c18
>
> I applied patch in comment 17 on linux-3.3.4. IT didn't help but this time I got
> the WARNING even with debug=1. Log is attached.
>


Is there any particular kernel debugging option I could enable to make the log
more verbose?


Cheers,



--
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara


Attachments:
(No filename) (1.51 kB)
(No filename) (490.00 B)
Download all attachments

2012-05-06 05:49:55

by Emmanuel Grumbach

[permalink] [raw]
Subject: Re: iwlwifi warn_slowpath with 3.*

wait - I just noticed that this one introduced another issue...

Emmanuel Grumbach
[email protected]


On Sat, May 5, 2012 at 9:49 PM, Emmanuel Grumbach <[email protected]> wrote:
> Well,
>
> this is not the same warning as before.
> Can you try the patch attached ?
> I have submitted it internally.
>
> thanks
>
> Emmanuel Grumbach
> [email protected]
>
>
> On Fri, May 4, 2012 at 5:20 PM, Antonio Quartulli <[email protected]> wrote:
>> On Fri, May 04, 2012 at 09:58:30 +0300, Emmanuel Grumbach wrote:
>>> This can't be with my patch, is it ?
>>
>> here is the log. Some pieces are missing at the beginning, didn't check why.
>> However the WARNING comes up later, so it should be ok. Tell me if I can do
>> something else!
>>
>> Cheers,
>>
>>
>> --
>> Antonio Quartulli
>>
>> ..each of us alone is worth nothing..
>> Ernesto "Che" Guevara

2012-05-05 18:50:01

by Emmanuel Grumbach

[permalink] [raw]
Subject: Re: iwlwifi warn_slowpath with 3.*

Well,

this is not the same warning as before.
Can you try the patch attached ?
I have submitted it internally.

thanks

Emmanuel Grumbach
[email protected]


On Fri, May 4, 2012 at 5:20 PM, Antonio Quartulli <[email protected]> wrote:
> On Fri, May 04, 2012 at 09:58:30 +0300, Emmanuel Grumbach wrote:
>> This can't be with my patch, is it ?
>
> here is the log. Some pieces are missing at the beginning, didn't check why.
> However the WARNING comes up later, so it should be ok. Tell me if I can do
> something else!
>
> Cheers,
>
>
> --
> Antonio Quartulli
>
> ..each of us alone is worth nothing..
> Ernesto "Che" Guevara


Attachments:
0001-iwlwifi-zero-the-number-of-BDs-after-unmapping-a-TFD.patch (4.35 kB)

2012-05-06 09:15:19

by Antonio Quartulli

[permalink] [raw]
Subject: Re: iwlwifi warn_slowpath with 3.*

On Sun, May 06, 2012 at 10:56:38AM +0200, Antonio Quartulli wrote:
> On Sun, May 06, 2012 at 11:26:32 +0300, Emmanuel Grumbach wrote:
> > All right,
> >
> > Can you please test the patch I sent to you (which was good but not enough)
> > And add this one too ?
>
> Ok, I'll also leave the print.patch.
> I'll report the result.
>

The WARNING is gone :)

I attached the dmesg log anyway (debug was off, but there
are all the prints you introduced).

To be sure, I also removed all the IWL_ERR you added and tried to reboot (in
order to see whether the printings were affecting synchronization).


Thank you!

> Thank you
>
> >
> > Thanks
> >
> > Emmanuel Grumbach
> > [email protected]
> >
> >
> > On Sun, May 6, 2012 at 10:54 AM, Antonio Quartulli <[email protected]> wrote:
> > > On Sun, May 06, 2012 at 08:49:52 +0300, Emmanuel Grumbach wrote:
> > >> wait - I just noticed that this one introduced another issue...
> > >
> > > ok, I'll drop this patch
> > >
> > >>
> > >> Emmanuel Grumbach
> > >> [email protected]
> > >>
> > >>
> > >> On Sat, May 5, 2012 at 9:49 PM, Emmanuel Grumbach <[email protected]> wrote:
> > >> > Well,
> > >> >
> > >> > this is not the same warning as before.
> > >> > Can you try the patch attached ?
> > >> > I have submitted it internally.
> > >> >
> > >> > thanks
> > >> >
> > >> > Emmanuel Grumbach
> > >> > [email protected]
> > >> >
> > >> >
> > >> > On Fri, May 4, 2012 at 5:20 PM, Antonio Quartulli <[email protected]> wrote:
> > >> >> On Fri, May 04, 2012 at 09:58:30 +0300, Emmanuel Grumbach wrote:
> > >> >>> This can't be with my patch, is it ?
> > >> >>
> > >> >> here is the log. Some pieces are missing at the beginning, didn't check why.
> > >> >> However the WARNING comes up later, so it should be ok. Tell me if I can do
> > >> >> something else!
> > >> >>
> > >> >> Cheers,
> > >> >>
> > >> >>
> > >> >> --
> > >> >> Antonio Quartulli
> > >> >>
> > >> >> ..each of us alone is worth nothing..
> > >> >> Ernesto "Che" Guevara
> > >
> > > --
> > > Antonio Quartulli
> > >
> > > ..each of us alone is worth nothing..
> > > Ernesto "Che" Guevara
>
>
>
> --
> Antonio Quartulli
>
> ..each of us alone is worth nothing..
> Ernesto "Che" Guevara



--
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara


Attachments:
(No filename) (0.00 B)
(No filename) (490.00 B)
Download all attachments

2012-05-02 15:47:51

by John W. Linville

[permalink] [raw]
Subject: Re: iwlwifi warn_slowpath with 3.*

On Wed, May 02, 2012 at 10:08:46AM +0300, Emmanuel Grumbach wrote:
> On Wed, May 2, 2012 at 12:19 AM, Venkataraman, Meenakshi
> <[email protected]> wrote:
> > Hi Antonio,
> >
> >>> it seems so. It happens at least once at boot time.
> >>> I will try wireless-testing and see what happens. Then I will apply your patch.
> >>
> >>The problem is there either with wireless-testing and with
> >>wireless-testing+your_patch.
> >>
> >>If it can somehow help, I also got several stack trace regarding intel_iova
> >>functions. But then the I got kernel panic and I was not able to copy the
> >>messages.
> >
> > [MV] Depending on how you set it up, perhaps the stack trace was saved in one of the syslog files in /var/log/...
> >
> > Thanks!
> > Meenakshi
> >
>
> Can you please re-run with debug=1 and send the whole log ?
> This will give a better indication on when the issue occurs.

Does this help?

https://bugzilla.redhat.com/show_bug.cgi?id=815998#c18

John
--
John W. Linville Someday the world will need a hero, and you
[email protected] might be all we have. Be ready.

2012-05-04 06:36:03

by Antonio Quartulli

[permalink] [raw]
Subject: Re: iwlwifi warn_slowpath with 3.*

ops... my fault

On Fri, May 04, 2012 at 08:11:54 +0300, Emmanuel Grumbach wrote:
> nothing attaced
>
> Emmanuel Grumbach
> [email protected]
>
>
> On Fri, May 4, 2012 at 3:21 AM, Antonio Quartulli <[email protected]> wrote:
> > mhmmm I attached dmesg again. Do you really need messages?
> >
> > Cheers,
> >
> >
> > On Thu, May 03, 2012 at 11:17:14 +0300, Emmanuel Grumbach wrote:
> >> ooops
> >>
> >>
> >> here it is
> >>
> >>
> >>
> >> Emmanuel Grumbach
> >> [email protected]
> >>
> >>
> >> On Thu, May 3, 2012 at 11:09 PM, Antonio Quartulli <[email protected]> wrote:
> >> > On Thu, May 03, 2012 at 10:55:12PM +0300, Emmanuel Grumbach wrote:
> >> >> Hi
> >> >>
> >> >> can you please apply the patch attached against wireless-testing ?
> >> >
> >> > which patch? If you refer to the patch attached to the bugreport, it doesn't
> >> > apply on wireless-testing.
> >> >
> >> >
> >> > Cheers,
> >> >
> >> >>
> >> >> You will have quite a lot of prints, so you will probably need to send
> >> >> /var/log/syslog or messages
> >> >>
> >> >>
> >> >> Thanks
> >> >>
> >> >> Emmanuel Grumbach
> >> >> [email protected]
> >> >>
> >> >>
> >> >> On Thu, May 3, 2012 at 10:04 PM, Emmanuel Grumbach <[email protected]> wrote:
> >> >> > Please enable CONFIG_FRAME_POINTERS
> >> >> > Emmanuel Grumbach
> >> >> > [email protected]
> >> >> >
> >> >> >
> >> >> > On Thu, May 3, 2012 at 9:53 AM, Antonio Quartulli <[email protected]> wrote:
> >> >> >> On Wed, May 02, 2012 at 06:21:02PM +0200, Antonio Quartulli wrote:
> >> >> >>> On Wed, May 02, 2012 at 11:39:14AM -0400, John W. Linville wrote:
> >> >> >>> > On Wed, May 02, 2012 at 10:08:46AM +0300, Emmanuel Grumbach wrote:
> >> >> >>> > > On Wed, May 2, 2012 at 12:19 AM, Venkataraman, Meenakshi
> >> >> >>> > > <[email protected]> wrote:
> >> >> >>> > > > Hi Antonio,
> >> >> >>> > > >
> >> >> >>> > > >>> it seems so. It happens at least once at boot time.
> >> >> >>> > > >>> I will try wireless-testing and see what happens. Then I will apply your patch.
> >> >> >>> > > >>
> >> >> >>> > > >>The problem is there either with wireless-testing and with
> >> >> >>> > > >>wireless-testing+your_patch.
> >> >> >>> > > >>
> >> >> >>> > > >>If it can somehow help, I also got several stack trace regarding intel_iova
> >> >> >>> > > >>functions. But then the I got kernel panic and I was not able to copy the
> >> >> >>> > > >>messages.
> >> >> >>> > > >
> >> >> >>> > > > [MV] Depending on how you set it up, perhaps the stack trace was saved in one of the syslog files in /var/log/...
> >> >> >>> > > >
> >> >> >>> > > > Thanks!
> >> >> >>> > > > Meenakshi
> >> >> >>> > > >
> >> >> >>> > >
> >> >> >>> > > Can you please re-run with debug=1 and send the whole log ?
> >> >> >>> > > This will give a better indication on when the issue occurs.
> >> >> >>> >
> >> >> >>> > Does this help?
> >> >> >>> >
> >> >> >>> >     https://bugzilla.redhat.com/show_bug.cgi?id=815998#c18
> >> >> >>>
> >> >> >>> I applied patch in comment 17 on linux-3.3.4. IT didn't help but this time I got
> >> >> >>> the WARNING even with debug=1. Log is attached.
> >> >> >>>
> >> >> >>
> >> >> >>
> >> >> >> Is there any particular kernel debugging option I could enable to make the log
> >> >> >> more verbose?
> >> >> >>
> >> >> >>
> >> >> >> Cheers,
> >> >> >>
> >> >> >>
> >> >> >>
> >> >> >> --
> >> >> >> Antonio Quartulli
> >> >> >>
> >> >> >> ..each of us alone is worth nothing..
> >> >> >> Ernesto "Che" Guevara
> >> >
> >> > --
> >> > Antonio Quartulli
> >> >
> >> > ..each of us alone is worth nothing..
> >> > Ernesto "Che" Guevara
> >
> >
> >
> > --
> > Antonio Quartulli
> >
> > ..each of us alone is worth nothing..
> > Ernesto "Che" Guevara
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html

--
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara


Attachments:
(No filename) (0.00 B)
(No filename) (490.00 B)
Download all attachments