2012-08-07 00:55:31

by Fengguang Wu

[permalink] [raw]
Subject: [wireless-testing:master 53/59] drivers/net/wireless/mwifiex/uap_event.c:251:11: warning: comparison of distinct pointer types lacks a cast

Hi Avinash,

FYI, there are new compile warnings show up in

tree: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-testing.git master
head: e73930134aafdf703d77043a429e46d254176ac8
commit: d1cf3b958cb6940cb4e0a71697458035dad9e5b9 [53/59] mwifiex: support RX AMSDU aggregation for uAP
config: powerpc-allmodconfig (attached as .config)

All error/warnings:

drivers/net/wireless/mwifiex/uap_event.c: In function 'mwifiex_process_uap_event':
drivers/net/wireless/mwifiex/uap_event.c:251:11: warning: comparison of distinct pointer types lacks a cast [enabled by default]

vim +251 drivers/net/wireless/mwifiex/uap_event.c
248
249 if (priv->media_connected) {
250 adapter->tx_buf_size =
> 251 min(adapter->curr_tx_buf_size,
252 le16_to_cpu(*(__le16 *)adapter->event_body));
253
254 dev_dbg(adapter->dev, "event: tx_buf_size %d\n",

---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu <[email protected]> Intel Corporation


Attachments:
(No filename) (1.02 kB)
.config (122.16 kB)
Download all attachments

2012-08-07 06:58:40

by Avinash Patil

[permalink] [raw]
Subject: RE: [wireless-testing:master 53/59] drivers/net/wireless/mwifiex/uap_event.c:251:11: warning: comparison of distinct pointer types lacks a cast

Hi Fengguang,

Thanks for toolchain URL.

I will fix this warning and send a patch to mailing list.

Regards,
Avinash Patil


-----Original Message-----
From: Fengguang Wu [mailto:[email protected]]
Sent: Tuesday, August 07, 2012 8:17 AM
To: Bing Zhao
Cc: Avinash Patil; [email protected]; John W. Linville; Kiran Divekar; [email protected]
Subject: Re: [wireless-testing:master 53/59] drivers/net/wireless/mwifiex/uap_event.c:251:11: warning: comparison of distinct pointer types lacks a cast

On Mon, Aug 06, 2012 at 07:33:37PM -0700, Bing Zhao wrote:
> Hi Fengguang,
>
> > drivers/net/wireless/mwifiex/uap_event.c: In function 'mwifiex_process_uap_event':
> > drivers/net/wireless/mwifiex/uap_event.c:251:11: warning: comparison of distinct pointer types lacks
> > a cast [enabled by default]
>
> Thanks for reporting this warning.
> Could you please share your gcc version (or ppc toolchain version) with me?

Bing, the toolchain is downloaded from

https://www.kernel.org/pub/tools/crosstool/files/bin/x86_64/4.6.3/

Just unpack the powerpc package to /usr/local and run this:

/usr/bin/make ARCH=powerpc CROSS_COMPILE=/usr/local/gcc-4.6.3-nolibc/powerpc64-linux/bin/powerpc64-linux- allmodconfig

The gcc version is:

% /usr/local/gcc-4.6.3-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc -v
Using built-in specs.
COLLECT_GCC=/usr/local/gcc-4.6.3-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc
COLLECT_LTO_WRAPPER=/usr/local/gcc-4.6.3-nolibc/powerpc64-linux/bin/../libexec/gcc/powerpc64-linux/4.6.3/lto-wrapper
Target: powerpc64-linux
Configured with: /home/tony/buildall/src/gcc/configure --target=powerpc64-linux --host=x86_64-linux-gnu --build=x86_64-linux-gnu --enable-targets=all --prefix=/opt/cross/gcc-4.6.3-nolibc/powerpc64-linux/ --enable-languages=c --with-newlib --without-headers --enable-sjlj-exceptions --with-system-libunwind --disable-nls --disable-threads --disable-shared --disable-libmudflap --disable-libssp --disable-libgomp --disable-decimal-float --enable-checking=release --with-mpfr=/home/tony/buildall/src/sys-x86_64 --with-gmp=/home/tony/buildall/src/sys-x86_64 --disable-bootstrap --disable-libquadmath
Thread model: single
gcc version 4.6.3 (GCC)

Thanks,
Fengguang

2012-08-07 02:35:01

by Bing Zhao

[permalink] [raw]
Subject: RE: [wireless-testing:master 53/59] drivers/net/wireless/mwifiex/uap_event.c:251:11: warning: comparison of distinct pointer types lacks a cast

Hi Fengguang,

> drivers/net/wireless/mwifiex/uap_event.c: In function 'mwifiex_process_uap_event':
> drivers/net/wireless/mwifiex/uap_event.c:251:11: warning: comparison of distinct pointer types lacks
> a cast [enabled by default]

Thanks for reporting this warning.
Could you please share your gcc version (or ppc toolchain version) with me?

Thanks,
Bing


2012-08-07 02:47:11

by Fengguang Wu

[permalink] [raw]
Subject: Re: [wireless-testing:master 53/59] drivers/net/wireless/mwifiex/uap_event.c:251:11: warning: comparison of distinct pointer types lacks a cast

On Mon, Aug 06, 2012 at 07:33:37PM -0700, Bing Zhao wrote:
> Hi Fengguang,
>
> > drivers/net/wireless/mwifiex/uap_event.c: In function 'mwifiex_process_uap_event':
> > drivers/net/wireless/mwifiex/uap_event.c:251:11: warning: comparison of distinct pointer types lacks
> > a cast [enabled by default]
>
> Thanks for reporting this warning.
> Could you please share your gcc version (or ppc toolchain version) with me?

Bing, the toolchain is downloaded from

https://www.kernel.org/pub/tools/crosstool/files/bin/x86_64/4.6.3/

Just unpack the powerpc package to /usr/local and run this:

/usr/bin/make ARCH=powerpc CROSS_COMPILE=/usr/local/gcc-4.6.3-nolibc/powerpc64-linux/bin/powerpc64-linux- allmodconfig

The gcc version is:

% /usr/local/gcc-4.6.3-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc -v
Using built-in specs.
COLLECT_GCC=/usr/local/gcc-4.6.3-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc
COLLECT_LTO_WRAPPER=/usr/local/gcc-4.6.3-nolibc/powerpc64-linux/bin/../libexec/gcc/powerpc64-linux/4.6.3/lto-wrapper
Target: powerpc64-linux
Configured with: /home/tony/buildall/src/gcc/configure --target=powerpc64-linux --host=x86_64-linux-gnu --build=x86_64-linux-gnu --enable-targets=all --prefix=/opt/cross/gcc-4.6.3-nolibc/powerpc64-linux/ --enable-languages=c --with-newlib --without-headers --enable-sjlj-exceptions --with-system-libunwind --disable-nls --disable-threads --disable-shared --disable-libmudflap --disable-libssp --disable-libgomp --disable-decimal-float --enable-checking=release --with-mpfr=/home/tony/buildall/src/sys-x86_64 --with-gmp=/home/tony/buildall/src/sys-x86_64 --disable-bootstrap --disable-libquadmath
Thread model: single
gcc version 4.6.3 (GCC)

Thanks,
Fengguang