2012-08-09 06:57:50

by Dan Carpenter

Subject: [patch] wireless: at76c50x: signedness bug in at76_dfu_get_state()

This return holds the number of bytes transfered (1 byte) or a negative
error code. The type should be int instead of u8.

Signed-off-by: Dan Carpenter <[email protected]>

diff --git a/drivers/net/wireless/at76c50x-usb.c b/drivers/net/wireless/at76c50x-usb.c
index efc162e..88b8d64 100644
--- a/drivers/net/wireless/at76c50x-usb.c
+++ b/drivers/net/wireless/at76c50x-usb.c
@@ -342,7 +342,7 @@ static int at76_dfu_get_status(struct usb_device *udev,
return ret;
}

-static u8 at76_dfu_get_state(struct usb_device *udev, u8 *state)
+static int at76_dfu_get_state(struct usb_device *udev, u8 *state)
{
int ret;

2012-08-09 21:18:26

by Pavel Roskin

Subject: Re: [patch] wireless: at76c50x: signedness bug in at76_dfu_get_state()

On Thu, 9 Aug 2012 09:57:30 +0300
Dan Carpenter <[email protected]> wrote:

> This return holds the number of bytes transfered (1 byte) or a
> negative error code. The type should be int instead of u8.
>
> Signed-off-by: Dan Carpenter <[email protected]>

Acked-by: Pavel Roskin <[email protected]>

Nice catch, thanks!

--
Regards,
Pavel Roskin