2012-09-10 07:22:00

by Wei Yongjun

Subject: [PATCH v2] rndis_wlan: remove pointless check from rndis_scan()

From: Wei Yongjun <[email protected]>

In rndis_scan(), 'request' is actually always valid pointer and
the !request check is unneeded, so remove it.

Signed-off-by: Wei Yongjun <[email protected]>
---
drivers/net/wireless/rndis_wlan.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/net/wireless/rndis_wlan.c b/drivers/net/wireless/rndis_wlan.c
index 7a4ae9e..bd1f0cb 100644
--- a/drivers/net/wireless/rndis_wlan.c
+++ b/drivers/net/wireless/rndis_wlan.c
@@ -1959,9 +1959,6 @@ static int rndis_scan(struct wiphy *wiphy,
*/
rndis_check_bssid_list(usbdev, NULL, NULL);

- if (!request)
- return -EINVAL;
-
if (priv->scan_request && priv->scan_request != request)
return -EBUSY;

2012-09-10 15:33:43

by Jussi Kivilinna

Subject: Re: [PATCH v2] rndis_wlan: remove pointless check from rndis_scan()

Quoting Wei Yongjun <[email protected]>:

> From: Wei Yongjun <[email protected]>
>
> In rndis_scan(), 'request' is actually always valid pointer and
> the !request check is unneeded, so remove it.
>
> Signed-off-by: Wei Yongjun <[email protected]>

Acked-by: Jussi Kivilinna <[email protected]>

> ---
> drivers/net/wireless/rndis_wlan.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/wireless/rndis_wlan.c
> b/drivers/net/wireless/rndis_wlan.c
> index 7a4ae9e..bd1f0cb 100644
> --- a/drivers/net/wireless/rndis_wlan.c
> +++ b/drivers/net/wireless/rndis_wlan.c
> @@ -1959,9 +1959,6 @@ static int rndis_scan(struct wiphy *wiphy,
> */
> rndis_check_bssid_list(usbdev, NULL, NULL);
>
> - if (!request)
> - return -EINVAL;
> -
> if (priv->scan_request && priv->scan_request != request)
> return -EBUSY;
>
>
>
>
>