2013-01-27 21:17:54

by Guenter Roeck

Subject: Potential problem in drivers/net/wireless/rtlwifi/usb.c:_rtl_rx_pre_process()

Hi all,

while browsing through 'warning: variable ‘...’ set but not used' warnings, I
found the following code in drivers/net/wireless/rtlwifi/usb.c:_rtl_rx_pre_process().

while (!skb_queue_empty(&rx_queue)) {
_skb = skb_dequeue(&rx_queue);
_rtl_usb_rx_process_agg(hw, skb);
ieee80211_rx_irqsafe(hw, skb);
}

Question: Should the parameter to _rtl_usb_rx_process_agg() and
ieee80211_rx_irqsafe() be '_skb' instead of 'skb' ?

Thanks,
Guenter

2013-01-27 22:11:54

by Larry Finger

Subject: Re: Potential problem in drivers/net/wireless/rtlwifi/usb.c:_rtl_rx_pre_process()

On 01/27/2013 03:18 PM, Guenter Roeck wrote:
> Hi all,
>
> while browsing through 'warning: variable ‘...’ set but not used' warnings, I
> found the following code in drivers/net/wireless/rtlwifi/usb.c:_rtl_rx_pre_process().
>
> while (!skb_queue_empty(&rx_queue)) {
> _skb = skb_dequeue(&rx_queue);
> _rtl_usb_rx_process_agg(hw, skb);
> ieee80211_rx_irqsafe(hw, skb);
> }
>
> Question: Should the parameter to _rtl_usb_rx_process_agg() and
> ieee80211_rx_irqsafe() be '_skb' instead of 'skb' ?

I think you are right and I will submit a patch to fix this.

What compiler version reported this? I use "gcc (SUSE Linux) 4.7.2 20130108
[gcc-4_7-branch revision 195012]" and I do not see this warning.

Thanks,

Larry

2013-01-27 23:51:45

by Guenter Roeck

Subject: Re: Potential problem in drivers/net/wireless/rtlwifi/usb.c:_rtl_rx_pre_process()

On Sun, Jan 27, 2013 at 04:11:51PM -0600, Larry Finger wrote:
> On 01/27/2013 03:18 PM, Guenter Roeck wrote:
> >Hi all,
> >
> >while browsing through 'warning: variable ‘...’ set but not used' warnings, I
> >found the following code in drivers/net/wireless/rtlwifi/usb.c:_rtl_rx_pre_process().
> >
> > while (!skb_queue_empty(&rx_queue)) {
> > _skb = skb_dequeue(&rx_queue);
> > _rtl_usb_rx_process_agg(hw, skb);
> > ieee80211_rx_irqsafe(hw, skb);
> > }
> >
> >Question: Should the parameter to _rtl_usb_rx_process_agg() and
> >ieee80211_rx_irqsafe() be '_skb' instead of 'skb' ?
>
> I think you are right and I will submit a patch to fix this.
>
> What compiler version reported this? I use "gcc (SUSE Linux) 4.7.2
> 20130108 [gcc-4_7-branch revision 195012]" and I do not see this
> warning.
>
Hi Larry,

I use "gcc (Ubuntu/Linaro 4.7.2-2ubuntu1) 4.7.2".

You'll see the warning if you build the kernel with W=1.

Guenter