Corrected USB ID for T-Com Sinus 154 data II. ISL3887-based. The device was tested in managed mode with no security, WEP 128 bit and WPA-PSK (TKIP) with firmware 2.13.1.0.lm87.arm (md5sum: 7d676323ac60d6e1a3b6d61e8c528248). It works.
Signed-off-by: Tomasz Guszkowski <[email protected]>
---
Hi!
I have submitted a patch for this device on Dec 22-nd 2012. A couple of days ago I fetched a new kernel, with the December-submitted patch inside, compiled it and noticed to my surprise the device didn't work. A short investigation shown wrong USB ID. I must have done an error while manually modifying p54usb.c in git tree.
My mistake.
lsusb confirms this time the ID is correct:
root@tsg-desktop:/usr/src/git# lsusb -s1:4
Bus 001 Device 004: ID 083a:4531 Accton Technology Corp.
Let's correct this bug.
Tomek
drivers/net/wireless/p54/p54usb.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/p54/p54usb.c b/drivers/net/wireless/p54/p54usb.c
index 800a165..1f78585 100644
--- a/drivers/net/wireless/p54/p54usb.c
+++ b/drivers/net/wireless/p54/p54usb.c
@@ -84,8 +84,8 @@ static struct usb_device_id p54u_table[] = {
{USB_DEVICE(0x06b9, 0x0121)}, /* Thomson SpeedTouch 121g */
{USB_DEVICE(0x0707, 0xee13)}, /* SMC 2862W-G version 2 */
{USB_DEVICE(0x0803, 0x4310)}, /* Zoom 4410a */
- {USB_DEVICE(0x083a, 0x4503)}, /* T-Com Sinus 154 data II */
{USB_DEVICE(0x083a, 0x4521)}, /* Siemens Gigaset USB Adapter 54 version 2 */
+ {USB_DEVICE(0x083a, 0x4531)}, /* T-Com Sinus 154 data II */
{USB_DEVICE(0x083a, 0xc501)}, /* Zoom Wireless-G 4410 */
{USB_DEVICE(0x083a, 0xf503)}, /* Accton FD7050E ver 1010ec */
{USB_DEVICE(0x0846, 0x4240)}, /* Netgear WG111 (v2) */
--
1.7.5.4
(Added John [He takes all the driver patches ;).
John, do you want/need a line-wrapped commit message
of the original patch or is this OK?)
On Tuesday, February 05, 2013 10:10:31 PM Tomasz Guszkowski wrote:
> Corrected USB ID for T-Com Sinus 154 data II. ISL3887-based.
> The device was tested in managed mode with no security, WEP
> 128 bit and WPA-PSK (TKIP) with firmware 2.13.1.0.lm87.arm
> (md5sum: 7d676323ac60d6e1a3b6d61e8c528248). It works.
>
> Signed-off-by: Tomasz Guszkowski <[email protected]>
Cc: <[email protected]>
Acked-By: Christian Lamparter <[email protected]>
> ---
I'll take care of updating the wireless.kernel.org wiki
<http://wireless.kernel.org/en/users/Drivers/p54/devices>
entry later this week.
OT: The latest supported firmware for LM87 is: 2.13.25.0.lm87.arm
Did you experience issues with the new version, or do you simply
stick with the old 2.13.1.0 because it does work just as well?
Regards
Christian
On Wednesday, February 06, 2013 11:39:51 PM Tomasz Guszkowski wrote:
> On Tue, 5 Feb 2013, Christian Lamparter wrote:
> > OT: The latest supported firmware for LM87 is: 2.13.25.0.lm87.arm
> > Did you experience issues with the new version, or do you simply
> > stick with the old 2.13.1.0 because it does work just as well?
>
> I have just tested behavior of T-Com with 2.13.25.0.lm87.arm
> (md5sum 39be687c87544b892e7a8ffe7ffd9371) in managed mode.
> Ewerything what was tested worked perfectly:
> 1. iwlist wlan0 scan
> 2. connecting to open network
> 3. connecting to WEP 128-bit
> 4. connecting to WPA-PSK (TKIP)
> 5. connecting to WPA2-PSK (AES)
>
> I am particularly impressed by working WPA2, with 2.13.1.0
> it didn't work.
Ok, that is actually important. I didn't know that 2.13.1.0
had problems with AES, I'll check that again. Thanks for
letting me know about this.
> Thanks for pointing newer firmware, with WPA2 support it's
> an excellent, sensitive card despite its age.
:-) [But of course: the driver is not done yet, I hope I'll get
around and add the automatic-reset-when-firmware-crashes feature
in the near future.]
Regards
Christian
On Tue, 5 Feb 2013, Christian Lamparter wrote:
> OT: The latest supported firmware for LM87 is: 2.13.25.0.lm87.arm
> Did you experience issues with the new version, or do you simply
> stick with the old 2.13.1.0 because it does work just as well?
Hello again,
I have just tested behavior of T-Com with 2.13.25.0.lm87.arm
(md5sum 39be687c87544b892e7a8ffe7ffd9371) in managed mode.
Ewerything what was tested worked perfectly:
1. iwlist wlan0 scan
2. connecting to open network
3. connecting to WEP 128-bit
4. connecting to WPA-PSK (TKIP)
5. connecting to WPA2-PSK (AES)
I am particularly impressed by working WPA2, with 2.13.1.0
it didn't work.
Thanks for pointing newer firmware, with WPA2 support it's
an excellent, sensitive card despite its age.
Regards,
Tomek