2013-03-17 09:54:08

by Jussi Kivilinna

Subject: [PATCH] rtlwifi: usb: add missing freeing of skbuff

Signed-off-by: Jussi Kivilinna <[email protected]>
---
drivers/net/wireless/rtlwifi/usb.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/rtlwifi/usb.c b/drivers/net/wireless/rtlwifi/usb.c
index b5c80b5..41dce83 100644
--- a/drivers/net/wireless/rtlwifi/usb.c
+++ b/drivers/net/wireless/rtlwifi/usb.c
@@ -850,6 +850,7 @@ static void _rtl_usb_transmit(struct ieee80211_hw *hw, struct sk_buff *skb,
if (unlikely(!_urb)) {
RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
"Can't allocate urb. Drop skb!\n");
+ kfree_skb(skb);
return;
}
_rtl_submit_tx_urb(hw, _urb);

2013-03-17 17:16:51

by Larry Finger

Subject: Re: [PATCH] rtlwifi: usb: add missing freeing of skbuff

On 03/17/2013 04:54 AM, Jussi Kivilinna wrote:
> Signed-off-by: Jussi Kivilinna <[email protected]>
> ---
> drivers/net/wireless/rtlwifi/usb.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/rtlwifi/usb.c b/drivers/net/wireless/rtlwifi/usb.c
> index b5c80b5..41dce83 100644
> --- a/drivers/net/wireless/rtlwifi/usb.c
> +++ b/drivers/net/wireless/rtlwifi/usb.c
> @@ -850,6 +850,7 @@ static void _rtl_usb_transmit(struct ieee80211_hw *hw, struct sk_buff *skb,
> if (unlikely(!_urb)) {
> RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
> "Can't allocate urb. Drop skb!\n");
> + kfree_skb(skb);
> return;
> }
> _rtl_submit_tx_urb(hw, _urb);
>

Acked-by: Larry Finger <[email protected]>

John - Add Stable as Cc.

Good catch. Thanks,

Larry