2013-05-30 11:42:55

by Wei Yongjun

[permalink] [raw]

Subject: [PATCH -next] cw1200: use module_spi_driver to simplify the code

---

From: Wei Yongjun <[email protected]>

module_spi_driver() makes the code simpler by eliminating
boilerplate code.

Signed-off-by: Wei Yongjun <[email protected]>
---
drivers/net/wireless/cw1200/cw1200_spi.c | 15 +--------------
1 file changed, 1 insertion(+), 14 deletions(-)

diff --git a/drivers/net/wireless/cw1200/cw1200_spi.c b/drivers/net/wireless/cw1200/cw1200_spi.c
index 04af685..1e6c58d 100644
--- a/drivers/net/wireless/cw1200/cw1200_spi.c
+++ b/drivers/net/wireless/cw1200/cw1200_spi.c
@@ -464,17 +464,4 @@ static struct spi_driver spi_driver = {
},
};

-/* Init Module function -> Called by insmod */
-static int __init cw1200_spi_init(void)
-{
- return spi_register_driver(&spi_driver);
-}
-
-/* Called at Driver Unloading */
-static void __exit cw1200_spi_exit(void)
-{
- spi_unregister_driver(&spi_driver);
-}
-
-module_init(cw1200_spi_init);
-module_exit(cw1200_spi_exit);
+module_spi_driver(spi_driver);

2013-06-01 12:02:42

by Solomon Peachy

[permalink] [raw]

Subject: Re: [PATCH -next] cw1200: use module_spi_driver to simplify the code

---

On Thu, May 30, 2013 at 07:42:54PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <[email protected]>
>
> module_spi_driver() makes the code simpler by eliminating
> boilerplate code.
>
> Signed-off-by: Wei Yongjun <[email protected]>

Acked-by: Solomon Peachy <[email protected]>

> ---
> drivers/net/wireless/cw1200/cw1200_spi.c | 15 +--------------
> 1 file changed, 1 insertion(+), 14 deletions(-)
>
> diff --git a/drivers/net/wireless/cw1200/cw1200_spi.c b/drivers/net/wireless/cw1200/cw1200_spi.c
> index 04af685..1e6c58d 100644
> --- a/drivers/net/wireless/cw1200/cw1200_spi.c
> +++ b/drivers/net/wireless/cw1200/cw1200_spi.c
> @@ -464,17 +464,4 @@ static struct spi_driver spi_driver = {
> },
> };
>
> -/* Init Module function -> Called by insmod */
> -static int __init cw1200_spi_init(void)
> -{
> - return spi_register_driver(&spi_driver);
> -}
> -
> -/* Called at Driver Unloading */
> -static void __exit cw1200_spi_exit(void)
> -{
> - spi_unregister_driver(&spi_driver);
> -}
> -
> -module_init(cw1200_spi_init);
> -module_exit(cw1200_spi_exit);
> +module_spi_driver(spi_driver);
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html

--
Solomon Peachy pizza at shaftnet dot org
Delray Beach, FL ^^ (mail/jabber) ^^
Quidquid latine dictum sit, altum viditur.

---

Attachments:

(No filename) (1.47 kB)
(No filename) (190.00 B)
Download all attachments