2013-06-10 22:41:51

by Bing Zhao

Subject: [PATCH RESEND] mwifiex: enable/disable tx_amsdu support via module parameter

From: Avinash Patil <[email protected]>

This patch disables tx_amsdu support in mwifiex by default.
tx_amdsu support can be enabled via module parameter at load time.

Signed-off-by: Avinash Patil <[email protected]>
Signed-off-by: Bing Zhao <[email protected]>
---
drivers/net/wireless/mwifiex/wmm.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/mwifiex/wmm.c b/drivers/net/wireless/mwifiex/wmm.c
index 4be3d33..944e884 100644
--- a/drivers/net/wireless/mwifiex/wmm.c
+++ b/drivers/net/wireless/mwifiex/wmm.c
@@ -37,6 +37,9 @@
/* Offset for TOS field in the IP header */
#define IPTOS_OFFSET 5

+static bool enable_tx_amsdu;
+module_param(enable_tx_amsdu, bool, 0644);
+
/* WMM information IE */
static const u8 wmm_info_ie[] = { WLAN_EID_VENDOR_SPECIFIC, 0x07,
0x00, 0x50, 0xf2, 0x02,
@@ -1233,7 +1236,7 @@ mwifiex_dequeue_tx_packet(struct mwifiex_adapter *adapter)
mwifiex_send_delba(priv, tid_del, ra, 1);
}
}
- if (mwifiex_is_amsdu_allowed(priv, tid) &&
+ if (enable_tx_amsdu && mwifiex_is_amsdu_allowed(priv, tid) &&
mwifiex_is_11n_aggragation_possible(priv, ptr,
adapter->tx_buf_size))
mwifiex_11n_aggregate_pkt(priv, ptr, INTF_HEADER_LEN,
--
1.8.2.3

2013-06-11 17:00:14

by John W. Linville

Subject: Re: [PATCH RESEND] mwifiex: enable/disable tx_amsdu support via module parameter

I have the original for this one too...

On Mon, Jun 10, 2013 at 03:39:58PM -0700, Bing Zhao wrote:
> From: Avinash Patil <[email protected]>
>
> This patch disables tx_amsdu support in mwifiex by default.
> tx_amdsu support can be enabled via module parameter at load time.
>
> Signed-off-by: Avinash Patil <[email protected]>
> Signed-off-by: Bing Zhao <[email protected]>
> ---
> drivers/net/wireless/mwifiex/wmm.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/mwifiex/wmm.c b/drivers/net/wireless/mwifiex/wmm.c
> index 4be3d33..944e884 100644
> --- a/drivers/net/wireless/mwifiex/wmm.c
> +++ b/drivers/net/wireless/mwifiex/wmm.c
> @@ -37,6 +37,9 @@
> /* Offset for TOS field in the IP header */
> #define IPTOS_OFFSET 5
>
> +static bool enable_tx_amsdu;
> +module_param(enable_tx_amsdu, bool, 0644);
> +
> /* WMM information IE */
> static const u8 wmm_info_ie[] = { WLAN_EID_VENDOR_SPECIFIC, 0x07,
> 0x00, 0x50, 0xf2, 0x02,
> @@ -1233,7 +1236,7 @@ mwifiex_dequeue_tx_packet(struct mwifiex_adapter *adapter)
> mwifiex_send_delba(priv, tid_del, ra, 1);
> }
> }
> - if (mwifiex_is_amsdu_allowed(priv, tid) &&
> + if (enable_tx_amsdu && mwifiex_is_amsdu_allowed(priv, tid) &&
> mwifiex_is_11n_aggragation_possible(priv, ptr,
> adapter->tx_buf_size))
> mwifiex_11n_aggregate_pkt(priv, ptr, INTF_HEADER_LEN,
> --
> 1.8.2.3
>
>

--
John W. Linville Someday the world will need a hero, and you
[email protected] might be all we have. Be ready.