2013-06-17 21:26:17

by Malcolm Priestley

Subject: [PATCH] staging: vt6656: mac.c MACvWriteMultiAddr: Remove secondary variable byData1

Signed-off-by: Malcolm Priestley <[email protected]>
---
drivers/staging/vt6656/mac.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/staging/vt6656/mac.c b/drivers/staging/vt6656/mac.c
index 87c7c8b..5e01be5 100644
--- a/drivers/staging/vt6656/mac.c
+++ b/drivers/staging/vt6656/mac.c
@@ -57,15 +57,13 @@ static int msglevel =MSG_LEVEL_INFO;
*/
void MACvWriteMultiAddr(struct vnt_private *pDevice, u32 uByteIdx, u8 byData)
{
- u8 byData1;

- byData1 = byData;
CONTROLnsRequestOut(pDevice,
MESSAGE_TYPE_WRITE,
(u16) (MAC_REG_MAR0 + uByteIdx),
MESSAGE_REQUEST_MACREG,
1,
- &byData1);
+ &byData);
}

/*
--
1.8.1.2

2013-06-17 21:55:09

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: vt6656: mac.c MACvWriteMultiAddr: Remove secondary variable byData1

On Mon, Jun 17, 2013 at 10:26:11PM +0100, Malcolm Priestley wrote:
>
> Signed-off-by: Malcolm Priestley <[email protected]>
> ---
> drivers/staging/vt6656/mac.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/staging/vt6656/mac.c b/drivers/staging/vt6656/mac.c
> index 87c7c8b..5e01be5 100644
> --- a/drivers/staging/vt6656/mac.c
> +++ b/drivers/staging/vt6656/mac.c
> @@ -57,15 +57,13 @@ static int msglevel =MSG_LEVEL_INFO;
> */
> void MACvWriteMultiAddr(struct vnt_private *pDevice, u32 uByteIdx, u8 byData)
> {
> - u8 byData1;
>
> - byData1 = byData;
> CONTROLnsRequestOut(pDevice,
> MESSAGE_TYPE_WRITE,
> (u16) (MAC_REG_MAR0 + uByteIdx),
> MESSAGE_REQUEST_MACREG,
> 1,
> - &byData1);
> + &byData);

Why are we passing byData in here at all? What is happening to it that
it needs to be a pointer, and why does this function need it as well?

Something doesn't seem right, care to track this down and fix it up
properly?

thanks,

greg k-h