2013-06-21 12:26:40

by Dan Carpenter

Subject: [patch] ipw2x00: printing the wrong array in debug code

Smatch complains that this is a read past the end of the array. It
turns out we are printing the wrong array here.

Signed-off-by: Dan Carpenter <[email protected]>

diff --git a/drivers/net/wireless/ipw2x00/libipw_rx.c b/drivers/net/wireless/ipw2x00/libipw_rx.c
index 95a1ca1..9ffe659 100644
--- a/drivers/net/wireless/ipw2x00/libipw_rx.c
+++ b/drivers/net/wireless/ipw2x00/libipw_rx.c
@@ -1195,7 +1195,7 @@ static int libipw_parse_info_param(struct libipw_info_element
#ifdef CONFIG_LIBIPW_DEBUG
p += snprintf(p, sizeof(rates_str) -
(p - rates_str), "%02X ",
- network->rates[i]);
+ network->rates_ex[i]);
#endif
if (libipw_is_ofdm_rate
(info_element->data[i])) {

2013-06-22 02:45:54

by Stanislav Yakovlev

Subject: Re: [patch] ipw2x00: printing the wrong array in debug code

Hi Dan,

On 21 June 2013 05:26, Dan Carpenter <[email protected]> wrote:
> Smatch complains that this is a read past the end of the array. It
> turns out we are printing the wrong array here.
>
> Signed-off-by: Dan Carpenter <[email protected]>
>

Looks fine, thanks.

Stanislav.