2013-09-05 03:52:12

by Dave Jones

Subject: [PATCH] Add missing braces to ath10k_pci_tx_pipe_cleanup

The indentation here implies this was meant to be a multi-statement if, but it lacks the braces.

Signed-off-by: Dave Jones <[email protected]>

diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c
index 33af467..31b69d3 100644
--- a/drivers/net/wireless/ath/ath10k/pci.c
+++ b/drivers/net/wireless/ath/ath10k/pci.c
@@ -1200,7 +1200,7 @@ static void ath10k_pci_tx_pipe_cleanup(struct hif_ce_pipe_info *pipe_info)

while (ath10k_ce_cancel_send_next(ce_hdl, (void **)&netbuf,
&ce_data, &nbytes, &id) == 0) {
- if (netbuf != CE_SENDLIST_ITEM_CTXT)
+ if (netbuf != CE_SENDLIST_ITEM_CTXT) {
/*
* Indicate the completion to higer layer to free
* the buffer
@@ -1209,6 +1209,7 @@ static void ath10k_pci_tx_pipe_cleanup(struct hif_ce_pipe_info *pipe_info)
ar_pci->msg_callbacks_current.tx_completion(ar,
netbuf,
id);
+ }
}
}

2013-09-06 09:32:52

by Kalle Valo

Subject: Re: [PATCH] Add missing braces to ath10k_pci_tx_pipe_cleanup

Dave Jones <[email protected]> writes:

> The indentation here implies this was meant to be a multi-statement
> if, but it lacks the braces.
>
> Signed-off-by: Dave Jones <[email protected]>

Thanks, applied.

I added "ath10k:" to the patch title.

--
Kalle Valo