2013-09-20 09:00:33

by Sachin Kamat

Subject: [PATCH 1/2] NFC: Remove redundant dev_set_drvdata

Driver core sets driver data to NULL upon failure or remove.

Signed-off-by: Sachin Kamat <[email protected]>
Cc: Ilan Elias <[email protected]>
---
Series compile tested.
---
drivers/nfc/nfcwilink.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/nfc/nfcwilink.c b/drivers/nfc/nfcwilink.c
index 59f95d8..9b1d91ee 100644
--- a/drivers/nfc/nfcwilink.c
+++ b/drivers/nfc/nfcwilink.c
@@ -578,8 +578,6 @@ static int nfcwilink_remove(struct platform_device *pdev)
nci_unregister_device(ndev);
nci_free_device(ndev);

- dev_set_drvdata(&pdev->dev, NULL);
-
return 0;
}

--
1.7.9.5

2013-09-20 09:00:36

by Sachin Kamat

Subject: [PATCH 2/2] NFC: pn533: Staticize local symbols

Local symbols used only in this file are made static.

Signed-off-by: Sachin Kamat <[email protected]>
---
drivers/nfc/pn533.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/nfc/pn533.c b/drivers/nfc/pn533.c
index 5df730b..9f12a75 100644
--- a/drivers/nfc/pn533.c
+++ b/drivers/nfc/pn533.c
@@ -2793,12 +2793,12 @@ static int pn533_rf_field(struct nfc_dev *nfc_dev, u8 rf)
return rc;
}

-int pn533_dev_up(struct nfc_dev *nfc_dev)
+static int pn533_dev_up(struct nfc_dev *nfc_dev)
{
return pn533_rf_field(nfc_dev, 1);
}

-int pn533_dev_down(struct nfc_dev *nfc_dev)
+static int pn533_dev_down(struct nfc_dev *nfc_dev)
{
return pn533_rf_field(nfc_dev, 0);
}
--
1.7.9.5

2013-09-20 15:31:29

by Samuel Ortiz

Subject: Re: [PATCH 2/2] NFC: pn533: Staticize local symbols

Hi Sachin,

On Fri, Sep 20, 2013 at 02:30:41PM +0530, Sachin Kamat wrote:
> Local symbols used only in this file are made static.
>
> Signed-off-by: Sachin Kamat <[email protected]>
> ---
> drivers/nfc/pn533.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied as well, thanks.

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/

2013-09-20 15:30:50

by Samuel Ortiz

Subject: Re: [PATCH 1/2] NFC: Remove redundant dev_set_drvdata

Hi Sachin,

On Fri, Sep 20, 2013 at 02:30:40PM +0530, Sachin Kamat wrote:
> Driver core sets driver data to NULL upon failure or remove.
>
> Signed-off-by: Sachin Kamat <[email protected]>
> Cc: Ilan Elias <[email protected]>
> ---
> Series compile tested.
> ---
> drivers/nfc/nfcwilink.c | 2 --
> 1 file changed, 2 deletions(-)
Applied, thanks.

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/