2013-10-24 07:33:51

by NeilBrown

[permalink] [raw]
Subject: [PATCH] libertas/sdio: make sure card enters power-off when firmware is loaded.



Since firmware loading became async it is possible that if_sdio_finish_power_of
is called with only one remaining runtime_pm reference, so it isn't safe
to call pm_runtime_put_noidle. We must call pm_runtime_put().

Diagnosed-by: "Dr. H. Nikolaus Schaller" <[email protected]>
Signed-off-by: NeilBrown <[email protected]>

diff --git a/drivers/net/wireless/libertas/if_sdio.c b/drivers/net/wireless/libertas/if_sdio.c
index 4557833..a39318b 100644
--- a/drivers/net/wireless/libertas/if_sdio.c
+++ b/drivers/net/wireless/libertas/if_sdio.c
@@ -853,7 +853,7 @@ static void if_sdio_finish_power_on(struct if_sdio_card *card)
card->started = true;
/* Tell PM core that we don't need the card to be
* powered now */
- pm_runtime_put_noidle(&func->dev);
+ pm_runtime_put(&func->dev);
}
}


Attachments:
signature.asc (828.00 B)