2013-10-26 19:20:57

by Georgiana Rodica Chelu

Subject: [Patch v3 1/3] net: wireless: replace printk with pr_warn in adm8211.c

WARNING: Prefer netdev_warn(netdev, ... then dev_warn(dev, ... then pr_warn(...
to printk(KERN_WARNING ...

Signed-off-by: Georgiana Rodica Chelu <[email protected]>
---
drivers/net/wireless/adm8211.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/adm8211.c b/drivers/net/wireless/adm8211.c
index f9a24e5..e36d54d 100644
--- a/drivers/net/wireless/adm8211.c
+++ b/drivers/net/wireless/adm8211.c
@@ -151,7 +151,7 @@ static int adm8211_read_eeprom(struct ieee80211_hw *dev)
else
priv->rf_type = ADM8211_TYPE_AIROHA;

- printk(KERN_WARNING "%s (adm8211): Unknown RFtype %d\n",
+ pr_warn("%s (adm8211): Unknown RFtype %d\n",
pci_name(priv->pdev), (cr49 >> 3) & 0x7);
}

--
1.8.1.2

2013-10-28 21:30:17

by Greg Kroah-Hartman

Subject: Re: [OPW kernel] [Patch v3 1/3] net: wireless: replace printk with pr_warn in adm8211.c

On Sat, Oct 26, 2013 at 10:20:53PM +0300, Georgiana Rodica Chelu wrote:
> WARNING: Prefer netdev_warn(netdev, ... then dev_warn(dev, ... then pr_warn(...
> to printk(KERN_WARNING ...
>
> Signed-off-by: Georgiana Rodica Chelu <[email protected]>
> ---
> drivers/net/wireless/adm8211.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Like Sarah said, we can't take these as they are not against the staging
tree.

And even if they were:

> diff --git a/drivers/net/wireless/adm8211.c b/drivers/net/wireless/adm8211.c
> index f9a24e5..e36d54d 100644
> --- a/drivers/net/wireless/adm8211.c
> +++ b/drivers/net/wireless/adm8211.c
> @@ -151,7 +151,7 @@ static int adm8211_read_eeprom(struct ieee80211_hw *dev)
> else
> priv->rf_type = ADM8211_TYPE_AIROHA;
>
> - printk(KERN_WARNING "%s (adm8211): Unknown RFtype %d\n",
> + pr_warn("%s (adm8211): Unknown RFtype %d\n",

You didn't read the message that sparse was telling you, why didn't you
convert this to netdev_warn() instead?

thanks,

greg k-h