2013-10-30 17:09:39

by Arik Nemtsov

Subject: [PATCH] nl80211: better document NL80211_CMD_TDLS_MGMT

This command has different semantics depending on the action code sent.
Document this fact and detail the supported action codes.

Signed-off-by: Arik Nemtsov <[email protected]>
---
include/uapi/linux/nl80211.h | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/include/uapi/linux/nl80211.h b/include/uapi/linux/nl80211.h
index f752e98..877c048 100644
--- a/include/uapi/linux/nl80211.h
+++ b/include/uapi/linux/nl80211.h
@@ -581,7 +581,14 @@
* operation, %NL80211_ATTR_MAC contains the peer MAC address, and
* %NL80211_ATTR_REASON_CODE the reason code to be used (only with
* %NL80211_TDLS_TEARDOWN).
- * @NL80211_CMD_TDLS_MGMT: Send a TDLS management frame.
+ * @NL80211_CMD_TDLS_MGMT: Send a TDLS management frame. The
+ * %NL80211_ATTR_TDLS_ACTION attribute determines the typ of frame to be
+ * sent. Public Action codes (802.11-2012 8.1.5.1) will be sent as
+ * 802.11 management frames, while TDLS action codes (802.11-2012
+ * 8.5.13.1) will be encapsulated and sent as data frames. The currently
+ * supported Public Action code is %WLAN_PUB_ACTION_TDLS_DISCOVER_RES
+ * and the currently supported TDLS actions codes are given in
+ * &enum ieee80211_tdls_actioncode.
*
* @NL80211_CMD_UNEXPECTED_FRAME: Used by an application controlling an AP
* (or GO) interface (i.e. hostapd) to ask for unexpected frames to
--
1.8.1.2

2013-10-30 18:45:05

by Bob Copeland

Subject: Re: [PATCH] nl80211: better document NL80211_CMD_TDLS_MGMT

On Wed, Oct 30, 2013 at 07:09:34PM +0200, Arik Nemtsov wrote:
> + * @NL80211_CMD_TDLS_MGMT: Send a TDLS management frame. The
> + * %NL80211_ATTR_TDLS_ACTION attribute determines the typ of frame to be

type typo there.

> + * sent. Public Action codes (802.11-2012 8.1.5.1) will be sent as
> + * 802.11 management frames, while TDLS action codes (802.11-2012

--
Bob Copeland %% http://www.bobcopeland.com

2013-10-31 12:53:53

by Arik Nemtsov

Subject: Re: [PATCH] nl80211: better document NL80211_CMD_TDLS_MGMT

On Wed, Oct 30, 2013 at 8:43 PM, Bob Copeland <[email protected]> wrote:
>
> On Wed, Oct 30, 2013 at 07:09:34PM +0200, Arik Nemtsov wrote:
> > + * @NL80211_CMD_TDLS_MGMT: Send a TDLS management frame. The
> > + * %NL80211_ATTR_TDLS_ACTION attribute determines the typ of frame to be
>
> type typo there.

Thanks.