2013-12-19 08:54:16

by Rashika Kheria

Subject: [PATCH v3 5/8] drivers: net: Mark functions as static in 3945-debug.c

This patch marks the function il3945_ucode_rx_stats_read(),
il3945_ucode_tx_stats_read() and il3945_ucode_general_stats_read() in
3945-debug.c as static because they are not used outside this file.

Thus, it also removes the following warnings in
wireless/iwlegacy/3945-debug.c:

drivers/net/wireless/iwlegacy/3945-debug.c:52:1: warning: no previous prototype for ‘il3945_ucode_rx_stats_read’ [-Wmissing-prototypes]
drivers/net/wireless/iwlegacy/3945-debug.c:317:1: warning: no previous prototype for ‘il3945_ucode_tx_stats_read’ [-Wmissing-prototypes]
drivers/net/wireless/iwlegacy/3945-debug.c:407:1: warning: no previous prototype for ‘il3945_ucode_general_stats_read’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <[email protected]>
Reviewed-by: Josh Triplett <[email protected]>
---
drivers/net/wireless/iwlegacy/3945-debug.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/iwlegacy/3945-debug.c b/drivers/net/wireless/iwlegacy/3945-debug.c
index f767dd1..c1b4441 100644
--- a/drivers/net/wireless/iwlegacy/3945-debug.c
+++ b/drivers/net/wireless/iwlegacy/3945-debug.c
@@ -48,7 +48,7 @@ il3945_stats_flag(struct il_priv *il, char *buf, int bufsz)
return p;
}

-ssize_t
+static ssize_t
il3945_ucode_rx_stats_read(struct file *file, char __user *user_buf,
size_t count, loff_t *ppos)
{
@@ -313,7 +313,7 @@ il3945_ucode_rx_stats_read(struct file *file, char __user *user_buf,
return ret;
}

-ssize_t
+static ssize_t
il3945_ucode_tx_stats_read(struct file *file, char __user *user_buf,
size_t count, loff_t *ppos)
{
@@ -403,7 +403,7 @@ il3945_ucode_tx_stats_read(struct file *file, char __user *user_buf,
return ret;
}

-ssize_t
+static ssize_t
il3945_ucode_general_stats_read(struct file *file, char __user *user_buf,
size_t count, loff_t *ppos)
{
--
1.7.9.5

2013-12-19 23:52:25

by David Miller

Subject: Re: [PATCH v3 5/8] drivers: net: Mark functions as static in 3945-debug.c

RnJvbTogUmFzaGlrYSBLaGVyaWEgPHJhc2hpa2Eua2hlcmlhQGdtYWlsLmNvbT4NCkRhdGU6IFRo
dSwgMTkgRGVjIDIwMTMgMTQ6MjM6NDkgKzA1MzANCg0KPiBUaGlzIHBhdGNoIG1hcmtzIHRoZSBm
dW5jdGlvbiBpbDM5NDVfdWNvZGVfcnhfc3RhdHNfcmVhZCgpLA0KPiBpbDM5NDVfdWNvZGVfdHhf
c3RhdHNfcmVhZCgpIGFuZCBpbDM5NDVfdWNvZGVfZ2VuZXJhbF9zdGF0c19yZWFkKCkgaW4NCj4g
Mzk0NS1kZWJ1Zy5jIGFzIHN0YXRpYyBiZWNhdXNlIHRoZXkgYXJlIG5vdCB1c2VkIG91dHNpZGUg
dGhpcyBmaWxlLg0KPiANCj4gVGh1cywgaXQgYWxzbyByZW1vdmVzIHRoZSBmb2xsb3dpbmcgd2Fy
bmluZ3MgaW4NCj4gd2lyZWxlc3MvaXdsZWdhY3kvMzk0NS1kZWJ1Zy5jOg0KPiANCj4gZHJpdmVy
cy9uZXQvd2lyZWxlc3MvaXdsZWdhY3kvMzk0NS1kZWJ1Zy5jOjUyOjE6IHdhcm5pbmc6IG5vIHBy
ZXZpb3VzIHByb3RvdHlwZSBmb3IgoWlsMzk0NV91Y29kZV9yeF9zdGF0c19yZWFkoiBbLVdtaXNz
aW5nLXByb3RvdHlwZXNdDQo+IGRyaXZlcnMvbmV0L3dpcmVsZXNzL2l3bGVnYWN5LzM5NDUtZGVi
dWcuYzozMTc6MTogd2FybmluZzogbm8gcHJldmlvdXMgcHJvdG90eXBlIGZvciChaWwzOTQ1X3Vj
b2RlX3R4X3N0YXRzX3JlYWSiIFstV21pc3NpbmctcHJvdG90eXBlc10NCj4gZHJpdmVycy9uZXQv
d2lyZWxlc3MvaXdsZWdhY3kvMzk0NS1kZWJ1Zy5jOjQwNzoxOiB3YXJuaW5nOiBubyBwcmV2aW91
cyBwcm90b3R5cGUgZm9yIKFpbDM5NDVfdWNvZGVfZ2VuZXJhbF9zdGF0c19yZWFkoiBbLVdtaXNz
aW5nLXByb3RvdHlwZXNdDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBSYXNoaWthIEtoZXJpYSA8cmFz
aGlrYS5raGVyaWFAZ21haWwuY29tPg0KPiBSZXZpZXdlZC1ieTogSm9zaCBUcmlwbGV0dCA8am9z
aEBqb3NodHJpcGxldHQub3JnPg0KDQpBcHBsaWVkLg0K