2014-02-19 10:51:24

by Yogesh Ashok Powar

Subject: [PATCH 1/3] mwl8k: Adding support to access BBP registers

Adding AP firmware command to access BBP
regs. This will be used for retrieving
different counters CCA/RX needed for ACS

Signed-off-by: Yogesh Ashok Powar <[email protected]>
Signed-off-by: Nishant Sarmukadam <[email protected]>
---
drivers/net/wireless/mwl8k.c | 40 ++++++++++++++++++++++++++++++++++++++++
1 file changed, 40 insertions(+)

diff --git a/drivers/net/wireless/mwl8k.c b/drivers/net/wireless/mwl8k.c
index 4987c3f..159125e 100644
--- a/drivers/net/wireless/mwl8k.c
+++ b/drivers/net/wireless/mwl8k.c
@@ -396,6 +396,7 @@ static const struct ieee80211_rate mwl8k_rates_50[] = {
#define MWL8K_CMD_SET_HW_SPEC 0x0004
#define MWL8K_CMD_MAC_MULTICAST_ADR 0x0010
#define MWL8K_CMD_GET_STAT 0x0014
+#define MWL8K_CMD_BBP_REG_ACCESS 0x001a
#define MWL8K_CMD_RADIO_CONTROL 0x001c
#define MWL8K_CMD_RF_TX_POWER 0x001e
#define MWL8K_CMD_TX_POWER 0x001f
@@ -2987,6 +2988,45 @@ static int mwl8k_cmd_set_pre_scan(struct ieee80211_hw *hw)
}

/*
+ * CMD_BBP_REG_ACCESS.
+ */
+struct mwl8k_cmd_bbp_reg_access {
+ struct mwl8k_cmd_pkt header;
+ __le16 action;
+ __le16 offset;
+ u8 value;
+ u8 rsrv[3];
+} __packed;
+
+static int
+mwl8k_cmd_bbp_reg_access(struct ieee80211_hw *hw,
+ u16 action,
+ u16 offset,
+ u8 *value)
+{
+ struct mwl8k_cmd_bbp_reg_access *cmd;
+ int rc;
+
+ cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
+ if (cmd == NULL)
+ return -ENOMEM;
+
+ cmd->header.code = cpu_to_le16(MWL8K_CMD_BBP_REG_ACCESS);
+ cmd->header.length = cpu_to_le16(sizeof(*cmd));
+ cmd->action = cpu_to_le16(action);
+ cmd->offset = cpu_to_le16(offset);
+
+ rc = mwl8k_post_cmd(hw, &cmd->header);
+
+ if (!rc)
+ *value = cmd->value;
+ else
+ *value = 0;
+
+ return rc;
+}
+
+/*
* CMD_SET_POST_SCAN.
*/
struct mwl8k_cmd_set_post_scan {
--
1.8.3.4

2014-02-19 12:13:28

by Jonas Gorski

Subject: Re: [PATCH 1/3] mwl8k: Adding support to access BBP registers

On Wed, Feb 19, 2014 at 11:37 AM, Yogesh Ashok Powar
<[email protected]> wrote:
> Adding AP firmware command to access BBP
> regs. This will be used for retrieving
> different counters CCA/RX needed for ACS
>
> Signed-off-by: Yogesh Ashok Powar <[email protected]>
> Signed-off-by: Nishant Sarmukadam <[email protected]>
> ---
> drivers/net/wireless/mwl8k.c | 40 ++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 40 insertions(+)
>
> diff --git a/drivers/net/wireless/mwl8k.c b/drivers/net/wireless/mwl8k.c
> index 4987c3f..159125e 100644
> --- a/drivers/net/wireless/mwl8k.c
> +++ b/drivers/net/wireless/mwl8k.c
> @@ -2987,6 +2988,45 @@ static int mwl8k_cmd_set_pre_scan(struct ieee80211_hw *hw)
> }
>
> /*
> + * CMD_BBP_REG_ACCESS.
> + */
> +struct mwl8k_cmd_bbp_reg_access {
> + struct mwl8k_cmd_pkt header;
> + __le16 action;
> + __le16 offset;
> + u8 value;
> + u8 rsrv[3];
> +} __packed;
> +
> +static int
> +mwl8k_cmd_bbp_reg_access(struct ieee80211_hw *hw,
> + u16 action,
> + u16 offset,
> + u8 *value)
> +{
> + struct mwl8k_cmd_bbp_reg_access *cmd;
> + int rc;
> +
> + cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
> + if (cmd == NULL)
> + return -ENOMEM;
> +
> + cmd->header.code = cpu_to_le16(MWL8K_CMD_BBP_REG_ACCESS);
> + cmd->header.length = cpu_to_le16(sizeof(*cmd));
> + cmd->action = cpu_to_le16(action);
> + cmd->offset = cpu_to_le16(offset);
> +
> + rc = mwl8k_post_cmd(hw, &cmd->header);
> +
> + if (!rc)
> + *value = cmd->value;
> + else
> + *value = 0;
> +
> + return rc;

You don't free the allocated cmd anywhere, so you are leaking memory
on every call.


Regards
Jonas

2014-02-19 12:18:39

by Yogesh Ashok Powar

Subject: Re: [PATCH 1/3] mwl8k: Adding support to access BBP registers

Hi Jonas,

On Wed, Feb 19, 2014 at 04:12:56AM -0800, Jonas Gorski wrote:
> > + cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
> > + if (cmd == NULL)
> > + return -ENOMEM;
> > +
> > + cmd->header.code = cpu_to_le16(MWL8K_CMD_BBP_REG_ACCESS);
> > + cmd->header.length = cpu_to_le16(sizeof(*cmd));
> > + cmd->action = cpu_to_le16(action);
> > + cmd->offset = cpu_to_le16(offset);
> > +
> > + rc = mwl8k_post_cmd(hw, &cmd->header);
> > +
> > + if (!rc)
> > + *value = cmd->value;
> > + else
> > + *value = 0;
> > +
> > + return rc;
>
> You don't free the allocated cmd anywhere, so you are leaking memory
> on every call.

We will fix this in V2.

Thanks
Yogesh

>
>
> Regards
> Jonas