> >
> > On Tue, Mar 04, 2014 at 04:50:14PM +0200, Emmanuel Grumbach wrote:
> > > This logic is already implemented in ieee80211_rx_mgmt_beacon.
> > > The purpose is to ignore probe responses that are received on
> > > adjacent channels. This can happen in 2.4GHz since channels overlap.
> >
> > Why would this be done? I can understand not updating signal
> > information, but dropping Probe Response frames completely sounds
> quite undesirable.
> > These can be used to help optimize partial scans and any additional
> > information that can be used without having to change channels sounds
> > helpful to me.
> >
>
> So I guess you want me to revert the code we currently have in
> ieee80211_rx_mgmt_beacon ;) Don't know really... If you are associated to
> an AP and hear its beacons / probe responses on another channel you really
> have a big problem in your radio?
FWIW: this logic is there since:
commit d91f36db51661018f6d54ff5966e283bcec4c545
Author: Johannes Berg <[email protected]>
Date: Thu Apr 16 13:17:26 2009 +0200
mac80211: implement beacon filtering in software
>
> On Wed, Mar 05, 2014 at 09:20:07AM +0000, Grumbach, Emmanuel wrote:
> > > So I guess you want me to revert the code we currently have in
> > > ieee80211_rx_mgmt_beacon ;) Don't know really... If you are
> > > associated to an AP and hear its beacons / probe responses on
> > > another channel you really have a big problem in your radio?
> >
> > FWIW: this logic is there since:
> >
> > commit d91f36db51661018f6d54ff5966e283bcec4c545
> > Author: Johannes Berg <[email protected]>
> > Date: Thu Apr 16 13:17:26 2009 +0200
> >
> > mac80211: implement beacon filtering in software
>
> The frequency related areas in this commit are in a location that has a clear
> comment about it being for the current BSS. Your patch did not look like it
> would be for that case. If it is, the commit log should really say that clearly.
>
V2 with a better commit log on the way - thanks!
On Wed, Mar 05, 2014 at 09:20:07AM +0000, Grumbach, Emmanuel wrote:
> > So I guess you want me to revert the code we currently have in
> > ieee80211_rx_mgmt_beacon ;) Don't know really... If you are associated to
> > an AP and hear its beacons / probe responses on another channel you really
> > have a big problem in your radio?
>
> FWIW: this logic is there since:
>
> commit d91f36db51661018f6d54ff5966e283bcec4c545
> Author: Johannes Berg <[email protected]>
> Date: Thu Apr 16 13:17:26 2009 +0200
>
> mac80211: implement beacon filtering in software
The frequency related areas in this commit are in a location that has a
clear comment about it being for the current BSS. Your patch did not
look like it would be for that case. If it is, the commit log should
really say that clearly.
--
Jouni Malinen PGP id EFC895FA