2014-08-15 10:31:40

by Tony Vroon

Subject: [PATCH] iwlwifi: Correctly deal with monolithic kernels

Post 3.16 any non-modular kernel ends up with IWLWIFI selectable but neither of the
underlying required DVM or MVM drivers. This violates the principle of least
astonishment.
If IWLWIFI only supports a modular system the main IWLWIFI should depend on m as well.
Otherwise, removing the "depends on m" allows monolithic kernels to work once again.

Signed-off-by: Tony Vroon <[email protected]>

diff --git a/drivers/net/wireless/iwlwifi/Kconfig b/drivers/net/wireless/iwlwifi/Kconfig
index 6451d2b..824f5e2 100644
--- a/drivers/net/wireless/iwlwifi/Kconfig
+++ b/drivers/net/wireless/iwlwifi/Kconfig
@@ -51,7 +51,6 @@ config IWLWIFI_LEDS

config IWLDVM
tristate "Intel Wireless WiFi DVM Firmware support"
- depends on m
default IWLWIFI
help
This is the driver that supports the DVM firmware which is
@@ -60,7 +59,6 @@ config IWLDVM

config IWLMVM
tristate "Intel Wireless WiFi MVM Firmware support"
- depends on m
help
This is the driver that supports the MVM firmware which is
currently only available for 7260 and 3160 devices.

2014-08-17 03:18:07

by Emmanuel Grumbach

Subject: Re: [PATCH] iwlwifi: Correctly deal with monolithic kernels

On Fri, Aug 15, 2014 at 6:23 AM, Tony Vroon <[email protected]> wrote:
> Post 3.16 any non-modular kernel ends up with IWLWIFI selectable but neither of the
> underlying required DVM or MVM drivers. This violates the principle of least
> astonishment.
> If IWLWIFI only supports a modular system the main IWLWIFI should depend on m as well.
> Otherwise, removing the "depends on m" allows monolithic kernels to work once again.
>
> Signed-off-by: Tony Vroon <[email protected]>
>

Someone else posted the exact same patch. thanks.