2014-12-16 09:13:38

by Asaf Vertz

Subject: [PATCH] staging: rtl8723au: core: fixing "foo * bar" should be "foo *bar"

Fixed a coding style error, "foo * bar" should be "foo *bar"

Signed-off-by: Asaf Vertz <[email protected]>
---
drivers/staging/rtl8723au/core/rtw_efuse.c | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/rtl8723au/core/rtw_efuse.c b/drivers/staging/rtl8723au/core/rtw_efuse.c
index 81960e7..0e64d12 100644
--- a/drivers/staging/rtl8723au/core/rtw_efuse.c
+++ b/drivers/staging/rtl8723au/core/rtw_efuse.c
@@ -328,12 +328,12 @@ EFUSE_Read1Byte23a(struct rtw_adapter *Adapter, u16 Address)

void
EFUSE_Write1Byte(
- struct rtw_adapter * Adapter,
+ struct rtw_adapter *Adapter,
u16 Address,
u8 Value);
void
EFUSE_Write1Byte(
- struct rtw_adapter * Adapter,
+ struct rtw_adapter *Adapter,
u16 Address,
u8 Value)
{
@@ -636,7 +636,7 @@ Efuse_ReadAllMap(struct rtw_adapter *pAdapter, u8 efuseType, u8 *Efuse)
*---------------------------------------------------------------------------*/
static void
efuse_ShadowRead1Byte(
- struct rtw_adapter * pAdapter,
+ struct rtw_adapter *pAdapter,
u16 Offset,
u8 *Value)
{
@@ -648,7 +648,7 @@ efuse_ShadowRead1Byte(
/* Read Two Bytes */
static void
efuse_ShadowRead2Byte(
- struct rtw_adapter * pAdapter,
+ struct rtw_adapter *pAdapter,
u16 Offset,
u16 *Value)
{
@@ -661,7 +661,7 @@ efuse_ShadowRead2Byte(
/* Read Four Bytes */
static void
efuse_ShadowRead4Byte(
- struct rtw_adapter * pAdapter,
+ struct rtw_adapter *pAdapter,
u16 Offset,
u32 *Value)
{
@@ -723,7 +723,7 @@ void EFUSE_ShadowMapUpdate23a(struct rtw_adapter *pAdapter, u8 efuseType)
*---------------------------------------------------------------------------*/
void
EFUSE_ShadowRead23a(
- struct rtw_adapter * pAdapter,
+ struct rtw_adapter *pAdapter,
u8 Type,
u16 Offset,
u32 *Value)
--
1.7.0.4

2014-12-16 12:43:55

by Jes Sorensen

Subject: Re: [PATCH] staging: rtl8723au: core: fixing "foo * bar" should be "foo *bar"

Asaf Vertz <[email protected]> writes:
> Fixed a coding style error, "foo * bar" should be "foo *bar"
>
> Signed-off-by: Asaf Vertz <[email protected]>
> ---
> drivers/staging/rtl8723au/core/rtw_efuse.c | 12 ++++++------
> 1 files changed, 6 insertions(+), 6 deletions(-)

If you want to fix the 'error' here, include it with a cleanup that also
fixes the ugly multiline arguments to the functions.

Jes

> diff --git a/drivers/staging/rtl8723au/core/rtw_efuse.c b/drivers/staging/rtl8723au/core/rtw_efuse.c
> index 81960e7..0e64d12 100644
> --- a/drivers/staging/rtl8723au/core/rtw_efuse.c
> +++ b/drivers/staging/rtl8723au/core/rtw_efuse.c
> @@ -328,12 +328,12 @@ EFUSE_Read1Byte23a(struct rtw_adapter *Adapter, u16 Address)
>
> void
> EFUSE_Write1Byte(
> - struct rtw_adapter * Adapter,
> + struct rtw_adapter *Adapter,
> u16 Address,
> u8 Value);
> void
> EFUSE_Write1Byte(
> - struct rtw_adapter * Adapter,
> + struct rtw_adapter *Adapter,
> u16 Address,
> u8 Value)
> {
> @@ -636,7 +636,7 @@ Efuse_ReadAllMap(struct rtw_adapter *pAdapter, u8 efuseType, u8 *Efuse)
> *---------------------------------------------------------------------------*/
> static void
> efuse_ShadowRead1Byte(
> - struct rtw_adapter * pAdapter,
> + struct rtw_adapter *pAdapter,
> u16 Offset,
> u8 *Value)
> {
> @@ -648,7 +648,7 @@ efuse_ShadowRead1Byte(
> /* Read Two Bytes */
> static void
> efuse_ShadowRead2Byte(
> - struct rtw_adapter * pAdapter,
> + struct rtw_adapter *pAdapter,
> u16 Offset,
> u16 *Value)
> {
> @@ -661,7 +661,7 @@ efuse_ShadowRead2Byte(
> /* Read Four Bytes */
> static void
> efuse_ShadowRead4Byte(
> - struct rtw_adapter * pAdapter,
> + struct rtw_adapter *pAdapter,
> u16 Offset,
> u32 *Value)
> {
> @@ -723,7 +723,7 @@ void EFUSE_ShadowMapUpdate23a(struct rtw_adapter *pAdapter, u8 efuseType)
> *---------------------------------------------------------------------------*/
> void
> EFUSE_ShadowRead23a(
> - struct rtw_adapter * pAdapter,
> + struct rtw_adapter *pAdapter,
> u8 Type,
> u16 Offset,
> u32 *Value)