2015-02-25 11:16:07

by Avinash Patil

[permalink] [raw]
Subject: [PATCH] mwifiex: do not initialize ext_scan in mwifiex_init_adapter

Features which are device specific are already updated in
interface specific initialization e.g. register_dev.
We should not initialize them in mwifiex_init_adapter();
else this would overwrite earlier settings.

Signed-off-by: Avinash Patil <[email protected]>
Signed-off-by: Amitkumar Karwar <[email protected]>
---
drivers/net/wireless/mwifiex/init.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/net/wireless/mwifiex/init.c b/drivers/net/wireless/mwifiex/init.c
index b77ba74..2e1df02 100644
--- a/drivers/net/wireless/mwifiex/init.c
+++ b/drivers/net/wireless/mwifiex/init.c
@@ -296,7 +296,6 @@ static void mwifiex_init_adapter(struct mwifiex_adapter *adapter)
memset(&adapter->arp_filter, 0, sizeof(adapter->arp_filter));
adapter->arp_filter_size = 0;
adapter->max_mgmt_ie_index = MAX_MGMT_IE_INDEX;
- adapter->ext_scan = false;
adapter->key_api_major_ver = 0;
adapter->key_api_minor_ver = 0;
memset(adapter->perm_addr, 0xff, ETH_ALEN);
--
1.8.1.4



2015-03-03 13:44:01

by Kalle Valo

[permalink] [raw]
Subject: Re: mwifiex: do not initialize ext_scan in mwifiex_init_adapter


> Features which are device specific are already updated in
> interface specific initialization e.g. register_dev.
> We should not initialize them in mwifiex_init_adapter();
> else this would overwrite earlier settings.
>
> Signed-off-by: Avinash Patil <[email protected]>
> Signed-off-by: Amitkumar Karwar <[email protected]>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo