2015-05-14 08:57:53

by Avinash Patil

[permalink] [raw]
Subject: [PATCH] mwifiex: reduce severity of debug messages for mgmt rx

This would ensure dmesg logs are not spammed with "unknown mgmt frame
subtype" messages.

Signed-off-by: Avinash Patil <[email protected]>
---
drivers/net/wireless/mwifiex/util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/mwifiex/util.c b/drivers/net/wireless/mwifiex/util.c
index 3c0b3c1..fd8ef3c 100644
--- a/drivers/net/wireless/mwifiex/util.c
+++ b/drivers/net/wireless/mwifiex/util.c
@@ -350,7 +350,7 @@ mwifiex_parse_mgmt_packet(struct mwifiex_private *priv, u8 *payload, u16 len,
}
break;
default:
- mwifiex_dbg(priv->adapter, ERROR,
+ mwifiex_dbg(priv->adapter, INFO,
"unknown mgmt frame subytpe %#x\n", stype);
}

--
1.8.1.4



2015-05-14 12:33:29

by James Cameron

[permalink] [raw]
Subject: Re: [PATCH] mwifiex: reduce severity of debug messages for mgmt rx

On Thu, May 14, 2015 at 07:57:31PM +0530, Avinash Patil wrote:
> This would ensure dmesg logs are not spammed with "unknown mgmt frame
> subtype" messages.

"subtype"

>
> Signed-off-by: Avinash Patil <[email protected]>
> ---
> drivers/net/wireless/mwifiex/util.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/mwifiex/util.c b/drivers/net/wireless/mwifiex/util.c
> index 3c0b3c1..fd8ef3c 100644
> --- a/drivers/net/wireless/mwifiex/util.c
> +++ b/drivers/net/wireless/mwifiex/util.c
> @@ -350,7 +350,7 @@ mwifiex_parse_mgmt_packet(struct mwifiex_private *priv, u8 *payload, u16 len,
> }
> break;
> default:
> - mwifiex_dbg(priv->adapter, ERROR,
> + mwifiex_dbg(priv->adapter, INFO,
> "unknown mgmt frame subytpe %#x\n", stype);

"subytpe" != "subtype"

An opportunity there. ;-)

--
James Cameron
http://quozl.linux.org.au/