2015-10-27 17:21:58

by punit vara

Subject: [PATCH v2] Staging: wilc1000: Prefer eth_broadcast_addr over memset()

This patch is to the host_interface.c that fixes up following
warning by checkpatch:

-prefer eth_broadcast_addr() over memset()

Signed-off-by: Punit Vara <[email protected]>
---
drivers/staging/wilc1000/host_interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index 5f81eab..53e21cd 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -4642,7 +4642,7 @@ s32 host_int_del_station(struct host_if_drv *hif_drv, const u8 *pu8MacAddr)
msg.drv = hif_drv;

if (!pu8MacAddr)
- memset(pstrDelStationMsg->mac_addr, 255, ETH_ALEN);
+ eth_broadcast_addr(pstrDelStationMsg->mac_addr);
else
memcpy(pstrDelStationMsg->mac_addr, pu8MacAddr, ETH_ALEN);

--
2.5.3

2015-10-27 19:40:54

by Greg Kroah-Hartman

Subject: Re: [PATCH v2] Staging: wilc1000: Prefer eth_broadcast_addr over memset()

On Tue, Oct 27, 2015 at 10:51:39PM +0530, Punit Vara wrote:
> This patch is to the host_interface.c that fixes up following
> warning by checkpatch:
>
> -prefer eth_broadcast_addr() over memset()
>
> Signed-off-by: Punit Vara <[email protected]>
> ---
> drivers/staging/wilc1000/host_interface.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

What changed from v1?

Always put that information here below the --- line so that we know.

Please fix up and resend.

thanks,

greg k-h