2015-11-06 10:30:51

by Johannes Berg

Subject: [PATCH] mac80211: mesh: print MAC address instead of pointer

From: Johannes Berg <[email protected]>

There's no point in printing the mpath pointer since it can't
be used for anything - print the MAC address instead (like in
the forwarding case.)

Signed-off-by: Johannes Berg <[email protected]>
---
net/mac80211/mesh_pathtbl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/mac80211/mesh_pathtbl.c b/net/mac80211/mesh_pathtbl.c
index b890e225a8f1..778fdfc7f14a 100644
--- a/net/mac80211/mesh_pathtbl.c
+++ b/net/mac80211/mesh_pathtbl.c
@@ -968,8 +968,8 @@ int mesh_path_send_to_gates(struct mesh_path *mpath)
copy = true;
} else {
mpath_dbg(sdata,
- "Not forwarding %p (flags %#x)\n",
- gate->mpath, gate->mpath->flags);
+ "Not forwarding to %pM (flags %#x)\n",
+ gate->mpath->dst, gate->mpath->flags);
}
}

--
2.6.2

2015-11-08 23:53:35

by Bob Copeland

Subject: Re: [PATCH] mac80211: mesh: print MAC address instead of pointer

On Fri, Nov 06, 2015 at 11:30:46AM +0100, Johannes Berg wrote:
> From: Johannes Berg <[email protected]>
>
> There's no point in printing the mpath pointer since it can't
> be used for anything - print the MAC address instead (like in
> the forwarding case.)
>
> Signed-off-by: Johannes Berg <[email protected]>

FWIW:

Acked-by: Bob Copeland <[email protected]>

> mpath_dbg(sdata,
> - "Not forwarding %p (flags %#x)\n",
> - gate->mpath, gate->mpath->flags);
> + "Not forwarding to %pM (flags %#x)\n",
> + gate->mpath->dst, gate->mpath->flags);

--
Bob Copeland %% http://bobcopeland.com/