Hi Dave,
I have some important fixes I would like to get 4.5 still, more info in
the signed tag. Please let me know if you have problems.
Kalle
The following changes since commit f9ead9beef3f44be0db4b542a8c2ce698fb1530e:
Merge tag 'iwlwifi-for-kalle-2016-01-26_2' of https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-fixes (2016-01-27 14:19:18 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git tags/wireless-drivers-for-davem-2016-02-18
for you to fetch changes up to c699404db182836498bd9d9a36ef044de2cab4fd:
Merge tag 'iwlwifi-for-kalle-2016-02-15' of https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-fixes (2016-02-16 17:58:30 +0200)
----------------------------------------------------------------
rtlwifi
* fix broken VHT (802.11ac) support, reported by Linus
wlcore
* fix firmware initialisation regression on wl1271
iwlwifi
* fix a race that users reported when we try to load the firmware
and the hardware rfkill interrupt triggers at the same time
* fix a very visible bug in scheduled scan: the firmware
doesn't support scheduled scan with no profile configured and
the supplicant sometimes requests such scheduled scans
* build system fix to be able to link iwlwifi statically into kernel
* firmware name update for 8265
* typo fix in return value
----------------------------------------------------------------
Anton Protopopov (1):
iwlwifi: pcie: fix erroneous return value
Emil Goode (1):
wlcore: Fix regression in wlcore_set_partition()
Emmanuel Grumbach (2):
iwlwifi: dvm: remove a wrong dependency on m
iwlwifi: pcie: fix RF-Kill vs. firmware load race
Kalle Valo (1):
Merge tag 'iwlwifi-for-kalle-2016-02-15' of https://git.kernel.org/.../iwlwifi/iwlwifi-fixes
Larry Finger (1):
rtlwifi: fix broken VHT support
Luca Coelho (1):
iwlwifi: mvm: don't allow sched scans without matches to be started
Oren Givon (1):
iwlwifi: fix name of ucode loaded for 8265 series
drivers/net/wireless/intel/iwlwifi/Kconfig | 1 -
drivers/net/wireless/intel/iwlwifi/iwl-8000.c | 42 ++++-
drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 6 +-
drivers/net/wireless/intel/iwlwifi/mvm/scan.c | 4 +
drivers/net/wireless/intel/iwlwifi/pcie/internal.h | 9 +
drivers/net/wireless/intel/iwlwifi/pcie/rx.c | 8 +-
drivers/net/wireless/intel/iwlwifi/pcie/trans.c | 188 ++++++++++++--------
drivers/net/wireless/realtek/rtlwifi/rc.c | 5 +
drivers/net/wireless/ti/wlcore/io.c | 8 +-
drivers/net/wireless/ti/wlcore/io.h | 4 +-
10 files changed, 175 insertions(+), 100 deletions(-)
--
Kalle Valo
From: Kalle Valo <[email protected]>
Date: Thu, 18 Feb 2016 17:28:14 +0200
> I have some important fixes I would like to get 4.5 still, more info in
> the signed tag. Please let me know if you have problems.
Pulled, thanks.
On Thu, Feb 18, 2016 at 4:28 PM, Kalle Valo <[email protected]> wrote:
> Hi Dave,
>
> I have some important fixes I would like to get 4.5 still, more info in
> the signed tag. Please let me know if you have problems.
>
> Kalle
>
> The following changes since commit f9ead9beef3f44be0db4b542a8c2ce698fb1530e:
>
> Merge tag 'iwlwifi-for-kalle-2016-01-26_2' of https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-fixes (2016-01-27 14:19:18 +0200)
>
> are available in the git repository at:
>
>
> git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git tags/wireless-drivers-for-davem-2016-02-18
>
> for you to fetch changes up to c699404db182836498bd9d9a36ef044de2cab4fd:
>
> Merge tag 'iwlwifi-for-kalle-2016-02-15' of https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-fixes (2016-02-16 17:58:30 +0200)
>
> ----------------------------------------------------------------
>
> rtlwifi
>
> * fix broken VHT (802.11ac) support, reported by Linus
That's commit d76d65fd26951498144029c24852c4d54ee512d9
drivers/net/wireless/realtek/rtlwifi/rc.c: In function
‘_rtl_rc_rate_set_series’:
drivers/net/wireless/realtek/rtlwifi/rc.c:144: warning: comparison is
always false due to limited range of data type
if (sta && sta->vht_cap.vht_supported &&
(wireless_mode == WIRELESS_MODE_AC_5G ||
wireless_mode == WIRELESS_MODE_AC_24G ||
wireless_mode == WIRELESS_MODE_AC_ONLY))
rate->flags |= IEEE80211_TX_RC_VHT_MCS;
u8 wireless_mode = 0;
enum wireless_mode {
...
WIRELESS_MODE_AC_ONLY = 0x100,
How is that supposed to work?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
On 03/04/2016 09:29 AM, Kalle Valo wrote:
> (Adding Larry)
>
> Geert Uytterhoeven <[email protected]> writes:
>
>> On Thu, Feb 18, 2016 at 4:28 PM, Kalle Valo <[email protected]> wrote:
>>
>>> rtlwifi
>>>
>>> * fix broken VHT (802.11ac) support, reported by Linus
>>
>> That's commit d76d65fd26951498144029c24852c4d54ee512d9
>>
>> drivers/net/wireless/realtek/rtlwifi/rc.c: In function
>> ‘_rtl_rc_rate_set_series’:
>> drivers/net/wireless/realtek/rtlwifi/rc.c:144: warning: comparison is
>> always false due to limited range of data type
>>
>> if (sta && sta->vht_cap.vht_supported &&
>> (wireless_mode == WIRELESS_MODE_AC_5G ||
>> wireless_mode == WIRELESS_MODE_AC_24G ||
>> wireless_mode == WIRELESS_MODE_AC_ONLY))
>> rate->flags |= IEEE80211_TX_RC_VHT_MCS;
>>
>> u8 wireless_mode = 0;
>>
>> enum wireless_mode {
>> ...
>> WIRELESS_MODE_AC_ONLY = 0x100,
>>
>> How is that supposed to work?
>
> I have no idea what could be the difference, for example, between AC_5G
> and AC_ONLY. Maybe AC_ONLY mode is not really used in normal setups and
> that's why the bug doesn't break anything? Larry, do you know?
>
> Anyway, Larry has a patch for this but I'm planning to send it to 4.6 as
> I didn't think it as that urgent:
>
> rtlwifi: Fix size of wireless mode variable
>
> https://patchwork.kernel.org/patch/8425191/
That WIRELESS_MODE_AC_ONLY mode is part of a recent commit to a repo that
Realtek and I use as a place for their most recent changes. As I do not have,
nor want, an NDA with them, I could only speculate about their reasons for such
a mode. I included it because I was touching that portion of the code.
Unfortunately, I did not catch the associated change in the variable size.
Saving the second patch for 4.6 is the correct action.
Larry
(Adding Larry)
Geert Uytterhoeven <[email protected]> writes:
> On Thu, Feb 18, 2016 at 4:28 PM, Kalle Valo <[email protected]> wrote:
>
>> rtlwifi
>>
>> * fix broken VHT (802.11ac) support, reported by Linus
>
> That's commit d76d65fd26951498144029c24852c4d54ee512d9
>
> drivers/net/wireless/realtek/rtlwifi/rc.c: In function
> ‘_rtl_rc_rate_set_series’:
> drivers/net/wireless/realtek/rtlwifi/rc.c:144: warning: comparison is
> always false due to limited range of data type
>
> if (sta && sta->vht_cap.vht_supported &&
> (wireless_mode == WIRELESS_MODE_AC_5G ||
> wireless_mode == WIRELESS_MODE_AC_24G ||
> wireless_mode == WIRELESS_MODE_AC_ONLY))
> rate->flags |= IEEE80211_TX_RC_VHT_MCS;
>
> u8 wireless_mode = 0;
>
> enum wireless_mode {
> ...
> WIRELESS_MODE_AC_ONLY = 0x100,
>
> How is that supposed to work?
I have no idea what could be the difference, for example, between AC_5G
and AC_ONLY. Maybe AC_ONLY mode is not really used in normal setups and
that's why the bug doesn't break anything? Larry, do you know?
Anyway, Larry has a patch for this but I'm planning to send it to 4.6 as
I didn't think it as that urgent:
rtlwifi: Fix size of wireless mode variable
https://patchwork.kernel.org/patch/8425191/
--
Kalle Valo