2016-04-20 04:21:05

by Marty Faltesek

Subject: [PATCH v2] mwifiex: fw download does not release sdio bus during failure

Signed-off-by: Marty Faltesek <[email protected]>
---
drivers/net/wireless/marvell/mwifiex/sdio.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/wireless/marvell/mwifiex/sdio.c b/drivers/net/wireless/marvell/mwifiex/sdio.c
index 4c8cae6..d6ef34f 100644
--- a/drivers/net/wireless/marvell/mwifiex/sdio.c
+++ b/drivers/net/wireless/marvell/mwifiex/sdio.c
@@ -1026,13 +1026,12 @@ static int mwifiex_prog_fw_w_helper(struct mwifiex_adapter *adapter,
offset += txlen;
} while (true);

- sdio_release_host(card->func);
-
mwifiex_dbg(adapter, MSG,
"info: FW download over, size %d bytes\n", offset);

ret = 0;
done:
+ sdio_release_host(card->func);
kfree(fwbuf);
return ret;
}
--
2.8.0.rc3.226.g39d4020

2016-04-27 13:50:56

by Kalle Valo

Subject: Re: [v2] mwifiex: fw download does not release sdio bus during failure

> Signed-off-by: Marty Faltesek <[email protected]>
> Reviewed-by: Julian Calaby <[email protected]>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo

2016-04-21 01:36:37

by Julian Calaby

Subject: Re: [PATCH v2] mwifiex: fw download does not release sdio bus during failure

Hi All,

On Wed, Apr 20, 2016 at 2:20 PM, Marty Faltesek <[email protected]> wrote:
> Signed-off-by: Marty Faltesek <[email protected]>

This looks right to me.

Reviewed-by: Julian Calaby <[email protected]>

Thanks,

Julian Calaby


> ---
> drivers/net/wireless/marvell/mwifiex/sdio.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/marvell/mwifiex/sdio.c b/drivers/net/wireless/marvell/mwifiex/sdio.c
> index 4c8cae6..d6ef34f 100644
> --- a/drivers/net/wireless/marvell/mwifiex/sdio.c
> +++ b/drivers/net/wireless/marvell/mwifiex/sdio.c
> @@ -1026,13 +1026,12 @@ static int mwifiex_prog_fw_w_helper(struct mwifiex_adapter *adapter,
> offset += txlen;
> } while (true);
>
> - sdio_release_host(card->func);
> -
> mwifiex_dbg(adapter, MSG,
> "info: FW download over, size %d bytes\n", offset);
>
> ret = 0;
> done:
> + sdio_release_host(card->func);
> kfree(fwbuf);
> return ret;
> }
> --
> 2.8.0.rc3.226.g39d4020
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html



--
Julian Calaby

Email: [email protected]
Profile: http://www.google.com/profiles/julian.calaby/