On Thu, 16 Jun 2016 15:23:37 +0000 (UTC)
Kalle Valo <[email protected]> wrote:
> Guenter Roeck <[email protected]> wrote:
> > gcc-6 reports the following error with -Werror=unused-const-variable.
> >
> > drivers/net/wireless/broadcom/b43/phy_a.c:576:40: error:
> > 'b43_phyops_a' defined but not used
> >
> > Per Michael Büsch: "All a-phy code is usused", so remove it all,
> > and move the remaining Type-G initialization code into phy_g.c.
> >
> > Reported-by: Fengguang Wu <[email protected]> [0-day test robot]
> > Cc: Michael Büsch <[email protected]>
> > Signed-off-by: Guenter Roeck <[email protected]>
>
> Thanks, 2 patches applied to wireless-drivers-next.git:
>
> 9791333a840f b43: Remove unused phy_a code
> afdfdc481ea9 b43: Completely remove support for phy_a
Did anybody test this on any hardware?
I think this should be tested on some G-PHY hardware, before it goes to
Linus.
--
Michael
On Thu, 16 Jun 2016 18:56:14 +0300
Kalle Valo <[email protected]> wrote:
> Michael Büsch <[email protected]> writes:
>
> > On Thu, 16 Jun 2016 15:23:37 +0000 (UTC)
> > Kalle Valo <[email protected]> wrote:
> >
> >> Guenter Roeck <[email protected]> wrote:
> >> > gcc-6 reports the following error with -Werror=unused-const-variable.
> >> >
> >> > drivers/net/wireless/broadcom/b43/phy_a.c:576:40: error:
> >> > 'b43_phyops_a' defined but not used
> >> >
> >> > Per Michael Büsch: "All a-phy code is usused", so remove it all,
> >> > and move the remaining Type-G initialization code into phy_g.c.
> >> >
> >> > Reported-by: Fengguang Wu <[email protected]> [0-day test robot]
> >> > Cc: Michael Büsch <[email protected]>
> >> > Signed-off-by: Guenter Roeck <[email protected]>
> >>
> >> Thanks, 2 patches applied to wireless-drivers-next.git:
> >>
> >> 9791333a840f b43: Remove unused phy_a code
> >> afdfdc481ea9 b43: Completely remove support for phy_a
> >
> > Did anybody test this on any hardware? I think this should be tested
> > on some G-PHY hardware, before it goes to Linus.
>
> Larry tested these:
>
> "These two patches have been tested on a BCM4318."
>
> https://patchwork.kernel.org/patch/9154719/
Ah OK. I forgot.
Everything is fine then.
--
Michael
Michael Büsch <[email protected]> writes:
> On Thu, 16 Jun 2016 15:23:37 +0000 (UTC)
> Kalle Valo <[email protected]> wrote:
>
>> Guenter Roeck <[email protected]> wrote:
>> > gcc-6 reports the following error with -Werror=unused-const-variable.
>> >
>> > drivers/net/wireless/broadcom/b43/phy_a.c:576:40: error:
>> > 'b43_phyops_a' defined but not used
>> >
>> > Per Michael Büsch: "All a-phy code is usused", so remove it all,
>> > and move the remaining Type-G initialization code into phy_g.c.
>> >
>> > Reported-by: Fengguang Wu <[email protected]> [0-day test robot]
>> > Cc: Michael Büsch <[email protected]>
>> > Signed-off-by: Guenter Roeck <[email protected]>
>>
>> Thanks, 2 patches applied to wireless-drivers-next.git:
>>
>> 9791333a840f b43: Remove unused phy_a code
>> afdfdc481ea9 b43: Completely remove support for phy_a
>
> Did anybody test this on any hardware? I think this should be tested
> on some G-PHY hardware, before it goes to Linus.
Larry tested these:
"These two patches have been tested on a BCM4318."
https://patchwork.kernel.org/patch/9154719/
--
Kalle Valo