Signed-off-by: Ismael Luceno <[email protected]>
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c | 4 ++++
drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h | 3 +++
2 files changed, 7 insertions(+)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c
index 98b15a9..455fc69 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c
@@ -1462,11 +1462,15 @@ static int brcmf_usb_reset_resume(struct usb_interface *intf)
#define BRCMF_USB_DEVICE(dev_id) \
{ USB_DEVICE(BRCM_USB_VENDOR_ID_BROADCOM, dev_id) }
+#define LINKSYS_USB_DEVICE(dev_id) \
+ { USB_DEVICE(BRCM_USB_VENDOR_ID_LINKSYS, dev_id) }
+
static struct usb_device_id brcmf_usb_devid_table[] = {
BRCMF_USB_DEVICE(BRCM_USB_43143_DEVICE_ID),
BRCMF_USB_DEVICE(BRCM_USB_43236_DEVICE_ID),
BRCMF_USB_DEVICE(BRCM_USB_43242_DEVICE_ID),
BRCMF_USB_DEVICE(BRCM_USB_43569_DEVICE_ID),
+ LINKSYS_USB_DEVICE(BRCM_USB_43235_LINKSYS_DEVICE_ID),
{ USB_DEVICE(BRCM_USB_VENDOR_ID_LG, BRCM_USB_43242_LG_DEVICE_ID) },
/* special entry for device with firmware loaded and running */
BRCMF_USB_DEVICE(BRCM_USB_BCMFW_DEVICE_ID),
diff --git a/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h b/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h
index 699f2c2..6666513 100644
--- a/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h
+++ b/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h
@@ -22,6 +22,7 @@
#define BRCM_USB_VENDOR_ID_BROADCOM 0x0a5c
#define BRCM_USB_VENDOR_ID_LG 0x043e
+#define BRCM_USB_VENDOR_ID_LINKSYS 0x13b1
#define BRCM_PCIE_VENDOR_ID_BROADCOM PCI_VENDOR_ID_BROADCOM
/* Chipcommon Core Chip IDs */
@@ -56,6 +57,8 @@
/* USB Device IDs */
#define BRCM_USB_43143_DEVICE_ID 0xbd1e
+#define BRCM_USB_43235_LINKSYS_DEVICE_ID \
+ 0x0039
#define BRCM_USB_43236_DEVICE_ID 0xbd17
#define BRCM_USB_43242_DEVICE_ID 0xbd1f
#define BRCM_USB_43242_LG_DEVICE_ID 0x3101
--
2.9.0
On 21 June 2016 at 18:58, Ismael Luceno <[email protected]> wrote:
> On 21/Jun/2016 07:45, Rafał Miłecki wrote:
>> On 21 June 2016 at 02:18, Ismael Luceno <[email protected]> wrote:
>> > @@ -56,6 +57,8 @@
>> >
>> > /* USB Device IDs */
>> > #define BRCM_USB_43143_DEVICE_ID 0xbd1e
>> > +#define BRCM_USB_43235_LINKSYS_DEVICE_ID \
>> > + 0x0039
>>
>> I guess you wanted to have number aligned to the column of other ones?
>> I'm not sure if that improves readability at all.
>
> Yes. Would you suggest to align more to the right? I didn't want to
> modify everything just to add a new one.
I wouldn't care that much about alignment. I'm sure there already some
misaligned numbers, fields & comments in brcm80211 header.
I would just use name\t0x0039 pattern.
--
Rafał
On 22/Jun/2016 21:07, Arend van Spriel wrote:
> On 22-06-16 20:36, Ismael Luceno wrote:
> > On 21/Jun/2016 21:02, Arend van Spriel wrote:
> >> On 21-06-16 02:18, Ismael Luceno wrote:
> >>> Signed-off-by: Ismael Luceno <[email protected]>
> >>
> >> A bit more description would be nice. I am actually wondering why you
> >> would be adding this. If I am not mistaken the AE1200 can not be handled
> >> by brcmfmac. Otherwise I am interested in a kernel log showing the
> >> device probe sequence with brcmfmac loaded with parameter debug=0x1416.
> >
> > Log attached.
> >
> > I was surprised it works without any tweaking.
>
> Nice. What kernel version are you running on.
Commit c3695331f3a326a468bd6a5b6f05b481b399726b.
> Can you also dump a debugfs file,
> ie. /sys/kernel/debug/brcmfmac/*/revinfo.
vendorid: 0x14e4
deviceid: 0x4347
radiorev: 114.5.112
chipnum: 43235 (a8e3)
chiprev: 3
chippkg: 4
corerev: 24
boardid: 0x0571
boardvendor: 0x14e4
boardrev: P523
driverrev: 5.90.188.22
ucoderev: 0
bus: 0
phytype: 4
phyrev: 9
anarev: 0
nvramrev: 00000000
> I want to know what chip id and revision is reported. I have tried an
> AE1200 in the past, but it had a chip revision that had insufficient
> memory to run fullmac firmware.
That's going to be confusing for anyone having the hardware :(.
> Is there FCC registration number on it?
Yes: Q87-AE1200
On 21/Jun/2016 21:02, Arend van Spriel wrote:
> On 21-06-16 02:18, Ismael Luceno wrote:
> > Signed-off-by: Ismael Luceno <[email protected]>
>
> A bit more description would be nice. I am actually wondering why you
> would be adding this. If I am not mistaken the AE1200 can not be handled
> by brcmfmac. Otherwise I am interested in a kernel log showing the
> device probe sequence with brcmfmac loaded with parameter debug=0x1416.
Log attached.
I was surprised it works without any tweaking.
There's quite a lot of unhelpful noise about those adapters, but not
much actual information, I couldn't find anything about those that
supposedly don't work, so I have no idea if it's just a different
firmware version or what did change (if anything).
On 21 June 2016 at 02:18, Ismael Luceno <[email protected]> wrote:
> @@ -56,6 +57,8 @@
>
> /* USB Device IDs */
> #define BRCM_USB_43143_DEVICE_ID 0xbd1e
> +#define BRCM_USB_43235_LINKSYS_DEVICE_ID \
> + 0x0039
I guess you wanted to have number aligned to the column of other ones?
I'm not sure if that improves readability at all.
--
Rafał
On 21/Jun/2016 07:45, Rafał Miłecki wrote:
> On 21 June 2016 at 02:18, Ismael Luceno <[email protected]> wrote:
> > @@ -56,6 +57,8 @@
> >
> > /* USB Device IDs */
> > #define BRCM_USB_43143_DEVICE_ID 0xbd1e
> > +#define BRCM_USB_43235_LINKSYS_DEVICE_ID \
> > + 0x0039
>
> I guess you wanted to have number aligned to the column of other ones?
> I'm not sure if that improves readability at all.
Yes. Would you suggest to align more to the right? I didn't want to
modify everything just to add a new one.
On 21-06-16 02:18, Ismael Luceno wrote:
> Signed-off-by: Ismael Luceno <[email protected]>
A bit more description would be nice. I am actually wondering why you
would be adding this. If I am not mistaken the AE1200 can not be handled
by brcmfmac. Otherwise I am interested in a kernel log showing the
device probe sequence with brcmfmac loaded with parameter debug=0x1416.
Regards,
Arend
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c | 4 ++++
> drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h | 3 +++
> 2 files changed, 7 insertions(+)
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c
> index 98b15a9..455fc69 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c
> @@ -1462,11 +1462,15 @@ static int brcmf_usb_reset_resume(struct usb_interface *intf)
> #define BRCMF_USB_DEVICE(dev_id) \
> { USB_DEVICE(BRCM_USB_VENDOR_ID_BROADCOM, dev_id) }
>
> +#define LINKSYS_USB_DEVICE(dev_id) \
> + { USB_DEVICE(BRCM_USB_VENDOR_ID_LINKSYS, dev_id) }
> +
> static struct usb_device_id brcmf_usb_devid_table[] = {
> BRCMF_USB_DEVICE(BRCM_USB_43143_DEVICE_ID),
> BRCMF_USB_DEVICE(BRCM_USB_43236_DEVICE_ID),
> BRCMF_USB_DEVICE(BRCM_USB_43242_DEVICE_ID),
> BRCMF_USB_DEVICE(BRCM_USB_43569_DEVICE_ID),
> + LINKSYS_USB_DEVICE(BRCM_USB_43235_LINKSYS_DEVICE_ID),
> { USB_DEVICE(BRCM_USB_VENDOR_ID_LG, BRCM_USB_43242_LG_DEVICE_ID) },
> /* special entry for device with firmware loaded and running */
> BRCMF_USB_DEVICE(BRCM_USB_BCMFW_DEVICE_ID),
> diff --git a/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h b/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h
> index 699f2c2..6666513 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h
> +++ b/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h
> @@ -22,6 +22,7 @@
>
> #define BRCM_USB_VENDOR_ID_BROADCOM 0x0a5c
> #define BRCM_USB_VENDOR_ID_LG 0x043e
> +#define BRCM_USB_VENDOR_ID_LINKSYS 0x13b1
> #define BRCM_PCIE_VENDOR_ID_BROADCOM PCI_VENDOR_ID_BROADCOM
>
> /* Chipcommon Core Chip IDs */
> @@ -56,6 +57,8 @@
>
> /* USB Device IDs */
> #define BRCM_USB_43143_DEVICE_ID 0xbd1e
> +#define BRCM_USB_43235_LINKSYS_DEVICE_ID \
> + 0x0039
> #define BRCM_USB_43236_DEVICE_ID 0xbd17
> #define BRCM_USB_43242_DEVICE_ID 0xbd1f
> #define BRCM_USB_43242_LG_DEVICE_ID 0x3101
>
On 22-06-16 20:36, Ismael Luceno wrote:
> On 21/Jun/2016 21:02, Arend van Spriel wrote:
>> On 21-06-16 02:18, Ismael Luceno wrote:
>>> Signed-off-by: Ismael Luceno <[email protected]>
>>
>> A bit more description would be nice. I am actually wondering why you
>> would be adding this. If I am not mistaken the AE1200 can not be handled
>> by brcmfmac. Otherwise I am interested in a kernel log showing the
>> device probe sequence with brcmfmac loaded with parameter debug=0x1416.
>
> Log attached.
>
> I was surprised it works without any tweaking.
Nice. What kernel version are you running on. Can you also dump a
debugfs file, ie. /sys/kernel/debug/brcmfmac/*/revinfo. I want to know
what chip id and revision is reported. I have tried an AE1200 in the
past, but it had a chip revision that had insufficient memory to run
fullmac firmware. Is there FCC registration number on it?
Regards,
Arend
> There's quite a lot of unhelpful noise about those adapters, but not
> much actual information, I couldn't find anything about those that
> supposedly don't work, so I have no idea if it's just a different
> firmware version or what did change (if anything).
>
Ping.
On 22/Jun/2016 17:54, Ismael Luceno wrote:
> On 22/Jun/2016 21:07, Arend van Spriel wrote:
> > On 22-06-16 20:36, Ismael Luceno wrote:
> > > On 21/Jun/2016 21:02, Arend van Spriel wrote:
> > >> On 21-06-16 02:18, Ismael Luceno wrote:
> > >>> Signed-off-by: Ismael Luceno <[email protected]>
> > >>
> > >> A bit more description would be nice. I am actually wondering why you
> > >> would be adding this. If I am not mistaken the AE1200 can not be handled
> > >> by brcmfmac. Otherwise I am interested in a kernel log showing the
> > >> device probe sequence with brcmfmac loaded with parameter debug=0x1416.
> > >
> > > Log attached.
> > >
> > > I was surprised it works without any tweaking.
> >
> > Nice. What kernel version are you running on.
>
> Commit c3695331f3a326a468bd6a5b6f05b481b399726b.
>
> > Can you also dump a debugfs file,
> > ie. /sys/kernel/debug/brcmfmac/*/revinfo.
>
> vendorid: 0x14e4
> deviceid: 0x4347
> radiorev: 114.5.112
> chipnum: 43235 (a8e3)
> chiprev: 3
> chippkg: 4
> corerev: 24
> boardid: 0x0571
> boardvendor: 0x14e4
> boardrev: P523
> driverrev: 5.90.188.22
> ucoderev: 0
> bus: 0
> phytype: 4
> phyrev: 9
> anarev: 0
> nvramrev: 00000000
>
>
> > I want to know what chip id and revision is reported. I have tried an
> > AE1200 in the past, but it had a chip revision that had insufficient
> > memory to run fullmac firmware.
>
> That's going to be confusing for anyone having the hardware :(.
>
> > Is there FCC registration number on it?
>
> Yes: Q87-AE1200
On 20 August 2016 at 17:17, Ismael Luceno <[email protected]> wrote:
> Ping.
No need to ping (and don't top post please).
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#checking_state_of_patches_from_patchwork
On 20-08-16 17:17, Ismael Luceno wrote:
> Ping.
>
> On 22/Jun/2016 17:54, Ismael Luceno wrote:
>> On 22/Jun/2016 21:07, Arend van Spriel wrote:
>>> On 22-06-16 20:36, Ismael Luceno wrote:
>>>> On 21/Jun/2016 21:02, Arend van Spriel wrote:
>>>>> On 21-06-16 02:18, Ismael Luceno wrote:
>>>>>> Signed-off-by: Ismael Luceno <[email protected]>
>>>>>
>>>>> A bit more description would be nice. I am actually wondering why you
>>>>> would be adding this. If I am not mistaken the AE1200 can not be handled
>>>>> by brcmfmac. Otherwise I am interested in a kernel log showing the
>>>>> device probe sequence with brcmfmac loaded with parameter debug=0x1416.
As can be seen in patchwork the state is "Changes Requested". Above is
my initial response starting with "A bit more description would be nice"
in which I refer to the empty commit message. Here a suggestion based on
the revision info provided below and info found on [1]:
The Linksys AE1200 comes with different revisions of the bcm43235 all of
which use the same USB ID. This chipset can only be supported by
brcmfmac as of revision 3.
Regards,
Arend
[1] https://wikidevi.com/wiki/Linksys_AE1200
>>>> Log attached.
>>>>
>>>> I was surprised it works without any tweaking.
>>>
>>> Nice. What kernel version are you running on.
>>
>> Commit c3695331f3a326a468bd6a5b6f05b481b399726b.
>>
>>> Can you also dump a debugfs file,
>>> ie. /sys/kernel/debug/brcmfmac/*/revinfo.
>>
>> vendorid: 0x14e4
>> deviceid: 0x4347
>> radiorev: 114.5.112
>> chipnum: 43235 (a8e3)
>> chiprev: 3
>> chippkg: 4
>> corerev: 24
>> boardid: 0x0571
>> boardvendor: 0x14e4
>> boardrev: P523
>> driverrev: 5.90.188.22
>> ucoderev: 0
>> bus: 0
>> phytype: 4
>> phyrev: 9
>> anarev: 0
>> nvramrev: 00000000
>>
>>
>>> I want to know what chip id and revision is reported. I have tried an
>>> AE1200 in the past, but it had a chip revision that had insufficient
>>> memory to run fullmac firmware.
>>
>> That's going to be confusing for anyone having the hardware :(.
>>
>>> Is there FCC registration number on it?
>>
>> Yes: Q87-AE1200