2016-06-29 12:04:09

by Amitkumar Karwar

Subject: [PATCH] mwifiex: fix scan_block flag handling

scan_block flag is used to block scan operation when 4 way handshake
is in progress. Sometimes it doesn't get cleared due to incomplete
association. An example is assoc request/response is done, but add key
operation get canceled in some corner cases. As a result, further
association/scan operations are blocked.

This patch fixes the problem by clearing scan_block flag.

Signed-off-by: Amitkumar Karwar <[email protected]>
Signed-off-by: Xinming Hu <[email protected]>
---
drivers/net/wireless/marvell/mwifiex/cfg80211.c | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
index ff948a9..bbc0cfc 100644
--- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c
+++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
@@ -2209,6 +2209,9 @@ mwifiex_cfg80211_connect(struct wiphy *wiphy, struct net_device *dev,
return -EALREADY;
}

+ if (priv->scan_block)
+ priv->scan_block = false;
+
if (adapter->surprise_removed || adapter->is_cmd_timedout) {
mwifiex_dbg(adapter, ERROR,
"%s: Ignore connection.\t"
@@ -2427,6 +2430,9 @@ mwifiex_cfg80211_scan(struct wiphy *wiphy,
return -EBUSY;
}

+ if (!priv->wdev.current_bss && priv->scan_block)
+ priv->scan_block = false;
+
if (!mwifiex_stop_bg_scan(priv))
cfg80211_sched_scan_stopped_rtnl(priv->wdev.wiphy);

--
1.9.1

2016-07-08 13:44:19

by Kalle Valo

Subject: Re: mwifiex: fix scan_block flag handling

Amitkumar Karwar <[email protected]> wrote:
> scan_block flag is used to block scan operation when 4 way handshake
> is in progress. Sometimes it doesn't get cleared due to incomplete
> association. An example is assoc request/response is done, but add key
> operation get canceled in some corner cases. As a result, further
> association/scan operations are blocked.
>
> This patch fixes the problem by clearing scan_block flag.
>
> Signed-off-by: Amitkumar Karwar <[email protected]>
> Signed-off-by: Xinming Hu <[email protected]>

Thanks, 1 patch applied to wireless-drivers-next.git:

b74d6e740be3 mwifiex: fix scan_block flag handling

--
Sent by pwcli
https://patchwork.kernel.org/patch/9205005/