2016-07-15 13:01:22

by Colin King

Subject: [PATCH] NFC: null-ify info->ram_patch when firmware is released

From: Colin Ian King <[email protected]>

When the firmware is released for info->ram_patch currently
info->otp_patch is being nullified and not info->ram_patch.
This looks like a cut-n-paste coding error. Fix this by
nullifing the correct field.

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/nfc/fdp/fdp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nfc/fdp/fdp.c b/drivers/nfc/fdp/fdp.c
index e44a7a2..d93d314 100644
--- a/drivers/nfc/fdp/fdp.c
+++ b/drivers/nfc/fdp/fdp.c
@@ -345,7 +345,7 @@ static void fdp_nci_release_firmware(struct nci_dev *ndev)

if (info->ram_patch) {
release_firmware(info->ram_patch);
- info->otp_patch = NULL;
+ info->ram_patch = NULL;
}
}

--
2.8.1

2016-07-19 21:29:04

by Samuel Ortiz

Subject: Re: [PATCH] NFC: null-ify info->ram_patch when firmware is released

Hi Colin,

On Fri, Jul 15, 2016 at 02:00:33PM +0100, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> When the firmware is released for info->ram_patch currently
> info->otp_patch is being nullified and not info->ram_patch.
> This looks like a cut-n-paste coding error. Fix this by
> nullifing the correct field.
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/nfc/fdp/fdp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to nfc-next, thanks.

Cheers,
Samuel.