2016-07-21 16:31:35

by Bob Copeland

Subject: [PATCH] ath9k: fix misleading indent

Fixes smatch warning:

ath9k_vif_iter_set_beacon() warn if statement not indented

Signed-off-by: Bob Copeland <[email protected]>
---
drivers/net/wireless/ath/ath9k/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c
index 7594650..70ca746 100644
--- a/drivers/net/wireless/ath/ath9k/main.c
+++ b/drivers/net/wireless/ath/ath9k/main.c
@@ -919,7 +919,7 @@ static void ath9k_vif_iter_set_beacon(struct ath9k_vif_iter_data *iter_data,
} else {
if (iter_data->primary_beacon_vif->type != NL80211_IFTYPE_AP &&
vif->type == NL80211_IFTYPE_AP)
- iter_data->primary_beacon_vif = vif;
+ iter_data->primary_beacon_vif = vif;
}

iter_data->beacons = true;
--
2.9.0

2016-07-22 04:50:17

by Julian Calaby

Subject: Re: [PATCH] ath9k: fix misleading indent

Hi All,

On Fri, Jul 22, 2016 at 2:31 AM, Bob Copeland <[email protected]> wrote:
> Fixes smatch warning:
>
> ath9k_vif_iter_set_beacon() warn if statement not indented
>
> Signed-off-by: Bob Copeland <[email protected]>

Looks right to me.

Reviewed-by: Julian Calaby <[email protected]>

> ---
> drivers/net/wireless/ath/ath9k/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Thanks,

--
Julian Calaby

Email: [email protected]
Profile: http://www.google.com/profiles/julian.calaby/

2016-08-19 10:06:45

by Kalle Valo

Subject: Re: ath9k: fix misleading indent

Bob Copeland <[email protected]> wrote:
> Fixes smatch warning:
>
> ath9k_vif_iter_set_beacon() warn if statement not indented
>
> Signed-off-by: Bob Copeland <[email protected]>
> Reviewed-by: Julian Calaby <[email protected]>

Thanks, 1 patch applied to ath-next branch of ath.git:

4c51e7db87b7 ath9k: fix misleading indent

--
Sent by pwcli
https://patchwork.kernel.org/patch/9241937/