I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <[email protected]>
Signed-off-by: Baole Ni <[email protected]>
---
drivers/net/wireless/intersil/p54/p54spi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/intersil/p54/p54spi.c b/drivers/net/wireless/intersil/p54/p54spi.c
index 7ab2f43..07c77f8 100644
--- a/drivers/net/wireless/intersil/p54/p54spi.c
+++ b/drivers/net/wireless/intersil/p54/p54spi.c
@@ -48,11 +48,11 @@ MODULE_FIRMWARE("3826.arm");
*/
static int p54spi_gpio_power = 97;
-module_param(p54spi_gpio_power, int, 0444);
+module_param(p54spi_gpio_power, int, S_IRUSR | S_IRGRP | S_IROTH);
MODULE_PARM_DESC(p54spi_gpio_power, "gpio number for power line");
static int p54spi_gpio_irq = 87;
-module_param(p54spi_gpio_irq, int, 0444);
+module_param(p54spi_gpio_irq, int, S_IRUSR | S_IRGRP | S_IROTH);
MODULE_PARM_DESC(p54spi_gpio_irq, "gpio number for irq line");
static void p54spi_spi_read(struct p54s_priv *priv, u8 address,
--
2.9.2