2016-07-31 10:30:45

by Heinrich Schuchardt

Subject: [PATCH 1/1] rtlwifi: remove superfluous condition

If sta == NULL, the changed line will not be reached.
So no need to check if stat == NULL here.

Signed-off-by: Heinrich Schuchardt <[email protected]>
---
drivers/net/wireless/realtek/rtlwifi/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/realtek/rtlwifi/core.c b/drivers/net/wireless/realtek/rtlwifi/core.c
index 41f77f8..7aee5ebb1 100644
--- a/drivers/net/wireless/realtek/rtlwifi/core.c
+++ b/drivers/net/wireless/realtek/rtlwifi/core.c
@@ -1135,7 +1135,7 @@ static void rtl_op_bss_info_changed(struct ieee80211_hw *hw,
mac->mode = WIRELESS_MODE_AC_24G;
}

- if (vif->type == NL80211_IFTYPE_STATION && sta)
+ if (vif->type == NL80211_IFTYPE_STATION)
rtlpriv->cfg->ops->update_rate_tbl(hw, sta, 0);
rcu_read_unlock();

--
2.8.1

2016-07-31 14:14:43

by Larry Finger

Subject: Re: [PATCH 1/1] rtlwifi: remove superfluous condition

On 07/31/2016 05:30 AM, Heinrich Schuchardt wrote:
> If sta == NULL, the changed line will not be reached.
> So no need to check if stat == NULL here.
>
> Signed-off-by: Heinrich Schuchardt <[email protected]>
> ---
> drivers/net/wireless/realtek/rtlwifi/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

I agree. If sta were NULL, we would never have reached this statement. There is,
however, a typo in the last line of the commit message. Once this is fixed, you
may add the line "Acked-by: Larry Finger <[email protected]>"

Thanks,

Larry

>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/core.c b/drivers/net/wireless/realtek/rtlwifi/core.c
> index 41f77f8..7aee5ebb1 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/core.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/core.c
> @@ -1135,7 +1135,7 @@ static void rtl_op_bss_info_changed(struct ieee80211_hw *hw,
> mac->mode = WIRELESS_MODE_AC_24G;
> }
>
> - if (vif->type == NL80211_IFTYPE_STATION && sta)
> + if (vif->type == NL80211_IFTYPE_STATION)
> rtlpriv->cfg->ops->update_rate_tbl(hw, sta, 0);
> rcu_read_unlock();
>
>

2016-08-03 10:26:03

by Kalle Valo

Subject: Re: [PATCH 1/1 v2] rtlwifi: remove superfluous condition

Heinrich Schuchardt <[email protected]> writes:

> If sta == NULL, the changed line will not be reached.
> So no need to check that sta != NULL here.
>
> v2:
> fix typo
>
> Signed-off-by: Heinrich Schuchardt <[email protected]>
> Acked-by: Larry Finger <[email protected]>
> ---
> drivers/net/wireless/realtek/rtlwifi/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

The change log goes under the "---" line so that git can automatically
strip it away while committing the patch. I can fix it this time but
please keep this in mind in the future.

--
Kalle Valo

2016-08-02 19:26:50

by Heinrich Schuchardt

Subject: [PATCH 1/1 v2] rtlwifi: remove superfluous condition

If sta == NULL, the changed line will not be reached.
So no need to check that sta != NULL here.

v2:
fix typo

Signed-off-by: Heinrich Schuchardt <[email protected]>
Acked-by: Larry Finger <[email protected]>
---
drivers/net/wireless/realtek/rtlwifi/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/realtek/rtlwifi/core.c b/drivers/net/wireless/realtek/rtlwifi/core.c
index 41f77f8..7aee5ebb1 100644
--- a/drivers/net/wireless/realtek/rtlwifi/core.c
+++ b/drivers/net/wireless/realtek/rtlwifi/core.c
@@ -1135,7 +1135,7 @@ static void rtl_op_bss_info_changed(struct ieee80211_hw *hw,
mac->mode = WIRELESS_MODE_AC_24G;
}

- if (vif->type == NL80211_IFTYPE_STATION && sta)
+ if (vif->type == NL80211_IFTYPE_STATION)
rtlpriv->cfg->ops->update_rate_tbl(hw, sta, 0);
rcu_read_unlock();

--
2.1.4

2016-09-03 10:03:55

by Kalle Valo

Subject: Re: [1/1,v2] rtlwifi: remove superfluous condition

Heinrich Schuchardt <[email protected]> wrote:
> If sta == NULL, the changed line will not be reached.
> So no need to check that sta != NULL here.
>
> Signed-off-by: Heinrich Schuchardt <[email protected]>
> Acked-by: Larry Finger <[email protected]>

Thanks, 1 patch applied to wireless-drivers-next.git:

f898005ff99f rtlwifi: remove superfluous condition

--
Sent by pwcli
https://patchwork.kernel.org/patch/9260253/