2016-11-05 19:09:04

by Larry Finger

Subject: [PATCH] ssb: Fix error routine when fallback SPROM fails

When there is a CRC error in the SPROM read from the device, the code
attempts to handle a fallback SPROM. When this also fails, the driver
returns zero rather than an error code.

Signed-off-by: Larry Finger <[email protected]>
Cc: Stable <[email protected]>
---
drivers/ssb/pci.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/ssb/pci.c b/drivers/ssb/pci.c
index 0f28c08..77b551d 100644
--- a/drivers/ssb/pci.c
+++ b/drivers/ssb/pci.c
@@ -909,6 +909,7 @@ static int ssb_pci_sprom_get(struct ssb_bus *bus,
if (err) {
ssb_warn("WARNING: Using fallback SPROM failed (err %d)\n",
err);
+ goto out_free;
} else {
ssb_dbg("Using SPROM revision %d provided by platform\n",
sprom->revision);
--
2.10.0

2016-11-17 06:49:21

by Kalle Valo

Subject: Re: ssb: Fix error routine when fallback SPROM fails

Larry Finger <[email protected]> wrote:
> When there is a CRC error in the SPROM read from the device, the code
> attempts to handle a fallback SPROM. When this also fails, the driver
> returns zero rather than an error code.
>
> Signed-off-by: Larry Finger <[email protected]>
> Cc: Stable <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

8052d7245b60 ssb: Fix error routine when fallback SPROM fails

--
https://patchwork.kernel.org/patch/9413783/

Documentation about submitting wireless patches and checking status
from patchwork:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches