2017-01-26 15:13:39

by Guy Mishol

Subject: [PATCH] wlcore: print the sdio buffer after reading it

fix an issue where we printed the sdio buffer before
actually read it.

Signed-off-by: Guy Mishol <[email protected]>
---
drivers/net/wireless/ti/wlcore/sdio.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/net/wireless/ti/wlcore/sdio.c b/drivers/net/wireless/ti/wlcore/sdio.c
index 47fe7f9..287023e 100644
--- a/drivers/net/wireless/ti/wlcore/sdio.c
+++ b/drivers/net/wireless/ti/wlcore/sdio.c
@@ -81,13 +81,6 @@ static int __must_check wl12xx_sdio_raw_read(struct device *child, int addr,

sdio_claim_host(func);

- if (unlikely(dump)) {
- printk(KERN_DEBUG "wlcore_sdio: READ from 0x%04x\n", addr);
- print_hex_dump(KERN_DEBUG, "wlcore_sdio: READ ",
- DUMP_PREFIX_OFFSET, 16, 1,
- buf, len, false);
- }
-
if (unlikely(addr == HW_ACCESS_ELP_CTRL_REG)) {
((u8 *)buf)[0] = sdio_f0_readb(func, addr, &ret);
dev_dbg(child->parent, "sdio read 52 addr 0x%x, byte 0x%02x\n",
@@ -107,6 +100,13 @@ static int __must_check wl12xx_sdio_raw_read(struct device *child, int addr,
if (WARN_ON(ret))
dev_err(child->parent, "sdio read failed (%d)\n", ret);

+ if (unlikely(dump)) {
+ printk(KERN_DEBUG "wlcore_sdio: READ from 0x%04x\n", addr);
+ print_hex_dump(KERN_DEBUG, "wlcore_sdio: READ ",
+ DUMP_PREFIX_OFFSET, 16, 1,
+ buf, len, false);
+ }
+
return ret;
}

--
2.6.4

2017-01-28 07:11:28

by Kalle Valo

Subject: Re: wlcore: print the sdio buffer after reading it

Guy Mishol <[email protected]> wrote:
> fix an issue where we printed the sdio buffer before
> actually read it.
>
> Signed-off-by: Guy Mishol <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

64ad08605e84 wlcore: print the sdio buffer after reading it

--
https://patchwork.kernel.org/patch/9539423/

Documentation about submitting wireless patches and checking status
from patchwork:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches