2017-03-22 19:21:16

by Andy Shevchenko

Subject: [PATCH v1] NFC: netlink: Use error code from nfc_activate_target()

It looks like a typo to assign a return code to a variable which is not
used. Found due to a compiler warning:

net/nfc/netlink.c: In function ‘nfc_genl_activate_target’:
net/nfc/netlink.c:903:6: warning: variable ‘rc’ set but not used [-Wunused-but-set-variable]
int rc;
^~

Signed-off-by: Andy Shevchenko <[email protected]>
---
net/nfc/netlink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/nfc/netlink.c b/net/nfc/netlink.c
index 03f3d5c7beb8..03be522127ec 100644
--- a/net/nfc/netlink.c
+++ b/net/nfc/netlink.c
@@ -918,7 +918,7 @@ static int nfc_genl_activate_target(struct sk_buff *skb, struct genl_info *info)
rc = nfc_activate_target(dev, target_idx, protocol);

nfc_put_device(dev);
- return 0;
+ return rc;
}

static int nfc_genl_dep_link_up(struct sk_buff *skb, struct genl_info *info)
--
2.11.0

2017-04-05 08:16:12

by Samuel Ortiz

Subject: Re: [PATCH v1] NFC: netlink: Use error code from nfc_activate_target()

Hi Andy,

On Wed, Mar 22, 2017 at 09:20:58PM +0200, Andy Shevchenko wrote:
> It looks like a typo to assign a return code to a variable which is not
> used. Found due to a compiler warning:
>
> net/nfc/netlink.c: In function ‘nfc_genl_activate_target’:
> net/nfc/netlink.c:903:6: warning: variable ‘rc’ set but not used [-Wunused-but-set-variable]
> int rc;
> ^~
>
> Signed-off-by: Andy Shevchenko <[email protected]>
> ---
> net/nfc/netlink.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.

Cheers,
Samuel.