2017-04-11 09:19:56

by Hans de Goede

Subject: [PATCH] staging: rtl8188eu: force driver to be built as a module

The rtl8188eu driver defines a ton of global symbols which tend to
conflict with other realtek wifi drivers, force it to be built as
a module.

Signed-off-by: Hans de Goede <[email protected]>
---
drivers/staging/rtl8188eu/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/staging/rtl8188eu/Kconfig b/drivers/staging/rtl8188eu/Kconfig
index 94f3879..cb836c5 100644
--- a/drivers/staging/rtl8188eu/Kconfig
+++ b/drivers/staging/rtl8188eu/Kconfig
@@ -1,6 +1,7 @@
config R8188EU
tristate "Realtek RTL8188EU Wireless LAN NIC driver"
depends on WLAN && USB && CFG80211
+ depends on m
select WIRELESS_EXT
select WEXT_PRIV
---help---
--
2.9.3

2017-04-11 11:30:19

by Arend Van Spriel

Subject: Re: [PATCH] staging: rtl8188eu: force driver to be built as a module

On 11-4-2017 11:19, Hans de Goede wrote:
> The rtl8188eu driver defines a ton of global symbols which tend to
> conflict with other realtek wifi drivers, force it to be built as
> a module.

Or get rid of those globals as we did to get out of staging :-p

Regards,
Arend

> Signed-off-by: Hans de Goede <[email protected]>
> ---
> drivers/staging/rtl8188eu/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/rtl8188eu/Kconfig b/drivers/staging/rtl8188eu/Kconfig
> index 94f3879..cb836c5 100644
> --- a/drivers/staging/rtl8188eu/Kconfig
> +++ b/drivers/staging/rtl8188eu/Kconfig
> @@ -1,6 +1,7 @@
> config R8188EU
> tristate "Realtek RTL8188EU Wireless LAN NIC driver"
> depends on WLAN && USB && CFG80211
> + depends on m
> select WIRELESS_EXT
> select WEXT_PRIV
> ---help---
>

2017-04-11 13:59:35

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: rtl8188eu: force driver to be built as a module

On Tue, Apr 11, 2017 at 01:30:16PM +0200, Arend Van Spriel wrote:
> On 11-4-2017 11:19, Hans de Goede wrote:
> > The rtl8188eu driver defines a ton of global symbols which tend to
> > conflict with other realtek wifi drivers, force it to be built as
> > a module.
>
> Or get rid of those globals as we did to get out of staging :-p

Give it time...