2017-04-17 10:07:45

by Vincent Legoll

Subject: [PATCH RFC] Make BCMA a menuconfig to ease disabling it all

Hello,

this is more what I wanted to achieve, an easily disableable BCMA menuconfig.

This is working as intended on x86_64 defconfig, whereas it is harder to disable
for ARCH=arm because of "select"s. But that's less of an issue, as those arch's
defconfigs may very well want the feature enbled, and that would make sense.

Any input appreciated.

Thanks

2017-04-17 10:07:48

by Vincent Legoll

Subject: [PATCH] Make BCMA a menuconfig to ease disabling it all

No need to get into the submenu to disable all BCMA-related config entries

Signed-off-by: Vincent Legoll <[email protected]>
---
drivers/bcma/Kconfig | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/drivers/bcma/Kconfig b/drivers/bcma/Kconfig
index b5c48a8..54f81c5 100644
--- a/drivers/bcma/Kconfig
+++ b/drivers/bcma/Kconfig
@@ -3,11 +3,8 @@ config BCMA_POSSIBLE
depends on HAS_IOMEM && HAS_DMA
default y

-menu "Broadcom specific AMBA"
- depends on BCMA_POSSIBLE
-
-config BCMA
- tristate "BCMA support"
+menuconfig BCMA
+ tristate "Broadcom specific AMBA"
depends on BCMA_POSSIBLE
help
Bus driver for Broadcom specific Advanced Microcontroller Bus
@@ -117,5 +114,3 @@ config BCMA_DEBUG
This turns on additional debugging messages.

If unsure, say N
-
-endmenu
--
2.9.3

2017-04-17 10:11:11

by Vincent Legoll

Subject: Re: [PATCH RFC] Make BCMA a menuconfig to ease disabling it all

Argh,

looks like the "--in-reply-to" did not hook it up properly...

This was intended as a reply to:
http://lkml.iu.edu/hypermail/linux/kernel/1704.1/04654.html
Re: [PATCH] Make AMBA a menuconfig to ease disabling it all
from (Fri Apr 14 2017 - 08:33:57 EST)

Sorry

--
Vincent Legoll

2017-05-19 06:08:39

by Kalle Valo

Subject: Re: Make BCMA a menuconfig to ease disabling it all

Vincent Legoll <[email protected]> wrote:
> No need to get into the submenu to disable all BCMA-related config entries
>
> Signed-off-by: Vincent Legoll <[email protected]>

I would like to get an ack from someone before I'll apply this.

Patch set to Deferred.

--
https://patchwork.kernel.org/patch/9683685/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2017-08-08 11:45:09

by Kalle Valo

Subject: Re: bcma: make BCMA a menuconfig to ease disabling it all

Vincent Legoll <[email protected]> wrote:

> No need to get into the submenu to disable all BCMA-related config entries.
>
> Signed-off-by: Vincent Legoll <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

9ca766b3641f bcma: make BCMA a menuconfig to ease disabling it all

--
https://patchwork.kernel.org/patch/9683685/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches