2017-04-14 21:28:07

by Arend Van Spriel

Subject: [PATCH] brcmfmac: only build fwsignal module for CONFIG_BRCMFMAC_PROTO_BCDC

The fwsignal module is only referenced by the bcdc module and part of the
bcdc protocol. So only build it when CONFIG_BRCMFMAC_PROTO_BCDC is selected.

Fixes: acf8ac41dd73 ("brcmfmac: remove reference to fwsignal data from struct brcmf_pub")
Signed-off-by: Arend van Spriel <[email protected]>
---
Hi Kalle,

This should do it. At least verified it with .config provided in the
report(s).

Happy easter ;-)

Regards,
Arend
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/Makefile b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/Makefile
index 0383ba5..1f5a9b9 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/Makefile
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/Makefile
@@ -25,7 +25,6 @@ brcmfmac-objs += \
chip.o \
fwil.o \
fweh.o \
- fwsignal.o \
p2p.o \
proto.o \
common.o \
@@ -36,7 +35,8 @@ brcmfmac-objs += \
vendor.o \
pno.o
brcmfmac-$(CONFIG_BRCMFMAC_PROTO_BCDC) += \
- bcdc.o
+ bcdc.o \
+ fwsignal.o
brcmfmac-$(CONFIG_BRCMFMAC_PROTO_MSGBUF) += \
commonring.o \
flowring.o \
--
1.9.1

2017-04-19 11:40:12

by Kalle Valo

Subject: Re: brcmfmac: only build fwsignal module for CONFIG_BRCMFMAC_PROTO_BCDC

Arend Van Spriel <[email protected]> wrote:
> The fwsignal module is only referenced by the bcdc module and part of the
> bcdc protocol. So only build it when CONFIG_BRCMFMAC_PROTO_BCDC is selected.
>
> Fixes: acf8ac41dd73 ("brcmfmac: remove reference to fwsignal data from struct brcmf_pub")
> Signed-off-by: Arend van Spriel <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

26ecfe017903 brcmfmac: only build fwsignal module for CONFIG_BRCMFMAC_PROTO_BCDC

--
https://patchwork.kernel.org/patch/9681805/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches