2017-05-17 16:22:59

by SF Markus Elfring

[permalink] [raw]
Subject: [PATCH] ssb: Delete an error message for a failed memory allocation in ssb_devices_register()

From: Markus Elfring <[email protected]>
Date: Wed, 17 May 2017 18:12:16 +0200

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <[email protected]>
---
drivers/ssb/main.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c
index d1a750760cf3..65420a9f0e82 100644
--- a/drivers/ssb/main.c
+++ b/drivers/ssb/main.c
@@ -480,7 +480,6 @@ static int ssb_devices_register(struct ssb_bus *bus)

devwrap = kzalloc(sizeof(*devwrap), GFP_KERNEL);
if (!devwrap) {
- ssb_err("Could not allocate device\n");
err = -ENOMEM;
goto error;
}
--
2.13.0


2017-05-17 21:05:42

by Michael Büsch

[permalink] [raw]
Subject: Re: [PATCH] ssb: Delete an error message for a failed memory allocation in ssb_devices_register()

On Wed, 17 May 2017 18:22:49 +0200
SF Markus Elfring <[email protected]> wrote:

> From: Markus Elfring <[email protected]>
> Date: Wed, 17 May 2017 18:12:16 +0200
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
> Signed-off-by: Markus Elfring <[email protected]>
> ---
> drivers/ssb/main.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c
> index d1a750760cf3..65420a9f0e82 100644
> --- a/drivers/ssb/main.c
> +++ b/drivers/ssb/main.c
> @@ -480,7 +480,6 @@ static int ssb_devices_register(struct ssb_bus *bus)
>
> devwrap = kzalloc(sizeof(*devwrap), GFP_KERNEL);
> if (!devwrap) {
> - ssb_err("Could not allocate device\n");
> err = -ENOMEM;
> goto error;
> }


This looks good.

Acked-by: Michael Büsch <[email protected]>


--
Michael

Attachments:
(No filename) (833.00 B)
OpenPGP digital signature

2017-05-24 13:47:21

by Kalle Valo

[permalink] [raw]
Subject: Re: ssb: Delete an error message for a failed memory allocation in ssb_devices_register()

SF Markus Elfring <[email protected]> wrote:
> From: Markus Elfring <[email protected]>
> Date: Wed, 17 May 2017 18:12:16 +0200
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
> Signed-off-by: Markus Elfring <[email protected]>
> Acked-by: Michael Büsch <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

c6c092dcb21e ssb: Delete an error message for a failed memory allocation in ssb_devices_register()

--
https://patchwork.kernel.org/patch/9731583/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches