2017-05-25 13:45:08

by Colin King

Subject: [PATCH][net-next] qtnfmac: remove duplicated assignment to mac

From: Colin Ian King <[email protected]>

mac is being assigned twice, remove redundant 2nd assignment.

Detected by CoverityScan, CID#1437554 ("Incorrect expression")

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/net/wireless/quantenna/qtnfmac/cfg80211.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c b/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c
index fc0ce2c09097..e3c090008125 100644
--- a/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c
+++ b/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c
@@ -922,7 +922,7 @@ void qtnf_netdev_updown(struct net_device *ndev, bool up)
void qtnf_virtual_intf_cleanup(struct net_device *ndev)
{
struct qtnf_vif *vif = qtnf_netdev_get_priv(ndev);
- struct qtnf_wmac *mac = mac = wiphy_priv(vif->wdev.wiphy);
+ struct qtnf_wmac *mac = wiphy_priv(vif->wdev.wiphy);

if (vif->wdev.iftype == NL80211_IFTYPE_STATION) {
switch (vif->sta_state) {
--
2.11.0

2017-05-25 13:56:39

by Sergey Matyukevich

Subject: Re: [PATCH][net-next] qtnfmac: remove duplicated assignment to mac

> mac is being assigned twice, remove redundant 2nd assignment.
>
> Detected by CoverityScan, CID#1437554 ("Incorrect expression")
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/net/wireless/quantenna/qtnfmac/cfg80211.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c b/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c
> index fc0ce2c09097..e3c090008125 100644
> --- a/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c
> +++ b/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c
> @@ -922,7 +922,7 @@ void qtnf_netdev_updown(struct net_device *ndev, bool up)
> void qtnf_virtual_intf_cleanup(struct net_device *ndev)
> {
> struct qtnf_vif *vif = qtnf_netdev_get_priv(ndev);
> - struct qtnf_wmac *mac = mac = wiphy_priv(vif->wdev.wiphy);
> + struct qtnf_wmac *mac = wiphy_priv(vif->wdev.wiphy);

Thanks !

Acked-by: Sergey Matyukevich <[email protected]>

2017-06-01 09:50:31

by Kalle Valo

Subject: Re: [net-next] qtnfmac: remove duplicated assignment to mac

Colin Ian King <[email protected]> wrote:

> From: Colin Ian King <[email protected]>
>
> mac is being assigned twice, remove redundant 2nd assignment.
>
> Detected by CoverityScan, CID#1437554 ("Incorrect expression")
>
> Signed-off-by: Colin Ian King <[email protected]>
> Acked-by: Sergey Matyukevich <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

4f8e25458cb6 qtnfmac: remove duplicated assignment to mac

--
https://patchwork.kernel.org/patch/9748407/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches