2017-06-08 08:06:52

by Martin Michlmayr

Subject: [PATCH] cfg80211: Fix grammar issue in error message

Fix grammar issue in error message about ISO3166.

Signed-off-by: Martin Michlmayr <[email protected]>

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
index cd1d6730eab7..c1ad81f34658 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
@@ -6767,7 +6767,7 @@ static void brcmf_cfg80211_reg_notifier(struct wiphy *wiphy,
/* ignore non-ISO3166 country codes */
for (i = 0; i < sizeof(req->alpha2); i++)
if (req->alpha2[i] < 'A' || req->alpha2[i] > 'Z') {
- brcmf_err("not a ISO3166 code (0x%02x 0x%02x)\n",
+ brcmf_err("not an ISO3166 code (0x%02x 0x%02x)\n",
req->alpha2[0], req->alpha2[1]);
return;
}

--
Martin Michlmayr
http://www.cyrius.com/

2017-06-13 06:59:23

by Kalle Valo

Subject: Re: [V3] brcmfmac: Fix grammar issue in error message

Martin Michlmayr <[email protected]> wrote:

> Fix grammar issue in error message about ISO3166.
>
> Signed-off-by: Martin Michlmayr <[email protected]>
> Acked-by: Arend van Spriel <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

a9507d5cfd52 brcmfmac: Fix grammar issue in error message

--
https://patchwork.kernel.org/patch/9779763/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2017-06-10 09:33:48

by Arend Van Spriel

Subject: Re: [PATCH] brcmfmac: iso cfg80211: Fix grammar issue in error message

Hah. That is (unintended?) fun. I actually meant to change the subject
from "cfg80211: Fix grammar issue in error message" into "brcmfmac: Fix
grammar issue in error message". Using the abbreviation "iso" in this
context was maybe a bit misleading of me.

One more purely educational note: when sending a reworked patch it is
good practice to use "[PATCH V2]" in the subject and add a changelog
between the signature tags and the diff separated by "---" so people now
what changed, ie.:

---
changes:
V2:
- updated subject prefix.
---

Thanks,
Arend

On 10-06-17 11:22, Martin Michlmayr wrote:
> Fix grammar issue in error message about ISO3166.
>
> Signed-off-by: Martin Michlmayr <[email protected]>
> Acked-by: Arend van Spriel <[email protected]>
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> index cd1d6730eab7..c1ad81f34658 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> @@ -6767,7 +6767,7 @@ static void brcmf_cfg80211_reg_notifier(struct wiphy *wiphy,
> /* ignore non-ISO3166 country codes */
> for (i = 0; i < sizeof(req->alpha2); i++)
> if (req->alpha2[i] < 'A' || req->alpha2[i] > 'Z') {
> - brcmf_err("not a ISO3166 code (0x%02x 0x%02x)\n",
> + brcmf_err("not an ISO3166 code (0x%02x 0x%02x)\n",
> req->alpha2[0], req->alpha2[1]);
> return;
> }
>

2017-06-10 09:40:10

by Martin Michlmayr

Subject: [PATCH V3] brcmfmac: Fix grammar issue in error message

Fix grammar issue in error message about ISO3166.

Signed-off-by: Martin Michlmayr <[email protected]>
Acked-by: Arend van Spriel <[email protected]>

---
changes:
V2 + V3:
- updated subject prefix.
---

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
index cd1d6730eab7..c1ad81f34658 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
@@ -6767,7 +6767,7 @@ static void brcmf_cfg80211_reg_notifier(struct wiphy *wiphy,
/* ignore non-ISO3166 country codes */
for (i = 0; i < sizeof(req->alpha2); i++)
if (req->alpha2[i] < 'A' || req->alpha2[i] > 'Z') {
- brcmf_err("not a ISO3166 code (0x%02x 0x%02x)\n",
+ brcmf_err("not an ISO3166 code (0x%02x 0x%02x)\n",
req->alpha2[0], req->alpha2[1]);
return;
}

--
Martin Michlmayr
http://www.cyrius.com/

2017-06-08 08:24:01

by Arend Van Spriel

Subject: Re: [PATCH] cfg80211: Fix grammar issue in error message

Please use the driver name as prefix, ie. brcmfmac: iso cfg80211:

On 08-06-17 10:01, Martin Michlmayr wrote:
> Fix grammar issue in error message about ISO3166.

Other than that....

Acked-by: Arend van Spriel <[email protected]>
> Signed-off-by: Martin Michlmayr <[email protected]>
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c

2017-06-10 10:42:20

by Martin Michlmayr

Subject: [PATCH] brcmfmac: iso cfg80211: Fix grammar issue in error message

Fix grammar issue in error message about ISO3166.

Signed-off-by: Martin Michlmayr <[email protected]>
Acked-by: Arend van Spriel <[email protected]>

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
index cd1d6730eab7..c1ad81f34658 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
@@ -6767,7 +6767,7 @@ static void brcmf_cfg80211_reg_notifier(struct wiphy *wiphy,
/* ignore non-ISO3166 country codes */
for (i = 0; i < sizeof(req->alpha2); i++)
if (req->alpha2[i] < 'A' || req->alpha2[i] > 'Z') {
- brcmf_err("not a ISO3166 code (0x%02x 0x%02x)\n",
+ brcmf_err("not an ISO3166 code (0x%02x 0x%02x)\n",
req->alpha2[0], req->alpha2[1]);
return;
}

--
Martin Michlmayr
http://www.cyrius.com/